- 31 Oct, 2003 3 commits
-
-
unknown authored
- when we don't have in_addr_t, use uint32. - a forgotten initialization of slave_proxy_id in sql/log_event.cc (was not really "forgot", was "we needn't init it there", but there was one case where we needed...). - made slave_proxy_id always meaningful in THD and Log_event, so we can rely more on it (no need to test if it's meaningful). THD::slave_proxy_id is equal to THD::thread_id except for the slave SQL thread. - clean up the slave's temporary table (i.e. free their memory) when slave server shuts down. extra/resolveip.c: removed #define as it is simpler to put it in my_net.h (because we need the #define elsewhere) include/my_net.h: When in_addr_t is not defined, use uint32. libmysql/libmysql.c: using in_addr_t is more generic. libmysql/manager.c: using in_addr_t is more generic. mysql-test/t/rpl_chain_temp_table.test: comments sql/log_event.cc: * Had forgot to initialize slave_proxy_id in the event constructor (char* buf...). Initializing is in fact only needed for Create_file_log_event, because it uses slave_proxy_id even if it does not write an event to the binlog (it uses slave_proxy_id to write it to SQL-LOAD.info). * When we write events we now always write slave_proxy_id, which is now always meaningful (as thd->slave_proxy_id is now always meaningful, see change in sql_class.cc). sql/mini_client.cc: in_addr_t is more generic. sql/slave.cc: A RELAY_LOG_INFO method to free the slave's temporary tables from memory at slave's server shutdown. It is called by end_slave(), which is called by close_connections(), which is called when the server terminates (close_connections() is just before clean_up(); putting the call in clean_up() was buggy, as active_mi is already deleted by close_connections(). sql/slave.h: new method sql/sql_class.cc: By default we set THD::slave_proxy_id to THD::thread_id, so THD::slave_proxy_id is always meaningful (not 0). It's always the same as the thread id except for the slave SQL thread.
-
unknown authored
libmysqld/Makefile.am: minor fix for rm
-
unknown authored
of lock scope
-
- 30 Oct, 2003 6 commits
-
-
unknown authored
into mysql.com:/home/kostja/mysql/mysql-4.0-root
-
unknown authored
thd->proc_info added sql/sql_class.h: comments about thd->where and thd->proc_info added
-
unknown authored
into mysql.com:/home/mysql_src/mysql-4.0
-
unknown authored
mysql-test-run --manager --valgrind (without this fix, the manager fails to start mysqld and the tests hang). mysql-test/mysql-test-run.sh: When running with --manager: the MySQL manager wants the complete path of the executable (it uses execv(), not execvp(), so does not search in the $PATH, so telling him to start 'valgrind' is not enough, it wants '/usr/bin/valgrind' or so). So this is a fix to be able to mysql-test-run --manager --valgrind Plus a warning (previously, if valgrind was not installed, tests silently hanged when run with --valgrind).
-
unknown authored
into mysql.com:/home/kostja/mysql/mysql-4.0-root
-
unknown authored
BitKeeper/etc/logging_ok: Logging to logging@openlogging.org accepted
-
- 29 Oct, 2003 5 commits
-
-
unknown authored
-
unknown authored
Don't add service name to read config file segments if it's "MySQL" Fixed possible memory leak when CHANGE USER failed. include/mysql_com.h: Change back service name to MySQL (With new, better spelling) myisam/myisamchk.c: Improved --help sql/mysqld.cc: Don't add service name to read config file segments if it's "MySQL" sql/sql_parse.cc: Fixed possible memory leak when CHANGE USER failed.
-
unknown authored
"If 2 master threads with same-name temp table, slave makes bad binlog" and (two birds with one stone) for BUG#1240 "slave of slave breaks when STOP SLAVE was issud on parent slave and temp tables". Here is the design change: in a slave running with --log-slave-updates, events are now logged with the thread id they had on the master. So no more id conflicts between master threads, but introduces id conflicts between one master thread and one normal client thread connected to the slave. This is solved by storing the server id in the temp table's name. New test which requires mysql-test-run to be run with --manager, otherwise it will be skipped. Undoing a Monty's change (hum, a chill runs down my spine ;) which was "Cleanup temporary tables when slave ends" in ChangeSet 1.1572.1.1. mysql-test/mysql-test-run.sh: One new test which needs more than one slave so must be hardcoded in mysql-test-run.sh. sql/log_event.cc: The event needs to carry a slave_proxy_id (which is set at event's creation and used at event's logging). This is used for events created by ::exec_event() in the slave SQL thread: now we want to log these events with the thread id they had on the master. This is so that several same-name temp tables simultaneously created on the master end up with not the same thread id in the slave's binlog. sql/log_event.h: Query and Load need to carry a slave_proxy_id, like they carried a thread_id (to replicate temp tables well). sql/slave.cc: Do not free temp tables in the slave SQL thread. Or they will be lost when one does STOP SLAVE / START SLAVE. We even save them in rli->save_temporary_tables and set thd->temporary_tables=0 to prevent them to be freed. sql/sql_base.cc: Put the server id in the table cache key name for temp tables (we already put the slave_proxy_id, but we also need the server id in case normal clients (not slave threads) are using temp tables on the slave). sql/unireg.h: 4 more bytes, to store the server id.
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-4.0
-
unknown authored
-
- 28 Oct, 2003 3 commits
-
-
unknown authored
into narttu.mysql.fi:/my/mysql-4.0
-
unknown authored
mysql --install mysql --defualts-file=path-to-file (Bug #1643) include/mysql_com.h: MySQL should install as default service "mysqld" sql/mysqld.cc: Fix for problem of installing MySQL as a service with mysql --install mysql --defualts-file=path-to-file
-
unknown authored
If innodb_force_recovery >= 5, do not try to fetch an old version of a clustered index record: this reduces crashes when dumping tables from a corrupt database innobase/row/row0sel.c: If innodb_force_recovery >= 5, do not try to fetch an old version of a clustered index record: this reduces crashes when dumping tables from a corrupt database
-
- 27 Oct, 2003 2 commits
- 25 Oct, 2003 4 commits
- 24 Oct, 2003 3 commits
- 23 Oct, 2003 4 commits
-
-
unknown authored
into mysql.com:/home/pem/work/mysql-4.0
-
unknown authored
-
unknown authored
-
unknown authored
BitKeeper/etc/logging_ok: auto-union sql/mini_client.cc: Auto merged client/mysqlbinlog.cc: use local file mysql-test/t/myisam.test: Remove uncessesary drop table sql/sql_parse.cc: Use local sql/sql_repl.cc: use local
-
- 22 Oct, 2003 5 commits
-
-
unknown authored
in MySQL server...
-
unknown authored
to cause program to abort. Such table name could have been one with a semicolon (:) in the middle.
-
unknown authored
directory owner ship was not honored.
-
unknown authored
using regexp with tablenames together with databasenames.
-
unknown authored
into gluh.mysql.r18.ru:/home/gluh/mysql-4.0.pass
-
- 21 Oct, 2003 5 commits
-
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-4.0
-
unknown authored
4.0.16 has been tagged and released - tagged ChangeSet 1.1576.1.5 as "mysql-4.0.16" configure.in: - bumped up version number to 4.0.17 now that 4.0.16 has been tagged and released
-
unknown authored
-
unknown authored
into mysql.com:/home/mysql_src/mysql-4.0 mysql-test/r/rpl_trunc_binlog.result: Auto merged
-
unknown authored
** I already fixed it in 3.23; I fix it in 4.0 separately because the code is a bit different (so the changeset 1.1422 of 3.23 should not be merged here) ** Make mysqlbinlog prompt for the password if mysqlbinlog -p instead of printing the usage(). This makes mysqlbinlog behave like other clients. This new code was almost copied from mysqldump. Note that before, one could use mysqlbinlog -p pass and now one must use mysqlbinlog -ppass (putting a space will ask for the password). client/mysqlbinlog.cc: Make mysqlbinlog prompt for the password if mysqlbinlog -p instead of printing the usage(). This makes mysqlbinlog behave like other clients. This new code was almost copied from mysqldump. Note that before, one could use mysqlbinlog -p pass and now one must use mysqlbinlog -ppass (putting a space will ask for the password).
-