1. 09 Apr, 2007 1 commit
  2. 06 Apr, 2007 5 commits
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-runtime · a005dfb6
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      sql/parse_file.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      a005dfb6
    • unknown's avatar
      Polishing: note added. · 52b86a6e
      unknown authored
      52b86a6e
    • unknown's avatar
      Remove a race between Event Scheduler shutdown and SHOW PROCESSLIST. · c557623a
      unknown authored
      This will hopefully fix events.test failure on vmware-win32, 
      where scheduling is very primitive.
      
      
      mysql-test/t/events_scheduling.test:
        This test case has no races now and can be enabled under valgrind.
      sql/event_scheduler.cc:
        Make Event Scheduler thread shutdown more synchronous: report
        successful shutdown only after having removed the scheduler
        thread from the global list of threads.
        This ensures that after the scheduler has been stopped, its
        thread is not present in SHOW PROCESSLIST output.
      c557623a
    • unknown's avatar
      Polishing: add comments. · 9bc5135f
      unknown authored
      
      sql/parse_file.cc:
        Add comments.
      9bc5135f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 306be7fe
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/openssl_1.result:
        Manual resolve.
      mysql-test/t/openssl_1.test:
        Manual resolve.
      306be7fe
  3. 05 Apr, 2007 12 commits
    • unknown's avatar
      Fix events.test failure on manu pushbuild hosts (5.1-runtime). · 93e7a470
      unknown authored
      
      sql/event_db_repository.cc:
        Fix events.test failure on many pushbuild hosts (5.1-runtime).
        Make sure that when reading mysql.event the key number matches
        the field number that we're using to read by key.
        Also, print an error in case of a handler error (to not return 
        'Unknown error' when a table is corrupted to the user).
      93e7a470
    • unknown's avatar
      A fix for events_trans.test failure on many hosts (5.1-runtime) · a06ff976
      unknown authored
      
      sql/event_data_objects.cc:
        Disable an event if its data in the table is corrupted.
      sql/events.cc:
        A fix for events_trans failure on most of the hosts.
        A better error message if the event table is old
        (don't suggest it's corrupted, it may simply have bad data).
      a06ff976
    • unknown's avatar
      3d attempt to fix information_schema.test failure on HP-UX. · dd0c20ac
      unknown authored
      Apparently it's the only platform in pushbuild where we 
      compile without openssl.
      
      
      mysql-test/r/information_schema.result:
        Update results.
      mysql-test/r/openssl_1.result:
        Update results.
      mysql-test/t/information_schema.test:
        Move the part of the test case that needs SSL support to 
        openssl_1.test
      mysql-test/t/openssl_1.test:
        Add a test case that needs SSL support.
      dd0c20ac
    • unknown's avatar
      Fix a compile failure on Windows. · 25677bdc
      unknown authored
      25677bdc
    • unknown's avatar
      Fix a compile error with LINT enabled builds. · aadfe5e7
      unknown authored
      aadfe5e7
    • unknown's avatar
      Remove a dead file. · 923d2d3a
      unknown authored
      
      BitKeeper/deleted/.del-openssl_2.result:
        Delete: mysql-test/r/openssl_2.result
      923d2d3a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 40e17891
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-c1
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.cc:
        Auto merged
      40e17891
    • unknown's avatar
      Post-merge and post-review fixes for the patch for · ff452d05
      unknown authored
      Bug#23631 "Events: SHOW VARIABLES doesn't work when mysql.event 
      is damaged:
      
      
      mysql-test/r/events.result:
        Update results (a post-merge fix)
      mysql-test/r/events_bugs.result:
        Update results (a post-merge fix)
      mysql-test/r/events_scheduling.result:
        Update results (a post-merge fix)
      mysql-test/t/events_scheduling.test:
        Make sure this test has no races.
      sql/event_data_objects.cc:
        Manual post-merge fix for the events replication patch.
      sql/event_data_objects.h:
        A post-merge fix.
      sql/event_db_repository.cc:
        A post-merge fix.
      sql/event_scheduler.cc:
        We should drop the event inside ::execute since there we have
        the right credentials to do so (otherwise Events::drop_event
        returns "access denied" error).
      sql/events.cc:
        A post-review fix for: rename start_or_stop_event_scheduler
        to switch_event_scheduler_state.
      sql/events.h:
        A post-review fix for: rename start_or_stop_event_scheduler
        to switch_event_scheduler_state.
      sql/set_var.cc:
        A post-review fix for: rename start_or_stop_event_scheduler
        to switch_event_scheduler_state.
      sql/sql_yacc.yy:
        Remove unused declaratoins.
      ff452d05
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · b4f1d7ba
      unknown authored
      into  siva.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      mysql-test/r/information_schema.result:
        Auto merged
      b4f1d7ba
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · a36054f4
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-c1
      
      
      mysql-test/r/events_bugs.result:
        Auto merged
      mysql-test/r/events_scheduling.result:
        Auto merged
      mysql-test/t/events.test:
        Auto merged
      mysql-test/t/events_scheduling.test:
        Auto merged
      sql/event_data_objects.h:
        Auto merged
      sql/event_db_repository.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/set_var.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/table.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      mysql-test/r/events.result:
        e
        Use local.
      mysql-test/r/events_restart_phase1.result:
        Use local
      mysql-test/r/events_time_zone.result:
        SCCS merged
      mysql-test/t/events_restart_phase1.test:
        Use local
      sql/event_data_objects.cc:
        Use local
      sql/event_db_repository.cc:
        Manual merge.
      sql/event_queue.cc:
        Manual merge.
      sql/events.cc:
        Manual merge.
      a36054f4
    • unknown's avatar
      A set of changes aiming to make the Event Scheduler more user-friendly · fa1d637e
      unknown authored
      when there are no up-to-date system tables to support it:
       - initialize the scheduler before reporting "Ready for connections".
         This ensures that warnings, if any, are printed before "Ready for
         connections", and this message is not mangled.
       - do not abort the scheduler if there are no system tables
       - check the tables once at start up, remember the status and disable
         the scheduler if the tables are not up to date.
         If one attempts to use the scheduler with bad tables,
         issue an error message.
       - clean up the behaviour of the module under LOCK TABLES and pre-locking
         mode
       - make sure implicit commit of Events DDL works as expected.
       - add more tests
      
      
      Collateral clean ups in the events code.
      
      This patch fixes Bug#23631 Events: SHOW VARIABLES doesn't work 
      when mysql.event is damaged
      
      
      mysql-test/r/events.result:
        Update results.
      mysql-test/r/events_bugs.result:
        Update results.
      mysql-test/r/events_restart_phase1.result:
        Update results.
      mysql-test/r/events_restart_phase2.result:
        Update results.
      mysql-test/r/events_restart_phase3.result:
        Update results.
      mysql-test/r/events_scheduling.result:
        Update results.
      mysql-test/r/events_time_zone.result:
        Update results.
      mysql-test/t/events.test:
        Add new tests for tampering with mysql.event and some more
        tests for sub-statements, LOCK TABLES mode and pre-locking.
      mysql-test/t/events_bugs.test:
        Move the non-concurrent part of test for Bug 16420 to this file.
      mysql-test/t/events_restart_phase1.test:
        Rewrite events_restart_* tests to take into account that now
        we check mysql.event table only once, at server startup.
      mysql-test/t/events_restart_phase2.test:
        Rewrite events_restart_* tests to take into account that now
        we check mysql.event table only once, at server startup.
      mysql-test/t/events_restart_phase3.test:
        Rewrite events_restart_* tests to take into account that now
        we check mysql.event table only once, at server startup.
      mysql-test/t/events_scheduling.test:
        Add more coverage for event_scheduler global variable.
      mysql-test/t/events_time_zone.test:
        Move the non-concurrent part of the tests for Bug 16420 to 
        events_bugs.test
      sql/event_data_objects.cc:
        Move update_timing_fields functionality to Event_db_repository.
        Make loading of events from a table record more robust to tampering
        with the table - now we do not check mysql.event on every table open.
      sql/event_data_objects.h:
        Cleanup.
      sql/event_db_repository.cc:
        Now Event_db_repository is responsible for table I/O only.
        All the logic of events DDL is handled outside, in Events class please
        refer to the added test coverage to see how this change affected
        the behavior of Event Scheduler.
        Dependency on sp_head.h and sp.h removed.
        Make this module robust to tweaks with mysql.event table.
        Move check_system_tables from events.cc to this file
      sql/event_db_repository.h:
        Cleanup declarations (remove unused ones, change return type to bool
        from int).
      sql/event_queue.cc:
        Update to adapt to the new start up scheme of the Event Scheduler.
      sql/event_queue.h:
        Cleanup declarations.
      sql/event_scheduler.cc:
        Make all the error messages uniform:
        [SEVERITY] Event Scheduler: [user][schema.event] message
        Using append_identifier for error logging was an overkill - we may 
        need it only if the system character set may have NUL (null character)
        as part of a valid identifier, this is currently never the case, 
        whereas additional quoting did not look nice in the log.
      sql/event_scheduler.h:
        Cleanup the headers.
      sql/events.cc:
        Use a different start up procedure of Event Scheduler:
        - at start up, try to check the system tables first.
        If they are not up-to-date, disable the scheduler.
        - try to load all the active events. In case of a load error, abort
        start up.
        - do not parse an event on start up. Parsing only gives some information
        about event validity, but far not all.
        Consolidate the business logic of Events DDL in this module.
        Now opt_event_scheduler may change after start up and thus is protected
        by LOCK_event_metadata mutex.
      sql/events.h:
        Use all-static-data-members approach to implement Singleton pattern.
      sql/mysqld.cc:
        New invocation scheme of Events. Move some logic to events.cc.
        Initialize the scheduler before reporting "Ready for connections".
      sql/set_var.cc:
        Clean up sys_var_thd_sql_mode::symbolic_mode_representation
        to work with a LEX_STRING.
        Move more logic related to @@events_scheduler global variable to Events
        module.
      sql/set_var.h:
        Update declarations.
      sql/share/errmsg.txt:
        If someone tampered with mysql.event table after the server has
        started we no longer give him/her a complete report what was actually 
        broken. Do not send the user to look at the error log in such case,
        as there is nothing there (check_table_intact is not executed).
      sql/sp_head.cc:
        Update to a new declaration of 
        sys_var_thd_sql_mode::symbolic_mode_representation
      sql/sql_db.cc:
        New invocation scheme of Events module.
      sql/sql_parse.cc:
        Move more logic to Events module. Make sure that we are consistent
        in the way access rights are checked for Events DDL: always
        after committing the current transaction and checking the system tables.
      sql/sql_show.cc:
        Update to the new declarations of 
        sys_var_thd_sql_mode::symbolic_mode_representation
      sql/sql_test.cc:
        New invocation scheme of events.
      sql/table.cc:
        mysql.event is a system table.
        Update check_table_intact to be concurrent, more verbose, and less smart.
      sql/table.h:
        Add a helper method.
      mysql-test/r/events_trans.result:
        New BitKeeper file ``mysql-test/r/events_trans.result''
      mysql-test/t/events_trans.test:
        New BitKeeper file ``mysql-test/t/events_trans.test'':
        test cases for Event Scheduler that require a transactional
        storage engine.
      fa1d637e
    • unknown's avatar
      Add extra INSERT to make usre sync_slave_with_master has job to do · c66a1528
      unknown authored
      
      mysql-test/r/rpl_ssl.result:
        Add an extra INSERT to make sure that the "sync_slave_with_master" has
        someghing to do and thus have to wait for the slave IO thread
        to start.
      mysql-test/t/rpl_ssl.test:
        Add an extra INSERT to make sure that the "sync_slave_with_master" has
        someghing to do and thus have to wait for the slave IO thread
        to start.
      c66a1528
  4. 04 Apr, 2007 7 commits
    • unknown's avatar
      Fix a failure of this test case on HP-UX. · a0c4e184
      unknown authored
      
      mysql-test/r/information_schema.result:
        Fix a race in the test case (second attempt).
      mysql-test/t/information_schema.test:
        Fix a race in the test case (second attempt).
      a0c4e184
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/51 · 7bdfa351
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/51
      
      
      7bdfa351
    • unknown's avatar
      Bug #27638: slow logging to CSV table inserts bad query_time and lock_time values · 821355da
      unknown authored
      When MySQL logged slow query information to a CSV table, it stored the
      query_time and lock_time values with an incorrect formula.
      
      If the time was over 59 seconds, this caused incorrect statistics (either the
      slow query was not logged, or the time was far from correct).  This change
      fixes the method used to store those TIME values in the slow_log table.
      
      
      mysql-test/r/log_tables-big.result:
        BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/r/log_tables-big.result
      mysql-test/t/log_tables-big-master.opt:
        BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/t/log_tables-big-master.opt
      mysql-test/t/log_tables-big.test:
        BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/t/log_tables-big.test
      sql/time.cc:
        initialize all TIME fields (except neg, which may store a
        needed value) in calc_time_from_sec()
      sql/log.cc:
        Log_to_csv_event_handler::log_slow(): call store_time() instead of store() for query_time and lock_time
      include/my_time.h:
        Add TIME_MAX_VALUE_SECONDS definition
      821355da
    • unknown's avatar
      Portability fix to work around OS X -x86 toolchain bug with common (uninitialized data) symbols · c5bb750f
      unknown authored
      
      mysys/my_pthread.c:
        Initialize thd_lib_detected for portability (OS X -x86)
      c5bb750f
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/50 · f9b53a4e
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/51
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/type_datetime.result:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f9b53a4e
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1895cdb3
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/50
      
      
      sql/item_func.cc:
        Auto merged
      1895cdb3
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1 · 05840a57
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/51
      
      
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.cc:
        Auto merged
      05840a57
  5. 03 Apr, 2007 9 commits
    • unknown's avatar
      Bug #20376 Doesn't auto-detect data dir · 73fb1aed
      unknown authored
      This changeset fixes the problem where mysql, when run as a service,
      can't "detect" it's own data directory.
      
      
      sql/mysqld.cc:
        When running on Windows we check to see if we have a hard path in 
        my_progname.  If not, then we use GetModuleFilename to get the full path
        for the executing module.  This allows the program to determine where
        it's at when running as a service.
      73fb1aed
    • unknown's avatar
      Fix a race that breaks the valgrind build. · 65e5af7b
      unknown authored
      
      mysql-test/r/information_schema.result:
        Fix a race (updated result file)
      mysql-test/t/information_schema.test:
        Fix a race in a test.
      65e5af7b
    • unknown's avatar
    • unknown's avatar
      b9bba4f4
    • unknown's avatar
      Merge bodhi.local:/opt/local/work/mysql-5.0-runtime · 62569b75
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      sql/item_func.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      62569b75
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 7b1bfbb7
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/r/events_bugs.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/events.test:
        Auto merged
      sql/event_data_objects.cc:
        Auto merged
      sql/event_data_objects.h:
        Auto merged
      sql/event_db_repository.h:
        Auto merged
      sql/event_queue.cc:
        Auto merged
      sql/events.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_servers.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      mysql-test/r/events.result:
        Manual merge.
      sql/event_db_repository.cc:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      7b1bfbb7
    • unknown's avatar
      Cleanup tables created by test cases · 48b3529c
      unknown authored
      
      mysql-test/r/crash_commit_before.result:
        Cleanup
      mysql-test/r/rpl_ignore_table.result:
        Cleanup
      mysql-test/r/rpl_packet.result:
        Cleanup
      mysql-test/r/rpl_ssl.result:
        Cleanup
      mysql-test/t/crash_commit_before.test:
        Cleanup
      mysql-test/t/rpl_ignore_table.test:
        Cleanup
      mysql-test/t/rpl_packet.test:
        Cleanup
      mysql-test/t/rpl_ssl.test:
        Cleanup
      48b3529c
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-new-maint · d423e558
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.1-maint
      
      
      d423e558
    • unknown's avatar
      Work around for bug#27606 · efaf8c74
      unknown authored
      efaf8c74
  6. 02 Apr, 2007 6 commits