1. 07 Jul, 2008 3 commits
    • Mattias Jonsson's avatar
      merge · c2c4cd1e
      Mattias Jonsson authored
      c2c4cd1e
    • Mattias Jonsson's avatar
      Bug#35745: SELECT COUNT(*) is not correct for some partitioned tables. · d11d5cfc
      Mattias Jonsson authored
      problem was that ha_partition::records was not implemented, thus
      using the default handler::records, which is not correct if the engine
      does not support HA_STATS_RECORDS_IS_EXACT.
      Solution was to implement ha_partition::records as a wrapper around
      the underlying partitions records.
      
      The rows column in explain partitions will now include the total
      number of records in the partitioned table.
      
      (recommit after removing out-commented code)
      
      d11d5cfc
    • Georgi Kodinov's avatar
      Bug#37627: addendum : · 50853ac3
      Georgi Kodinov authored
       - moved the test into a separate file to check for presence of the test variable
      
      mysql-test/r/subselect.result:
        Bug#37627: moved the test to a separate file
      mysql-test/r/subselect_debug.result:
        Bug#37627: moved the test to a separate file
      mysql-test/t/subselect.test:
        Bug#37627: moved the test to a separate file
      mysql-test/t/subselect_debug.test:
        Bug#37627: moved the test to a separate file
      50853ac3
  2. 04 Jul, 2008 5 commits
  3. 03 Jul, 2008 3 commits
    • Konstantin Osipov's avatar
      A fix for · 7b8bfb2a
      Konstantin Osipov authored
      Bug#12093 "SP not found on second PS execution if another thread 
      drops other SP in between" and
      Bug#21294 "executing a prepared statement that executes a stored 
      function which was recreat"
      
      Stored functions are resolved at prepared statement prepare only.
      If someone flushes the stored functions cache between prepare and
      execute, execution fails.
      
      The fix is to detect the situation of the cache flush and automatically
      reprepare the prepared statement after it.
      
      mysql-test/r/ps_ddl.result:
        Update results (Bug#12093 and Bug#21294, the test cases are already
        in the source tree).
      mysql-test/r/ps_ddl1.result:
        Update results (Bug#12093 and Bug#21294, the test cases are already
        in the source tree).
      mysql-test/r/sp-error.result:
        Update results (Bug#12093 and Bug#21294, the test cases are already
        in the source tree).
      mysql-test/t/ps_ddl.test:
        Modify the test to not expect an error where there is no error
        any more (Bug#12093, Bug#21294).
      mysql-test/t/ps_ddl1.test:
        Modify the test to not expect an error where there is no error
        any more (Bug#12093, Bug#21294).
      mysql-test/t/sp-error.test:
        Modify the test to not expect an error where there is no error
        any more (Bug#12093, Bug#21294).
      sql/sp_cache.cc:
        Implement sp_cache_version() -- returns the current version of 
        a stored routines cache.
      sql/sp_cache.h:
        Declare sp_cache_version().
      sql/sql_prepare.cc:
        Keep track of stored functions cache version, and invalidate
        the statement if it changed between prepared statement
        prepare and execute (and the statement actually uses stored routines).
      7b8bfb2a
    • Sven Sandberg's avatar
      merge · b6b6d98f
      Sven Sandberg authored
      b6b6d98f
    • Sven Sandberg's avatar
      BUG#37200: rpl_switch_stm_row_mixed fails sporadically in pushbuild · 25b6b026
      Sven Sandberg authored
      This bug has been fixed in two slightly different ways in
      6.0-rpl and {5.1,6.0}-bugteam. To avoid future merge
      problems, I'm now copying the 6.0-rpl fix to 5.1-bugteam.
      25b6b026
  4. 02 Jul, 2008 3 commits
  5. 01 Jul, 2008 3 commits
    • Patrick Crews's avatar
      upmerge into 5.1 · 12607d4b
      Patrick Crews authored
      12607d4b
    • Patrick Crews's avatar
      Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X · 9393ae3d
      Patrick Crews authored
      Test was failing due to the addition of a '\x05' character in result sets
      Latest builds of the server have shown this problem to have disappeared.
      Removing code within the test that disables the test on Mac OS X.
      
      Recommit due to tree error on earlier, approved patch.
      9393ae3d
    • Mattias Jonsson's avatar
      Bug#36732: many disabled ndb tests in test suite parts · 67174b71
      Mattias Jonsson authored
      REORGANIZE TEST parts WHERE ENGINE='NDB' ;)
      
      Updated tests for better matching NDB's limitations.
      
      Removed some duplicate tests.
      
      mysql-test/suite/parts/inc/part_supported_sql_funcs_delete.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added variable for NDB (since it does not support
        DROP PARTITION)
      mysql-test/suite/parts/inc/partition_alter_11.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Assigning directly to variable without going
        through the server.
      mysql-test/suite/parts/inc/partition_bigint.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added --sorted_result for consistency
        lowered number of partitions for use with NDB
        (NDB can only do maximum of 8 partitions)
      mysql-test/suite/parts/inc/partition_int.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added --sorted_result for consistency
        lowered number of partitions for use with NDB
        (NDB can only do maximum of 8 partitions)
      mysql-test/suite/parts/inc/partition_mediumint.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added --sorted_result for consistency
        lowered number of partitions for use with NDB
        (NDB can only do maximum of 8 partitions)
      mysql-test/suite/parts/inc/partition_smallint.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added --sorted_result for consistency
        lowered number of partitions for use with NDB
        (NDB can only do maximum of 8 partitions)
      mysql-test/suite/parts/inc/partition_supported_sql_funcs.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Made it work better with NDB
      mysql-test/suite/parts/inc/partition_tinyint.inc:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added --sorted_result for consistency
        lowered number of partitions for use with NDB
        (NDB can only do maximum of 8 partitions)
      mysql-test/suite/parts/r/ndb_blob_partition.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/r/ndb_dd_backuprestore.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/ndb_partition_error.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/r/ndb_partition_key.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/r/ndb_partition_list.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/r/ndb_partition_range.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/r/part_supported_sql_func_ndb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_alter1_1_innodb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_alter1_1_myisam.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_alter1_2_innodb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file.
        Diff bigger than necessary, due to bzr diff bug.
      mysql-test/suite/parts/r/partition_alter1_2_myisam.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_alter2_innodb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_alter2_myisam.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_engine_ndb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_int_innodb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_int_myisam.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/partition_int_ndb.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Updated result file
      mysql-test/suite/parts/r/rpl_ndb_dd_partitions.result:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/rpl_ndb
      mysql-test/suite/parts/t/disabled.def:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removed some duplicate tests, fixed some tests.
        Removed the 'runs too long on PB' test from
        disabled.def and made them to require 'big-test'.
      mysql-test/suite/parts/t/ndb_blob_partition.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/t/ndb_dd_backuprestore.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/ndb_partition_error.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/t/ndb_partition_key.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/t/ndb_partition_list.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/t/ndb_partition_range.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/ndb
      mysql-test/suite/parts/t/part_supported_sql_func_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
        Added ndb restriction variables.
      mysql-test/suite/parts/t/partition_alter1_1_2_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        requiring big-test instead of disable it.
      mysql-test/suite/parts/t/partition_alter1_1_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        requiring big-test instead of disable it.
      mysql-test/suite/parts/t/partition_alter1_2_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        requiring big-test instead of disable it.
      mysql-test/suite/parts/t/partition_alter2_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_basic_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_bit_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_engine_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_int_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_syntax_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/partition_value_ndb.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Added new=on for allowing test of
        hash/range and list partitioning.
      mysql-test/suite/parts/t/rpl_ndb_dd_partitions.test:
        Bug#36732: many disabled ndb tests in test suite parts
        
        Removing this duplicate test since it already
        exists (and updated) in suite/rpl_ndb
      67174b71
  6. 30 Jun, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#37200: rpl_switch_stm_row_mixed fails sporadically in pushbuild · 0a60bd22
      Sven Sandberg authored
      Problem: rpl_switch_stm_row_mixed did not wait until row events generated by
      INSERT DELAYED were written to the master binlog before it synchronized slave
      with master. This caused sporadic errors where these rows were missing on
      slave.
      Fix: wait until all rows appear on the slave.
      This is a backport, applying the same to 5.1-bugteam as was previously
      applied to 6.0-rpl
      0a60bd22
  7. 27 Jun, 2008 8 commits
    • Timothy Smith's avatar
      75b6ab90
    • Timothy Smith's avatar
      Merge from upstream (my:5.0-bugteam) · fe87c0db
      Timothy Smith authored
      fe87c0db
    • Timothy Smith's avatar
      Up-merge from 5.0: Fix for Bug#20748, Configuration files should not be read more than once · 18432cc4
      Timothy Smith authored
      Differences in 5.1: include "/etc/mysql/" in include directories; no OS/2 support.
      18432cc4
    • Gleb Shchepa's avatar
      auto merge from local tree · 89f06e9d
      Gleb Shchepa authored
      89f06e9d
    • Gleb Shchepa's avatar
      Fixed bug #36632: SELECT DISTINCT from a simple view on an · a8067140
      Gleb Shchepa authored
                        InnoDB table, where all selected columns
                        belong to the same unique index key, returns
                        incorrect results
      
      Server executes some queries via QUICK_GROUP_MIN_MAX_SELECT
      (MIN/MAX optimization for queries with GROUP BY or DISTINCT
      clause) and that optimization implies loose index scan, so all
      grouping is done by the QUICK_GROUP_MIN_MAX_SELECT::get_next
      method.
      
      The server does not set the precomputed_group_by flag for some
      QUICK_GROUP_MIN_MAX_SELECT queries and duplicates grouping by
      call to the end_send_group function.
      
      Fix: when the test_if_skip_sort_order function selects loose 
      index scan as a best way to satisfy an ORDER BY/GROUP BY type
      of query, the precomputed_group_by flag has been set to use 
      end_send/end_write functions instead of end_send_group/
      end_write_group functions.
      
      
      mysql-test/r/group_min_max_innodb.result:
        Fixed bug #36632: SELECT DISTINCT from a simple view on an
                          InnoDB table, where all selected columns
                          belong to the same unique index key, returns
                          incorrect results
      mysql-test/t/group_min_max_innodb.test:
        Fixed bug #36632: SELECT DISTINCT from a simple view on an
                          InnoDB table, where all selected columns
                          belong to the same unique index key, returns
                          incorrect results
      sql/sql_select.cc:
        Fixed bug #36632: SELECT DISTINCT from a simple view on an
                          InnoDB table, where all selected columns
                          belong to the same unique index key, returns
                          incorrect results
      a8067140
    • Gleb Shchepa's avatar
      merge 5.0-bugteam --> 5.1-bugteam · 46c7c724
      Gleb Shchepa authored
      46c7c724
    • Gleb Shchepa's avatar
      backport from 6.0 · b83b4697
      Gleb Shchepa authored
            
      Bug#35658 (An empty binary value leads to mysqld crash)
              
      Before this fix, the following token
        b''
      caused the parser to crash when reading the binary value from the empty string.
      The crash was caused by:
        ptr+= max_length - 1;
      because max_length is unsigned and was 0, causing an overflow.
              
      With this fix, an empty binary literal b'' is parsed as a binary value 0,
      in Item_bin_string.
      
      mysql-test/r/varbinary.result:
        Bug#35658 (An empty binary value leads to mysqld crash)
      mysql-test/t/varbinary.test:
        Bug#35658 (An empty binary value leads to mysqld crash)
      sql/item.cc:
        Bug#35658 (An empty binary value leads to mysqld crash)
      b83b4697
    • Gleb Shchepa's avatar
      backport to 5.1 from 6.0 · cb72f09c
      Gleb Shchepa authored
      Bug#35658 (An empty binary value leads to mysqld crash)
        
      Before this fix, the following token
        b''
      caused the parser to crash when reading the binary value from the empty string.
      The crash was caused by:
        ptr+= max_length - 1;
      because max_length is unsigned and was 0, causing an overflow.
        
      With this fix, an empty binary literal b'' is parsed as a binary value 0,
      in Item_bin_string.
      
      mysql-test/r/varbinary.result:
        Bug#35658 (An empty binary value leads to mysqld crash)
      mysql-test/t/varbinary.test:
        Bug#35658 (An empty binary value leads to mysqld crash)
      sql/item.cc:
        Bug#35658 (An empty binary value leads to mysqld crash)
      cb72f09c
  8. 25 Jun, 2008 4 commits
    • Matthias Leich's avatar
      Upmerge 5.0 -> 5.1 · e72132a5
      Matthias Leich authored
      e72132a5
    • Matthias Leich's avatar
      Fix for · 49417ad7
      Matthias Leich authored
      Bug#37492 timing bug in subselect.test
      + similar weaknesses found during testing
      + replace error numbers by error names
      49417ad7
    • Gleb Shchepa's avatar
      auto merge 5.1-main --> 5.1-bugteam · 696c03e4
      Gleb Shchepa authored
      696c03e4
    • Timothy Smith's avatar
      Bug #20748: Configuration files should not be read more than once · d5977e4c
      Timothy Smith authored
      Normalize directory names before adding them to default_directories.
      
      
      mysys/default.c:
        Normalize directory names with unpack_dirname() before adding them
        to default_directories.  This way, /etc/ and /etc will not count as
        duplicates.
        
        Because this entails allocating memory to store the normalized names,
        add error handling and ensure that it doesn't leak memory in case
        both my_print_defaults() and load_defaults() are called.
        
        Clean up the Windows code that finds the exe's parent directory, and
        pull it out into a separate function.
        
        Reorganize the code into a single init_default_directories() function,
        with internal #ifdefs, instead of init_default_directories_<system>()
        functions which were accessed via a function pointer.  This is more in
        line with normal MySQL coding style, and easier to read for some.
      d5977e4c
  9. 24 Jun, 2008 4 commits
  10. 21 Jun, 2008 1 commit
    • Tatiana A. Nurnberg's avatar
      auto merge · 32089863
      Tatiana A. Nurnberg authored
      configure.in:
        auto-merge
      mysql-test/suite/bugs/r/rpl_bug33029.result:
        auto-merge
      mysql-test/suite/bugs/t/rpl_bug33029.test:
        auto-merge
      sql/slave.cc:
        auto-merge
      sql/sql_class.cc:
        auto-merge
      sql/structs.h:
        auto-merge
      32089863
  11. 20 Jun, 2008 5 commits