1. 23 Jun, 2006 3 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · cbc5f34c
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      sql/sql_parse.cc:
        Auto merged
      cbc5f34c
    • unknown's avatar
      Merge moonbone.local:/work/tmp_merge-4.1-opt-mysql · 27cc0204
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      mysql-test/r/key.result:
        Auto merged
      mysql-test/t/key.test:
        Auto merged
      sql/table.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      27cc0204
    • unknown's avatar
      Bug#11228: DESC shows arbitrary column as "PRI" · 89e41595
      unknown authored
        An UNIQUE KEY consisting of NOT NULL columns
        was displayed as PRIMARY KEY in "DESC t1".
        According to the code, that was intentional
        behaviour for some reasons unknown to me.
        This code was written before bitkeeper time,
        so I cannot check who and why made this.
        After discussing on dev-public, a decision
        was made to remove this code
      
      
      mysql-test/r/key.result:
        Adding test case.
      mysql-test/t/key.test:
        Adding test case.
      sql/table.cc:
        Removing old wrong code
      89e41595
  2. 22 Jun, 2006 9 commits
    • unknown's avatar
      mysql.spec.sh: · 92ad3d5b
      unknown authored
        Disable the simplistic auto dependency scan for test/bench (bug#20078)
      
      
      support-files/mysql.spec.sh:
        Disable the simplistic auto dependency scan for test/bench (bug#20078)
      92ad3d5b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 0f0e518e
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime
      
      
      0f0e518e
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50 · 1c288073
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug18781
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      1c288073
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · dca36865
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15811
      
      
      dca36865
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-5.0-root · 8eb00d0a
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime
      
      
      8eb00d0a
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · a887fa9e
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15811
      
      
      a887fa9e
    • unknown's avatar
      A fix and a test case for Bug#15217 "Using a SP cursor on a table created · 67fd3c4a
      unknown authored
       with PREPARE fails with weird error".
      More generally, re-executing a stored procedure with a complex SP cursor query
      could lead to a crash.
      
      The cause of the problem was that SP cursor queries were not optimized 
      properly at first execution: their parse tree belongs to sp_instr_cpush,
      not sp_instr_copen, and thus the tree was tagged "EXECUTED" when the
      cursor was declared, not when it was opened. This led to loss of optimization
      transformations performed at first execution, as sp_instr_copen saw that the
      query is already "EXECUTED" and therefore either not ran first-execution 
      related blocks or wrongly rolled back the transformations caused by 
      first-execution code.
      The fix is to update the state of the parsed tree only when the tree is
      executed, as opposed to when the instruction containing the tree is executed.
      Assignment if i->state is moved to reset_lex_and_exec_core.
      
      
      mysql-test/r/sp.result:
        Test results fixed (Bug#15217)
      mysql-test/t/sp.test:
        Add a test case for Bug#15217
      sql/sp_head.cc:
        Move assignment of stmt_arena->state to reset_lex_and_exec_core
      67fd3c4a
    • unknown's avatar
      Bug#15811: extremely long time for mysql client to execute long INSERT · 15ac6406
      unknown authored
      The problem was in redundant calls to strlen() in string functions,
      where we may then return after checking only the small number of characters.
      
      No test case is provided since it's a performance fix.
      
      
      strings/ctype-mb.c:
        Do not use strlen() where arbitrary horizon of at least
        CHARSET_INFO::mbmaxlen character is sufficient.
      15ac6406
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 6e8cb4d6
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      6e8cb4d6
  3. 21 Jun, 2006 28 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 5cb66b11
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      5cb66b11
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 41b9884d
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      
      41b9884d
    • unknown's avatar
      Manual merge · 0041c317
      unknown authored
      
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      0041c317
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ab6059c8
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      ab6059c8
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · d5797063
      unknown authored
      into moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      
      d5797063
    • unknown's avatar
      Fixed bug #14896. · 822e8866
      unknown authored
      This bug in Field_string::cmp resulted in a wrong comparison 
      with keys in partial indexes over multi-byte character fields.
      Given field a is declared as a varchar(16) collate utf8_unicode_ci
      INDEX(a(4)) gives us an example of such an index.
        
      Wrong key comparisons could lead to wrong result sets if 
      the selected query execution plan used a range scan by 
      a partial index over a utf8 character field.
      This also caused wrong results in many other cases.
      
      
      mysql-test/t/ctype_utf8.test:
        Added test cases for bug #14896.
      mysql-test/r/ctype_utf8.result:
        Added test cases for bug #14896.
      sql/field.cc:
        Fixed bug #14896.
        This bug in Field_string::cmp resulted in a wrong comparison 
        with keys in partial indexes over multi-byte character fields.
        Given field a is declared as a varchar(16) collate utf8_unicode_ci
        INDEX(a(4)) gives us an example of such an index.
             
        Wrong key comparisons could lead to wrong result sets if 
        the selected query execution plan used a range scan by 
        a partial index over a utf8 character field.
        This also caused wrong results in many other cases.
      822e8866
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.0 · 37511b3b
      unknown authored
      into  mysql.com:/home/bk/fix-mysql-5.0
      
      
      37511b3b
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7b2a3d50
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      
      7b2a3d50
    • unknown's avatar
      Merge bk://localhost:5559 · f0ba641b
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      
      f0ba641b
    • unknown's avatar
      Cleanup to patch for Bug#18246, "compilation error with tcp_wrapper" · e8e52a6a
      unknown authored
      
      include/my_libwrap.h:
        Changed includes to the header file.
      mysys/my_libwrap.c:
        Added comment and .c file now takes needed includes from
        the corresponding .h file.
      sql/mysqld.cc:
        Include this block from my_libwra.h now.
        Moved two variables out of the otherwise
        same block.
      e8e52a6a
    • unknown's avatar
      Merge may.pils.ru:/home/svoj/devel/mysql/BUG20357/mysql-4.1 · 5b9d44fd
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20357/mysql-5.0
      
      
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/myisam.test:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      mysql-test/mysql-test-run.sh:
        Auto merged
      5b9d44fd
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-4.1 · 630a1ee4
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20357/mysql-4.1
      
      
      630a1ee4
    • unknown's avatar
      added missing MYSQLTEST_VARDIR declaration · fa83f8ba
      unknown authored
      fa83f8ba
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · f32cb2f3
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      
      f32cb2f3
    • unknown's avatar
      Merge april:devel/BitKeeper/mysql-4.1 · bf76f070
      unknown authored
      into  may.pils.ru:/home/svoj/devel/mysql/BUG20357/mysql-4.1
      
      
      sql/opt_sum.cc:
        Auto merged
      mysql-test/r/myisam.result:
        SCCS merged
      mysql-test/t/myisam.test:
        SCCS merged
      bf76f070
    • unknown's avatar
      BUG#20357 - Got error 124 from storage engine using MIN and MAX · 5c0cdea6
      unknown authored
                  functions in queries
      
      Using MAX()/MIN() on table with disabled indexes (by ALTER TABLE)
      results in error 124 (wrong index) from storage engine.
      
      The problem was that optimizer use disabled index to optimize
      MAX()/MIN(). Normally it must skip disabled index and perform
      table scan.
      
      This patch skips disabled indexes for min/max optimization.
      
      
      mysql-test/r/myisam.result:
        Test case for BUG#20357.
      mysql-test/t/myisam.test:
        Test case for BUG#20357.
      sql/opt_sum.cc:
        Skip disabled/ignored indexes for min/max optimization.
      5c0cdea6
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 5331ad52
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      
      5331ad52
    • unknown's avatar
      Merge knielsen@10.100.52.19:/usr/local/mysql/mysql-5.0 · a1ea1025
      unknown authored
      into  mysql.com:/data0/knielsen/mysql-5.0
      
      
      a1ea1025
    • unknown's avatar
      BUG#20578 · dce98ec4
      unknown authored
      Backport Valgrind suppression from mysql-5.1:
      
      D 1.4 05/11/23 22:44:54+02:00 monty@mysql.com 5 4 12/0/154
      P mysql-test/valgrind.supp
      C Remove warning that may happens becasue threads dies in different order
      
      
      mysql-test/valgrind.supp:
        Add suppression for Valgrind warning.
      dce98ec4
    • unknown's avatar
    • unknown's avatar
      Merge mysql.com:/home/kgeorge/mysql/5.0/teamclean · 6d399b0c
      unknown authored
      into  mysql.com:/home/kgeorge/mysql/5.0/B18080
      
      
      sql/sql_parse.cc:
        Auto merged
      6d399b0c
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · c0ff64f8
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      c0ff64f8
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 26f9132c
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.0-main
      
      
      26f9132c
    • unknown's avatar
      merge of the changes for bug #18080 · b92ad63f
      unknown authored
      
      mysql-test/t/insert_select.test:
        Auto merged
      mysql-test/r/insert_select.result:
        manual merge
      b92ad63f
    • unknown's avatar
      manual merge · ea3392fb
      unknown authored
      
      mysql-test/r/view_grant.result:
        merged
      mysql-test/t/view_grant.test:
        merged
      ea3392fb
    • unknown's avatar
      Merge mysql.com:/home/kgeorge/mysql/5.0/teamclean · 5a3d0287
      unknown authored
      into  mysql.com:/home/kgeorge/mysql/5.0/B20482
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      5a3d0287
    • unknown's avatar
      Bug #20482: failure on Create join view with sources views/tables in different · 6c787151
      unknown authored
                  schemas
      The function check_one_table_access() called to check access to tables in 
      SELECT/INSERT/UPDATE was doing additional checks/modifications that don't hold
      in the context of setup_tables_and_check_access().
      That's why the check_one_table() was split into two : the functionality needed by
      setup_tables_and_check_access() into check_single_table_access() and the rest of 
      the functionality stays in check_one_table_access() that is made to call the new
      check_single_table_access() function.
      
      
      mysql-test/r/view_grant.result:
        Bug #20482: failure on Create join view with sources views/tables in different 
                    schemas
        - test suite for the bug
      mysql-test/t/view_grant.test:
        Bug #20482: failure on Create join view with sources views/tables in different 
                    schemas
        - test suite for the bug
      sql/mysql_priv.h:
        Bug #20482: failure on Create join view with sources views/tables in different 
                    schemas
        - check_one_table_access split into 2
      sql/sql_base.cc:
        Bug #20482: failure on Create join view with sources views/tables in different 
                    schemas
        - the new sub-function called
      sql/sql_parse.cc:
        Bug #20482: failure on Create join view with sources views/tables in different 
                    schemas
        - check_one_table_access() split into two : check_single_table_access() to 
          actually check access to the table(ro) and check_one_table_access() that calls
          check_single_table_access() and checks also the tables belonging to sub selects
          or implicitly opened tables.
      6c787151
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-5.0-backed · 2b43555b
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      2b43555b