1. 23 Mar, 2007 4 commits
  2. 22 Mar, 2007 6 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 55f991c2
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      
      55f991c2
    • unknown's avatar
      .del-fill_func_tables.sh: · 4b4700f3
      unknown authored
        Delete: scripts/fill_func_tables.sh
      .del-fill_help_tables.sh:
        Delete: scripts/fill_help_tables.sh
      .del-internals.texi:
        Delete: Docs/internals.texi
      
      
      BitKeeper/deleted/.del-internals.texi:
        Delete: Docs/internals.texi
      BitKeeper/deleted/.del-fill_func_tables.sh:
        Delete: scripts/fill_func_tables.sh
      BitKeeper/deleted/.del-fill_help_tables.sh:
        Delete: scripts/fill_help_tables.sh
      4b4700f3
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/tmp/mysql-4.0 · d3125d0a
      unknown authored
      into  mysql.com:/home/kent/bk/tmp/mysql-4.1-build
      
      
      BitKeeper/deleted/.del-net_doc.txt:
        Auto merged
      d3125d0a
    • unknown's avatar
      Deleted directories · 84536ba9
      unknown authored
        Docs/Books/
        Docs/MySQL-logos/
      Deleted files
        Docs/Tutorial-MySQL-final.txt
        Docs/bk.txt
        Docs/Support/.cvsignore
        Docs/Support/colspec-fix.pl
        Docs/Support/docbook-fixup.pl
        Docs/Support/docbook-prefix.pl
        Docs/Support/docbook-split
        Docs/Support/make-docbook
        Docs/Support/make-makefile
        Docs/Support/test-make-manual
        Docs/Support/test-make-manual-de
        Docs/Support/trivial-makeinfo-4.0c.patch
        Docs/Support/xwf
      Deleted file now in internals main text
        Docs/my_sys.txt
      Deleted file now in internals svn tree
        Docs/net_doc.txt
      Removed obsolete entries
        Docs/.cvsignore
      Added note that info is obsolete
        Docs/linuxthreads.txt
      
      
      BitKeeper/deleted/.del-colspec-fix.pl:
        Delete: Docs/Support/colspec-fix.pl
      BitKeeper/deleted/.del-docbook-fixup.pl:
        Delete: Docs/Support/docbook-fixup.pl
      BitKeeper/deleted/.del-docbook-prefix.pl:
        Delete: Docs/Support/docbook-prefix.pl
      BitKeeper/deleted/.del-docbook-split:
        Delete: Docs/Support/docbook-split
      BitKeeper/deleted/.del-make-docbook:
        Delete: Docs/Support/make-docbook
      BitKeeper/deleted/.del-make-makefile:
        Delete: Docs/Support/make-makefile
      BitKeeper/deleted/.del-test-make-manual-de:
        Delete: Docs/Support/test-make-manual-de
      BitKeeper/deleted/.del-test-make-manual:
        Delete: Docs/Support/test-make-manual
      BitKeeper/deleted/.del-trivial-makeinfo-4.0c.patch:
        Delete: Docs/Support/trivial-makeinfo-4.0c.patch
      BitKeeper/deleted/.del-xwf:
        Delete: Docs/Support/xwf
      BitKeeper/deleted/.del-algor.eps~1a57aff065918206:
        Delete: Docs/Books/algor.eps
      BitKeeper/deleted/.del-algor.gif:
        Delete: Docs/Books/algor.gif
      BitKeeper/deleted/.del-algor.txt:
        Delete: Docs/Books/algor.txt
      BitKeeper/deleted/.del-dbi.eps~7b1032f98de7736d:
        Delete: Docs/Books/dbi.eps
      BitKeeper/deleted/.del-dbi.gif:
        Delete: Docs/Books/dbi.gif
      BitKeeper/deleted/.del-dbi.txt:
        Delete: Docs/Books/dbi.txt
      BitKeeper/deleted/.del-dubois.eps~f24e09a7fa420436:
        Delete: Docs/Books/dubois.eps
      BitKeeper/deleted/.del-dubois.gif:
        Delete: Docs/Books/dubois.gif
      BitKeeper/deleted/.del-dubois.txt:
        Delete: Docs/Books/dubois.txt
      BitKeeper/deleted/.del-ecomm.eps~17833026ebd7656:
        Delete: Docs/Books/ecomm.eps
      BitKeeper/deleted/.del-ecomm.gif:
        Delete: Docs/Books/ecomm.gif
      BitKeeper/deleted/.del-ecomm.txt:
        Delete: Docs/Books/ecomm.txt
      BitKeeper/deleted/.del-in_21.eps~8150d06653dab178:
        Delete: Docs/Books/in_21.eps
      BitKeeper/deleted/.del-in_21.gif:
        Delete: Docs/Books/in_21.gif
      BitKeeper/deleted/.del-in_21.txt:
        Delete: Docs/Books/in_21.txt
      BitKeeper/deleted/.del-manual.eps~1c2ebcea50b4840c:
        Delete: Docs/Books/manual.eps
      BitKeeper/deleted/.del-manual.gif:
        Delete: Docs/Books/manual.gif
      BitKeeper/deleted/.del-manual.txt:
        Delete: Docs/Books/manual.txt
      BitKeeper/deleted/.del-msql.eps~f3801b9d166ae4fc:
        Delete: Docs/Books/msql.eps
      BitKeeper/deleted/.del-msql.gif:
        Delete: Docs/Books/msql.gif
      BitKeeper/deleted/.del-msql.txt:
        Delete: Docs/Books/msql.txt
      BitKeeper/deleted/.del-prof.eps~1f54d9a56eb2b908:
        Delete: Docs/Books/prof.eps
      BitKeeper/deleted/.del-prof.gif:
        Delete: Docs/Books/prof.gif
      BitKeeper/deleted/.del-prof.txt:
        Delete: Docs/Books/prof.txt
      BitKeeper/deleted/.del-pthreads.eps~2ca8ff2d1181b2c0:
        Delete: Docs/Books/pthreads.eps
      BitKeeper/deleted/.del-pthreads.gif:
        Delete: Docs/Books/pthreads.gif
      BitKeeper/deleted/.del-pthreads.txt:
        Delete: Docs/Books/pthreads.txt
      BitKeeper/deleted/.del-realmen.eps~cc022325d3cb045:
        Delete: Docs/Books/realmen.eps
      BitKeeper/deleted/.del-realmen.gif:
        Delete: Docs/Books/realmen.gif
      BitKeeper/deleted/.del-realmen.txt:
        Delete: Docs/Books/realmen.txt
      BitKeeper/deleted/.del-sql-99.eps~f85c06de7a016c7d:
        Delete: Docs/Books/sql-99.eps
      BitKeeper/deleted/.del-sql-99.gif:
        Delete: Docs/Books/sql-99.gif
      BitKeeper/deleted/.del-sql-99.txt:
        Delete: Docs/Books/sql-99.txt
      BitKeeper/deleted/.del-mysql-01.gif:
        Delete: Docs/MySQL-logos/mysql-01.gif
      BitKeeper/deleted/.del-mysql-02.gif:
        Delete: Docs/MySQL-logos/mysql-02.gif
      BitKeeper/deleted/.del-mysql-03.gif:
        Delete: Docs/MySQL-logos/mysql-03.gif
      BitKeeper/deleted/.del-mysql-04.gif:
        Delete: Docs/MySQL-logos/mysql-04.gif
      BitKeeper/deleted/.del-mysql-05.gif:
        Delete: Docs/MySQL-logos/mysql-05.gif
      BitKeeper/deleted/.del-mysql-06.gif:
        Delete: Docs/MySQL-logos/mysql-06.gif
      BitKeeper/deleted/.del-mysql-07.gif:
        Delete: Docs/MySQL-logos/mysql-07.gif
      BitKeeper/deleted/.del-mysql-08.gif:
        Delete: Docs/MySQL-logos/mysql-08.gif
      BitKeeper/deleted/.del-mysql-09.gif:
        Delete: Docs/MySQL-logos/mysql-09.gif
      BitKeeper/deleted/.del-mysql-10.gif:
        Delete: Docs/MySQL-logos/mysql-10.gif
      BitKeeper/deleted/.del-mysql-11.gif:
        Delete: Docs/MySQL-logos/mysql-11.gif
      BitKeeper/deleted/.del-mysql-12.gif:
        Delete: Docs/MySQL-logos/mysql-12.gif
      BitKeeper/deleted/.del-mysql-13.gif:
        Delete: Docs/MySQL-logos/mysql-13.gif
      BitKeeper/deleted/.del-mysql-14.gif:
        Delete: Docs/MySQL-logos/mysql-14.gif
      BitKeeper/deleted/.del-mysql-15.gif:
        Delete: Docs/MySQL-logos/mysql-15.gif
      BitKeeper/deleted/.del-mysql-16.gif:
        Delete: Docs/MySQL-logos/mysql-16.gif
      BitKeeper/deleted/.del-mysql-17.gif:
        Delete: Docs/MySQL-logos/mysql-17.gif
      BitKeeper/deleted/.del-mysql-compatible.jpg:
        Delete: Docs/MySQL-logos/mysql-compatible.jpg
      BitKeeper/deleted/.del-mysql_anim-01.gif:
        Delete: Docs/MySQL-logos/mysql_anim-01.gif
      BitKeeper/deleted/.del-mysql_anim-02.gif:
        Delete: Docs/MySQL-logos/mysql_anim-02.gif
      BitKeeper/deleted/.del-mysql_anim-03.gif:
        Delete: Docs/MySQL-logos/mysql_anim-03.gif
      BitKeeper/deleted/.del-mysql_anim-04.gif:
        Delete: Docs/MySQL-logos/mysql_anim-04.gif
      BitKeeper/deleted/.del-mysql_anim-05.gif:
        Delete: Docs/MySQL-logos/mysql_anim-05.gif
      BitKeeper/deleted/.del-mysql_anim-06.gif:
        Delete: Docs/MySQL-logos/mysql_anim-06.gif
      BitKeeper/deleted/.del-Tutorial-MySQL-final.txt:
        Delete: Docs/Tutorial-MySQL-final.txt
      BitKeeper/deleted/.del-net_doc.txt:
        Delete: Docs/net_doc.txt
      BitKeeper/deleted/.del-my_sys.txt:
        Delete: Docs/my_sys.txt
      BitKeeper/deleted/.del-bk.txt:
        Delete: Docs/bk.txt
      BitKeeper/deleted/.del-.cvsignore:
        Delete: Docs/Support/.cvsignore
      Docs/.cvsignore:
        Removed obsolete entries
      Docs/linuxthreads.txt:
        Added note info is obsolete
      84536ba9
    • unknown's avatar
      bug #16546 (DATETIME + 0 not always coerced in the same way) · 50b5064c
      unknown authored
        fix for cast( AS DATETIME) + 0 operation.
        I just implemented Item_datetime_typecast::val() method
        as it is usually done in other classes.
        Should be fixed more radically in 5.0
      
      
      mysql-test/r/type_datetime.result:
        result added
      mysql-test/t/type_datetime.test:
        testcase
      sql/item_timefunc.h:
        added double conversion to Item_datetime_typecast
      50b5064c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/25492/my41-25492 · 6ef0fee8
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      
      6ef0fee8
  3. 20 Mar, 2007 1 commit
    • unknown's avatar
      Bug #27231: Server crash when dumping into outfile with long FIELDS ENCLOSED BY option · d59272fb
      unknown authored
      - Problem: data separators were copied to a fixed-size buffer
        on the stack; memcpy was used, without bounds checking; a
        server crash could result if long FIELDS ENCLOSED BY, etc.,
        was given
      - Fix: write the separators directly, instead of copying to
        a buffer first (in select_export::send_data())
      
      
      sql/sql_class.cc:
        In select_export::send_data(), write data separators
        directly, instead of copying into a fixed-size memory
        buffer before writing.  This avoids a buffer overflow
        when very large separators are specified.
      d59272fb
  4. 15 Mar, 2007 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 39333ba7
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-4.1-merge
      
      
      39333ba7
    • unknown's avatar
      Fix for bug #25966 "2MB per second endless memory consumption after LOCK · db1d2f64
      unknown authored
      TABLE ... WRITE".
      
      CPU hogging occured when connection which had to wait for table lock was
      serviced by thread which previously serviced connection that was killed
      (note that connections can reuse threads if thread cache is enabled).
      One possible scenario which exposed this problem was when thread which
      provided binlog dump to replication slave was implicitly/automatically
      killed when the same slave reconnected and started pulling data through
      different thread/connection.
      In 5.* versions memory hogging was added to CPU hogging. Moreover in
      those versions the problem also occured when one killed particular query
      in connection (using KILL QUERY) and later this connection had to wait for
      some table lock.
      
      This problem was caused by the fact that thread-specific mysys_var::abort
      variable, which indicates that waiting operations on mysys layer should
      be aborted (this includes waiting for table locks), was set by kill
      operation but was never reset back. So this value was "inherited" by the
      following statements or even other connections (which reused the same
      physical thread). Such discrepancy between this variable and THD::killed
      flag broke logic on SQL-layer and caused CPU and memory hogging.
      
      This patch tries to fix this problem by properly resetting this member.
      
      There is no test-case associated with this patch since it is hard to test
      for memory/CPU hogging conditions in our test-suite.
      
      
      sql/mysqld.cc:
        We should not forget to reset THD::mysys_var::abort after kill operation
        if we are going to use thread to which this operation was applied for
        handling of other connections.
      db1d2f64
  5. 14 Mar, 2007 5 commits
  6. 13 Mar, 2007 2 commits
    • unknown's avatar
      BUG#26881 - Large MERGE tables report incorrect specification when no · 969b7165
      unknown authored
                  differences in tables
      Certain merge tables were wrongly reported as having incorrect definition:
      - Some fields that are 1 byte long (e.g. TINYINT, CHAR(1)), might
        be internally casted (in certain cases) to a different type on a
        storage engine layer. (affects 4.1 and up)
      - If tables in a merge (and a MERGE table itself) had short VARCHAR column (less
        than 4 bytes) and at least one (but not all) tables were ALTER'ed (even to an
        identical table: ALTER TABLE xxx ENGINE=yyy), table definitions went ouf of
        sync. (affects 4.1 only)
      
      This is fixed by relaxing a check for underlying conformance and setting
      field type to FIELD_TYPE_STRING in case varchar is shorter than 4
      when a table is created.
      
      
      myisam/mi_create.c:
        Added a comment.
      mysql-test/r/merge.result:
        A test case for bug#26881.
      mysql-test/t/merge.test:
        A test case for bug#26881.
      sql/ha_myisam.cc:
        Relaxed some checks performed by check_definition():
        As comparing of fulltext keys (and key segments) is not yet implemented,
        only return an error in case one of keys is fulltext and other is not.
        Otherwise, if both keys are fulltext, accept them as is.
        
        As comparing of spatial keys (and key segments) is not yet implemented,
        only return an error in case one of keys is spatial and other is not.
        Otherwise, if both keys are spatial, accept them as is.
        
        A workaround to handle situation when field is casted from FIELD_SKIP_ZERO
        to FIELD_NORMAL. This could happen only in case field length is 1 and row
        format is fixed.
      sql/sql_parse.cc:
        When a table that has varchar field shorter than 4 is created, field type is
        set to FIELD_TYPE_VAR_STRING. Later, when a table is modified using alter
        table, field type is changed to FIELD_TYPE_STRING (see Field_string::type).
        That means HA_OPTION_PACK_RECORD flag might be lost and thus null_bit might
        be shifted by alter table, in other words alter table doesn't create 100%
        equal table definition.
        
        This is usually not a problem, since when a table is created/altered,
        definition on a storage engine layer is based on one that is passed from
        sql layer. But it is a problem for merge engine - null_bit is shifted when
        a table (merge or underlying) is altered.
        
        Set field type to FIELD_TYPE_STRING in case FIELD_TYPE_VAR_STRING is shorter
        than 4 when a table is created as it is done in Field::type.
      969b7165
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-4.1 · e266365c
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG26881/mysql-4.1-engines
      
      
      e266365c
  7. 12 Mar, 2007 4 commits
    • unknown's avatar
      configure.in: · 6f835334
      unknown authored
        Restored accidently removed line to check for zlib
      
      
      configure.in:
        Restored accidently removed line to check for zlib
      6f835334
    • unknown's avatar
      mysys_ia64.dsp, mysys.vcproj: · d429f590
      unknown authored
        Removed references to unused files
      
      
      VC++Files/mysys/mysys.vcproj:
        Removed unused files
      VC++Files/mysys/mysys_ia64.dsp:
        Removed unused files
      d429f590
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/tmp/mysql-4.0 · d4d8d132
      unknown authored
      into  mysql.com:/home/kent/bk/tmp/mysql-4.1-build
      
      
      include/Makefile.am:
        Auto merged
      d4d8d132
    • unknown's avatar
      Makefile.am, configure.in, mysys.dsp: · 32b370bb
      unknown authored
        Removed unused files
      .del-my_winsem.c:
        Delete: mysys/my_winsem.c
      .del-my_semaphore.c:
        Delete: mysys/my_semaphore.c
      .del-my_semaphore.h:
        Delete: include/my_semaphore.h
      
      
      BitKeeper/deleted/.del-my_semaphore.c:
        Delete: mysys/my_semaphore.c
      BitKeeper/deleted/.del-my_semaphore.h:
        Delete: include/my_semaphore.h
      BitKeeper/deleted/.del-my_winsem.c:
        Delete: mysys/my_winsem.c
      VC++Files/mysys/mysys.dsp:
        Removed unused files
      configure.in:
        Removed unused files
      include/Makefile.am:
        Removed unused files
      mysys/Makefile.am:
        Removed unused files
      32b370bb
  8. 10 Mar, 2007 1 commit
  9. 09 Mar, 2007 1 commit
  10. 08 Mar, 2007 5 commits
    • unknown's avatar
      Bug#25673 - spatial index corruption, error 126 incorrect key file for table · 35d58191
      unknown authored
      After backport fix.
      Added forgotten DBUG_RETURNs, which was detected in 5.1 only.
      
      
      35d58191
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 0fcd9c2b
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      
      0fcd9c2b
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1-maint · 5130e88e
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-4.1-maint
      
      
      5130e88e
    • unknown's avatar
      Bug#25673 - spatial index corruption, error 126 · 548a39a1
      unknown authored
                incorrect key file for table
      
      In certain cases it could happen that deleting a row could
      corrupt an RTREE index.
      
      According to Guttman's algorithm, page underflow is handled
      by storing the page in a list for later re-insertion. The
      keys from the stored pages have to be inserted into the
      remaining pages of the same level of the tree. Hence the
      level number is stored in the re-insertion list together
      with the page.
      
      In the MySQL RTree implementation the level counts from zero
      at the root page, increasing numbers for levels down the tree.
      
      If during re-insertion of the keys the tree height grows, all
      level numbers become invalid. The remaining keys will be
      inserted at the wrong level.
      
      The fix is to increment the level numbers stored in the
      reinsert list after a split of the root block during reinsertion.
      
      
      myisam/rt_index.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added a loop in rtree_delete() to increment the level numbers
        stored in the reinsert list after a split of the root block
        during reinsertion.
        Added comments and DBUG statements.
      myisam/rt_key.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added DBUG statements.
      myisam/rt_split.c:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added DBUG statements.
      mysql-test/r/gis-rtree.result:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added the test result.
      mysql-test/t/gis-rtree.test:
        Bug#25673 - spatial index corruption, error 126
                    incorrect key file for table
        Added a test.
      548a39a1
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mar07/stage2/40 · f2044997
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mar07/stage2/41
      
      
      f2044997
  11. 07 Mar, 2007 5 commits
  12. 05 Mar, 2007 4 commits
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 49110f3e
      unknown authored
      into  mysql.com:/home/ram/work/b26038/b26038.4.1
      
      
      49110f3e
    • unknown's avatar
      Bug#26464 - insert delayed + update + merge = corruption · da9c659c
      unknown authored
      Using INSERT DELAYED on MERGE tables could lead to table
      corruptions.
      
      The manual lists a couple of storage engines, which can be
      used with INSERT DELAYED. MERGE is not in this list.
      
      The attempt to try it anyway has not been rejected yet.
      This bug was not detected earlier as it can work under
      special circumstances. Most notable is low concurrency.
      
      To be safe, this patch rejects any attempt to use INSERT
      DELAYED on MERGE tables.
      
      
      mysql-test/r/merge.result:
        Bug#26464 - insert delayed + update + merge = corruption
        Added test result.
      mysql-test/t/merge.test:
        Bug#26464 - insert delayed + update + merge = corruption
        Added test.
      sql/ha_myisammrg.h:
        Bug#26464 - insert delayed + update + merge = corruption
        Removed HA_CAN_INSERT_DELAYED flag from table_flags().
        The insert delayed thread upgrades the lock from the first
        entry in MYSQL_LOCK::locks only. Hence it is incapable to
        handle MERGE tables, which have as many entries in this
        array as they have MyISAM sub-tables.
      da9c659c
    • unknown's avatar
      Bug #26792 Add DBX debugger support to mysql-test-run.pl · c5e5b5e1
      unknown authored
       - Add --debugger=dbx
       - Fix --debugger=devenv, --debugger=DevEnv and --debugger=/path/devenv
      
      
      mysql-test/mysql-test-run.pl:
        Add support for --debugger=dbx to mysql-test-run.pl
        Fix case senitive match for vc, vcexpress or deven
        Make it possible to use full path to debugger for
        --debugger=/path/vcexpress
      c5e5b5e1
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 6db49789
      unknown authored
      into  mysql.com:/home/ram/work/b23616/b23616.4.1
      
      
      6db49789