1. 15 Sep, 2005 13 commits
  2. 14 Sep, 2005 27 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · dceb8fb2
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg12704-2
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      dceb8fb2
    • unknown's avatar
      Fix for bug #12704 "Server crashes during trigger execution". · d5303b8a
      unknown authored
      This bug occurs when some trigger for table used by DML statement is created
      or changed while statement was waiting in lock_tables(). In this situation
      prelocking set which we have calculated becames invalid which can easily lead
      to errors and even in some cases to crashes.
      
      With proposed patch we no longer silently reopen tables in lock_tables(),
      instead caller of lock_tables() becomes responsible for reopening tables and
      recalculation of prelocking set.
      
      
      mysql-test/t/trigger.test:
        Added tests for bug #12704 "Server crashes during trigger execution".
        Unfortunately these tests rely on the order in which tables are locked
        by statement so they are non-determenistic and therefore should be disabled.
      sql/lock.cc:
        mysql_lock_tables():
          Now instead of always reopening altered or dropped tables by itself
          mysql_lock_tables() can notify upper level and rely on caller doing this.
      sql/mysql_priv.h:
        Now mysql_lock_tables() can either reopen deleted or altered tables by itself
        or notify caller about such situation through 'need_reopen' argument and rely
        on it in this.
        Also lock_tables() has new 'need_reopen' out parameter through which it
        notifies caller that some tables were altered or dropped so he needs to reopen
        them (and rebuild prelocking set some triggers may change or simply appear).
      sql/sp.cc:
        sp_add_used_routine():
          To be able to restore LEX::sroutines_list to its state right after parsing
          we now adjust  LEX::sroutines_list_own_last/sroutines_list_own_elements when
          we add directly used routine.
        sp_remove_not_own_routines():
          Added procedure for restoring LEX::sroutines/sroutines_list to their state
          right after parsing (by throwing out non-directly used routines).
        sp_cache_routines_and_add_tables_for_view()/sp_update_stmt_used_routines():
          We should use LEX::sroutines_list instead of LEX::sroutines as source of
          routines used by view, since LEX::sroutines is not availiable for view
          on second attempt to open it (see comment in open_tables() about it).
      sql/sp.h:
        sp_remove_not_own_routines():
          Added procedure for restoring LEX::sroutines/sroutines_list to their state
          right after parsing (by throwing out non-directly used routines).
      sql/sp_head.cc:
        Removed assert which is no longer always true.
      sql/sql_base.cc:
        reopen_table():
          When we re-open table and do shallow copy of TABLE object we should adjust
          pointers to it in associated Table_triggers_list object. Removed nil
          operation.
        open_tables():
          Now this function is able to rebuild prelocking set for statement if it is
          needed. It also correctly handles FLUSH TABLES which may occur during its
          execution.
        lock_tables():
          Instead of allowing mysql_lock_tables() to silently reopen altered or dropped
          tables let us notify caller and rely on that it will do reopen itself.
          This solves the problem when trigger suddenly appears or changed during
          mysq_lock_tables().
        close_tables_for_reopen():
          Added routine for properly preparing for reopening of tables and recalculation
          of set of prelocked tables.
      sql/sql_handler.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_insert.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_lex.cc:
        LEX:
          Added 'sroutines_list_own_last' and 'sroutines_list_own_elements' members
          which are used for keeping state in which 'sroutines_list' was right after
          statement parsing (and for restoring of this list to this state).
      sql/sql_lex.h:
        LEX:
          Added 'sroutines_list_own_last' and 'sroutines_list_own_elements' members
          which are used for keeping state in which 'sroutines_list' was right after
          statement parsing (and for restoring of this list to this state).
          Added chop_off_not_own_tables() method to simplify throwing away list
          of implicitly used (prelocked) tables.
      sql/sql_prepare.cc:
        Now instead of silently reopening altered or dropped tables in
        lock_tables() we notify caller and rely on that the caller will
        reopen tables.
      sql/sql_table.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_trigger.cc:
        Added Table_triggers_list::set_table() method to adjust Table_triggers_list
        to new pointer to TABLE instance.
      sql/sql_trigger.h:
        Added Table_triggers_list::set_table() method to adjust Table_triggers_list
        to new pointer to TABLE instance.
      sql/sql_update.cc:
        Now instead of silently reopening altered or dropped tables in
        lock_tables() we notify caller and rely on that the caller will
        reopen tables.
      d5303b8a
    • unknown's avatar
      Merge eherman@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4e17e059
      unknown authored
      into  mysql.com:/home/eric/mysql-5.0-fed-err
      
      
      4e17e059
    • unknown's avatar
      Merge eherman@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8ac6ab4a
      unknown authored
      into  mysql.com:/home/eric/mysql-5.0-fed-err
      
      
      8ac6ab4a
    • unknown's avatar
      Updated test results for view test. · 11e0bdd7
      unknown authored
      
      mysql-test/r/view.result:
        Updated test results
      11e0bdd7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 92e4aa67
      unknown authored
      into  mysql.com:/home/emurphy/src/bk-clean/mysql-5.0
      
      
      92e4aa67
    • unknown's avatar
      fixed portability · 78cf7b19
      unknown authored
      78cf7b19
    • unknown's avatar
      Fix bug #11416 Server crash if using a view that uses function convert_tz · de4fbc21
      unknown authored
      When parser parses function convert_tz it loads available timezone tables in
      thd->lex->time_zone_tables_used. But view have another lex that main query.
      Thus time_zone_tables_used of main query left uninitialized.
      When Item_func_conver_tz is fixed it takes timezone tables from main query
      and later when it executed it assumes that timezone tables are loaded and
      failed that assertion.
      
      
      
      sql/sql_view.cc:
        Fix bug #11416 Server crash if using a view that uses function convert_tz
      mysql-test/r/view.result:
        Test case for bug#11416 Server crash if using a view that uses function convert_tz
      mysql-test/t/view.test:
        Test case for bug#11416 Server crash if using a view that uses function convert_tz
      de4fbc21
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 232d1ff4
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      
      232d1ff4
    • unknown's avatar
      Merge mysql.com:/home/emurphy/src/work/mysql-5.0-bug-12870 · 949cc285
      unknown authored
      into  mysql.com:/home/emurphy/src/bk-clean/mysql-5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      949cc285
    • unknown's avatar
      BUG#12870 (CREATE PROCEDURE followed by ROLLBACK is not replicated) · bdae7b9b
      unknown authored
      Fixed by making CREATE/ALTER/DROP PROCEDURE cause implicit commit.
      
      
      mysql-test/r/rpl_ddl.result:
        Updated results to include testing of implicit commit for
        create/alter/drop procedure
      mysql-test/t/rpl_ddl.test:
        BUG#12870 test implicit commit for create/alter/drop procedure.
      sql/sql_parse.cc:
        CREATE/ALTER/DROP PROCEDURE/SPFUNCTION now causes implicit commit.
      bdae7b9b
    • unknown's avatar
      Per LenZ, changed calculated buffer size to constant and removed some unused variables. · 7dc083d5
      unknown authored
      
      sql/ha_federated.cc:
        converted calculated buffer size to static interger.
        removed unused variables.
      7dc083d5
    • unknown's avatar
      Merge mysql.com:/home/alexi/mysql-5.0 · 97bea909
      unknown authored
      into  mysql.com:/home/alexi/dev/mysql-5.0-13000
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      97bea909
    • unknown's avatar
      Fixed BUG#12963, BUG#13000: wrong VIEW creation with DAYNAME(), · b214671e
      unknown authored
       DAYOFWEEK(), and WEEKDAY().
      
      
      mysql-test/r/func_time.result:
        Fixed new results for testcases containing EXPLAIN EXTENDED SELECT ...
         WEEKDAY ... DAYNAME. The new results are correct and correspond to
         the changes in create_func_weekday() and create_func_dayname().
      mysql-test/r/view.result:
        Fixed some testcases results (bugs #12963, #13000).
      mysql-test/t/view.test:
        Added testcases for for bugs #12963, #13000.
      sql/item_create.cc:
        Fixed bugs #12963, #13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY().
         Modified create_func_dayname(), create_func_dayofweek(), and
         create_func_weekday(). They don´t insert Item_func_to_days
         object now.
      sql/item_timefunc.cc:
        Fixed bugs #12963, #13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY().
         Modified Item_func_weekday::val_int(). The argument of weekday should
         not be considered now to be Item_func_to_days object.
      sql/item_timefunc.h:
        Fixed bugs #12963, 13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY.
         Modified Item_func_weekday::func_name(). It returns now different
         names depending on the odbc_type attribute value.
      b214671e
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · dd8d6395
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      
      sql/sql_show.cc:
        Auto merged
      dd8d6395
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 528c3a71
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      
      528c3a71
    • unknown's avatar
      Merge abelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 21b8177e
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-owner2-5.0
      
      
      21b8177e
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ead2b334
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      
      ead2b334
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 06fc0e8b
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/bug13136
      
      
      06fc0e8b
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 6a47ca25
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-4100
      
      
      6a47ca25
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 18196ce1
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      
      18196ce1
    • unknown's avatar
      Merge abelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · e33c22a1
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-owner2-5.0
      
      
      e33c22a1
    • unknown's avatar
      postmerge fix · eae520f3
      unknown authored
      eae520f3
    • unknown's avatar
      BUG#13136 NdbTCP.cpp compile failure on OSX 10.2 · c6ff73b9
      unknown authored
      use select if poll is unavailable.
      
      
      ndb/src/common/portlib/NdbTCP.cpp:
        Implement Ndb_check_socket_hup for systems without poll(2)
      ndb/src/common/portlib/win32/NdbTCP.c:
        fix typo (found while fixing this bug)
      c6ff73b9
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 70f16456
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      
      70f16456
    • unknown's avatar
      enabled mysqldump hex-blob option for bit fields · 840ab3dd
      unknown authored
      840ab3dd
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · d51c50b8
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      
      d51c50b8