- 29 Nov, 2007 1 commit
-
-
davi@mysql.com/endora.local authored
This bug is actually two bugs in one, one of which is CREATE TRIGGER under LOCK TABLES and the other is CREATE TRIGGER under LOCK TABLES simultaneous to a FLUSH TABLES WITH READ LOCK (global read lock). Both situations could lead to a server crash or deadlock. The first problem arises from the fact that when under LOCK TABLES, if the table is in the set of locked tables, the table is already open and it doesn't need to be reopened (not a placeholder). Also in this case, if the table is not write locked, a exclusive lock can't be acquired because of a possible deadlock with another thread also holding a (read) lock on the table. The second issue arises from the fact that one should never wait for a global read lock if it's holding any locked tables, because the global read lock is waiting for these tables and this leads to a circular wait deadlock. The solution for the first case is to check if the table is write locked and upgraded the write lock to a exclusive lock and fail otherwise for non write locked tables. Grabbin the exclusive lock in this case also means to ensure that the table is opened only by the calling thread. The second issue is partly fixed by not waiting for the global read lock if the thread is holding any locked tables. The second issue is only partly addressed in this patch because it turned out to be much wider and also affects other DDL statements. Reported as Bug#32395
-
- 28 Nov, 2007 13 commits
-
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
-
malff@lambda.hsd1.co.comcast.net. authored
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
-
davi@endora.local authored
into mysql.com:/Users/davi/mysql/mysql-5.1-runtime
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
-
davi@endora.local authored
into mysql.com:/Users/davi/mysql/mysql-5.0-runtime
-
davi@mysql.com/endora.local authored
Kill of a CREATE TABLE source_table LIKE statement waiting for a name-lock on the source table causes a bad lock interaction. The mysql_create_like_table() has a bug that if the connection is killed while waiting for the name-lock on the source table, it will jump to the wrong error path and try to unlock the source table and LOCK_open, but both weren't locked. The solution is to simple return when the name lock request is killed, it's safe to do so because no lock was acquired and no cleanup is needed. Original bug report also contains description of other problems related to this scenario but they either already fixed in 5.1 or will be addressed separately (see bug report for details).
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.1-axmrg
-
istruewing@stella.local authored
Moved disabling to rpl suite. Bug#32801 wait_timeout.test fails randomly Disabled test case.
-
istruewing@stella.local authored
Disabled test case.
-
thek@adventure.(none) authored
into adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
-
thek@adventure.(none) authored
-
- 27 Nov, 2007 16 commits
-
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.1-axmrg
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.1-axmrg
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.0-axmrg
-
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.0-axmrg
-
istruewing@stella.local authored
Disabled the test case.
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b30495/b30495.5.0
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b30495/b30495.5.1
-
malff@lambda.hsd1.co.comcast.net. authored
into lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.0-axmrg
-
into mysql.com:/home/ram/work/b30495/b30495.5.0
-
mkindahl@dl145h.mysql.com authored
-
- archive test/result adjusted. - OPTIMIZE/ANALYZE PARTITION EXTENDED test case added.
-
istruewing@stella.local authored
Some test cases were missing preparation to deal with failed predecessor test cases. Added preparation (drop table if exists) to some test cases.
-
ramil/ram@ramil.myoffice.izhnet.ru authored
into mysql.com:/home/ram/work/b30495/b30495.5.1
-
- 26 Nov, 2007 10 commits
-
-
msvensson@pilot.mysql.com authored
into pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-runtime
-
msvensson@pilot.mysql.com authored
-
msvensson@pilot.mysql.com authored
- Additional patch to fix compiler warnings
-
msvensson@pilot.mysql.com authored
-
thek@adventure.(none) authored
into adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
-
thek@adventure.(none) authored
into adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
-
istruewing@stella.local authored
into stella.local:/home2/mydev/mysql-5.1-axmrg
-
istruewing@stella.local authored
Bug#20627 - INSERT DELAYED does not honour auto_increment_* variables Fixed wrong variable assignment.
-
davi@endora.local authored
into mysql.com:/Users/davi/mysql/bugs/29592-5.1
-
thek@adventure.(none) authored
Loading 4.1 into 5.0 or 5.1 failed silently because procs_priv table missing. This caused the server to crash on any attempt to store new grants because of uninitialized structures. This patch breaks up the grant loading function into two phases to allow for procs_priv table to fail with an warning instead of crashing the server.
-