1. 30 Jul, 2010 1 commit
    • Michael Widenius's avatar
      Fix for LP#602604: RQG: ma_blockrec.c:6187:... · d2f8b7d0
      Michael Widenius authored
      Fix for LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery
      More DBUG_PRINT (to simplify future debugging)
      Aria: Added STATE_IN_REPAIR, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
      Aria: Some trivial speedup optimization
      Aria: Better warning if table was marked crashed by unfinnished repair
      
      
      mysql-test/lib/v1/mysql-test-run.pl:
        Fix so one can run RQG
      mysql-test/suite/maria/r/maria-recovery2.result:
        Update for new error message.
      mysys/stacktrace.c:
        Fixed compiler warning
      storage/maria/ha_maria.cc:
        More DBUG_PRINT
        Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
        Don't log query for dropping temporary table.
      storage/maria/ha_maria.h:
        Added prototype for drop_table()
      storage/maria/ma_blockrec.c:
        More DBUG_PRINT
        Make read_long_data() inline for most cases. (Trivial speedup optimization)
      storage/maria/ma_check.c:
        Better warning if table was marked crashed by unfinnished repair
      storage/maria/ma_open.c:
        More DBUG_PRINT
      storage/maria/ma_recovery.c:
        Give warning if found crashed table.
        Changed warning for tables that can't be opened.
      storage/maria/ma_recovery_util.c:
        Write warnings to DBUG file
      storage/maria/maria_chk.c:
        Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
      storage/maria/maria_def.h:
        Added maria_mark_in_repair(x)
      storage/maria/maria_read_log.c:
        Added option: --character-sets-dir
      storage/maria/trnman.c:
        By default set min_read_from to max value.
        This allows us to remove TRN:s from rows during recovery to get more space.
        This fixes bug LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery
      d2f8b7d0
  2. 24 Jul, 2010 1 commit
  3. 23 Jul, 2010 1 commit
  4. 16 Jul, 2010 2 commits
    • Michael Widenius's avatar
      Fixed wrong error message from federatedx (which could lead to assert in DBUG code) · 24c08f52
      Michael Widenius authored
      mysql-test/suite/federated/federated_server.result:
        Update to new error message
      mysql-test/suite/federated/federated_server.test:
        Update to new error message
      storage/federatedx/ha_federatedx.cc:
        Return real error code, not 0, as in some cases before.
      24c08f52
    • Michael Widenius's avatar
      mysql client: Ignore --comments at start of command line. This allows one to... · 9f96097a
      Michael Widenius authored
      mysql client: Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line.
      Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table  
      
      client/mysql.cc:
        Removed Oracle copyright from stdout, as Oracle doesn't have copyright to all code in this file.
        Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line.
      mysql-test/suite/maria/r/optimize.result:
        Added test for LP#603026
      mysql-test/suite/maria/t/optimize.test:
        Added test for LP#603026
      sql/net_serv.cc:
        Removed DBUG_ASSERT(), as this code can happen during testing.
      storage/maria/ma_check.c:
        Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table  
        The problem was duplicated memory usage with long packed keys.
      9f96097a
  5. 07 Jul, 2010 1 commit
  6. 02 Jul, 2010 1 commit
  7. 01 Jul, 2010 4 commits
  8. 30 Jun, 2010 1 commit
  9. 29 Jun, 2010 1 commit
  10. 28 Jun, 2010 4 commits
  11. 25 Jun, 2010 1 commit
  12. 23 Jun, 2010 2 commits
    • Michael Widenius's avatar
    • Michael Widenius's avatar
      Fixes for Opensolaris (to get buildbot green) · 5a2f40d4
      Michael Widenius authored
      - Fixed memory leaks in mysqldump
      - Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
      - Fixed realloc() problem that caused out of memory when running mysqldump.test on OpenSolaris
      
      
      client/mysqldump.c:
        Fixed memory leaks
        Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
      client/mysqltest.cc:
        Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
      include/my_global.h:
        Added simple macro val_or_null() to simplify detecting of NULL strings for printf
      sql/handler.cc:
        Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
      sql/sql_db.cc:
        Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
        Removed testing of 'new_db_name' as this is guranteed never NULL
      sql/sql_show.cc:
        Fixed printf of NULL which caused crashes on OpenSolaris when using --debug
      storage/csv/ha_tina.cc:
        Fixed realloc() problem that caused out of memory when running mysqldump.test on OpenSolaris
        (OpenSolaris default malloc() can't handle a lot of reallocs() of strings that are growing one byte at a time)
        This did speed up logging to cvs with a magnitude for large strings.
      5a2f40d4
  13. 15 Jun, 2010 2 commits
    • Michael Widenius's avatar
      Fixed compiler warnings · cfbee935
      Michael Widenius authored
      sql/log_event.cc:
        Fixed compiler warning on windows
      storage/maria/ma_state.c:
        Fixed compiler warning
      storage/maria/maria_chk.c:
        Fixed compiler warning
      storage/myisam/mi_dynrec.c:
        Fixed compiler warning
      support-files/compiler_warnings.supp:
        Fixed suppression rule
      cfbee935
    • Michael Widenius's avatar
      Don't flush pinned pages in checkpoint (fix for my last push) · 26968d68
      Michael Widenius authored
      
      storage/maria/unittest/ma_pagecache_single.c:
        Check if we can flush write locked page for normal flush
        Check that we can't flush read locked page with FLUSH_KEEP_LAZY (used by checkpoint)
      26968d68
  14. 14 Jun, 2010 4 commits
  15. 13 Jun, 2010 1 commit
    • Michael Widenius's avatar
      Fixed some bugs in the Maria storage engine · ec281a3c
      Michael Widenius authored
      - Changed default recovery mode from OFF to NORMAL to get automatic repair of not properly closed tables.
      - Fixed a rase condition when two threads calls external_lock and thr_lock() in different order. When this happend the transaction that called external lock first
        and thr_lock() last did not see see the rows from the other transaction, even if if it had to wait in thr_lock() for other to complete.
      - Fixed that one can run maria_chk on an automatcally recovered tables without warnings about too small transaction id
      - Don't give warning that crashed table could not be repaired if repair was disabled (and thus not run)
      - Fixed a error result from flush_key_cache() which caused a DBUG_ASSERT() when one was using concurrent reads on non transactional tables that was updated.
      
      client/mysqldump.c:
        Add "" around error message to make it more readable
      client/mysqltest.cc:
        Free environment variables
      mysql-test/r/mysqldump.result:
        Updated results
      mysql-test/r/openssl_1.result:
        Updated results
      mysql-test/suite/maria/r/maria-recover.result:
        Updated results
      mysql-test/suite/maria/r/maria3.result:
        Updated results
      mysql-test/suite/maria/t/maria3.test:
        Added more test of temporary tables
      storage/maria/ha_maria.cc:
        Changed default recovery mode from OFF to NORMAL to get automatic repair of not properly closed tables.
        Start transaction in ma_block_get_status() instead of in ha_maria::external_lock().
        - This fixes a rase condition when two threads calls external lock and thr_lock() in different order. When this happend the transaction that called external lock first and thr_lock() last did not see see the rows from the other transaction, even if if it had to wait in thr_lock() for other to complete.
        Store latest transaction id in controll file if recovery was done.
        - This allows one to run maria_chk on an automatcally recovered tables without warnings about too small transaction id
      storage/maria/ha_maria.h:
        Don't give warning that crashed table could not be repaired if repair was disabled (and thus not run)
      storage/maria/ma_blockrec.h:
        Added new function "_ma_block_get_status_no_versioning()"
      storage/maria/ma_init.c:
        Added hook to create trn in ma_block_get_status() if we are using MariaDB
      storage/maria/ma_open.c:
        Ensure we call _ma_block_get_status_no_versioning() for transactional tables without versioning (like tables with fulltext)
      storage/maria/ma_pagecache.c:
        Allow one to flush blocks that are pinned for read.
        This fixed a error result from flush_key_cache() which caused a DBUG_ASSERT() when one was using concurrent reads on non transactional tables that was updated.
      storage/maria/ma_recovery.c:
        Set maria_recovery_changed_data to 1 if recover changed something.
        Set max_trid_in_control_file to max found trn if we found a bigger trn.
        The allows will ensure that the control file is up to date after recovery which allows one to run maria_chk on the tables without warnings about too big trn
      storage/maria/ma_state.c:
        Call maria_create_trn_hook() in _ma_setup_live_state() instead of ha_maria::external_lock()
        This ensures that 'state' and trn are in sync and thus fixes the race condition mentioned for ha_maria.cc
      storage/maria/ma_static.c:
        Added maria_create_trn_hook() and maria_recovery_changed_data
      storage/maria/maria_def.h:
        Added MARIA_HANDLER->external_ptr, which is used to hold MariaDB thd.
        Added some new external variables
        Removed reference to non existing function: maria_concurrent_inserts()
      ec281a3c
  16. 10 Jun, 2010 2 commits
  17. 09 Jun, 2010 2 commits
    • Sergei Golubchik's avatar
      allow federated and innodb_plugin to be built · 14e53d06
      Sergei Golubchik authored
      storage/federated/Makefile.am:
        federated needs functions from mysys/string.c.
        mysqld does not use them, so they don't get into the binary.
      storage/federated/plug.in:
        enable federated again.
        remove it from all configurations.
      storage/federatedx/Makefile.am:
        federatedx is now called federatedx in configure
      storage/federatedx/ha_federatedx.cc:
        federatedx is now called federatedx in configure
      storage/federatedx/plug.in:
        federatedx is now called federatedx in configure
      storage/innodb_plugin/plug.in:
        enable innodb plugin again.
        remove it from all configurations.
      storage/xtradb/CMakeLists.txt:
        xtradb is now called xtradb in configure,
        and builds libxtradb.a and ha_xtradb.so
      storage/xtradb/Makefile.am:
        xtradb is now called xtradb in configure,
        and builds libxtradb.a and ha_xtradb.so
      storage/xtradb/handler/ha_innodb.cc:
        xtradb is now called xtradb in configure,
        and builds libxtradb.a and ha_xtradb.so
      storage/xtradb/plug.in:
        xtradb is now called xtradb in configure,
        and builds libxtradb.a and ha_xtradb.so
      14e53d06
    • Sergei Golubchik's avatar
  18. 31 May, 2010 1 commit
  19. 27 May, 2010 1 commit
    • Michael Widenius's avatar
      Fixed compiler warnings · 80ba8556
      Michael Widenius authored
      Fixed failing test innodb.innodb-autoinc.test
      Enabled innodb test suite
      
      mysql-test/mysql-test-run.pl:
        Enabled innodb test suite
      mysql-test/r/innodb-autoinc.result:
        Removed test as it exists in suite innodb
      mysql-test/suite/innodb/t/disabled.def:
        Removed innodb-autoinc
      mysql-test/suite/innodb/t/innodb-autoinc.test:
        Update to be able to run with plugin
      mysql-test/t/innodb-autoinc.test:
        Removed test as it exists in suite innodb
      sql/filesort.cc:
        Removed not used variable
      sql/slave.cc:
        Remove compiler warnings
      storage/pbxt/src/ha_pbxt.cc:
        Removed not used variable
      storage/xtradb/dict/dict0crea.c:
        Fixed compiler warning about unsigned comparison
      support-files/compiler_warnings.supp:
        Disable some not relevant warnings
      80ba8556
  20. 26 May, 2010 6 commits
  21. 25 May, 2010 1 commit