1. 10 Jan, 2006 10 commits
    • unknown's avatar
      Fix for BUG#15110: mysqldump --triggers: does not include DEFINER clause · d4d29edb
      unknown authored
      There are two main idea of this fix:
        - introduce a common function for server and client to split user value
          (<user name>@<host name>) into user name and host name parts;
        - dump DEFINER clause in correct format in mysqldump.
      
      
      BitKeeper/etc/ignore:
        added client/my_user.c libmysqld/my_user.c sql/my_user.c
      client/Makefile.am:
        Use my_user.c in linking of mysqldump executable.
      client/mysqldump.c:
        Fix for BUG#15110(mysqldump --triggers: does not include DEFINER clause)
      include/Makefile.am:
        Add my_user.c
      include/mysql_com.h:
        Introduce a constant for max user length.
      libmysqld/Makefile.am:
        Add my_user.c
      mysql-test/r/mysqldump.result:
        Update result file.
      sql-common/Makefile.am:
        Add my_user.c
      sql/Makefile.am:
        Add my_user.c
      sql/sp.cc:
        Use constant for max user length.
      sql/sp_head.cc:
        Use common function to parse user value.
      sql/sql_acl.cc:
        Use constant for max user length.
      sql/sql_parse.cc:
        Use constant for max user length.
      sql/sql_show.cc:
        Use constant for max user length.
      sql/sql_trigger.cc:
        Use constant for max user length.
      include/my_user.h:
        A header file for parse_user().
      sql-common/my_user.c:
        A new file for parse_user() implementation.
      d4d29edb
    • unknown's avatar
      Post-merge changes · ffc206d9
      unknown authored
      
      mysql-test/t/disabled.def:
        Enabling type_time.test
      ffc206d9
    • unknown's avatar
      Merge mysql.com:/home/alexi/dev/mysql-4.1-15805 · a44c687b
      unknown authored
      into  mysql.com:/home/alexi/dev/mysql-5.0-15805
      
      
      mysql-test/r/type_time.result:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      a44c687b
    • unknown's avatar
      Commenting out testcases which cause type_time.test failure. · 29818203
      unknown authored
       To be uncommented after fixing bug 15805.
      
      
      mysql-test/r/type_time.result:
        Fixing testcases results.
      mysql-test/t/type_time.test:
        Temporaly commented out testcases which cause type_time.test failure.
         To be uncommented after fixing bug 15805.
      29818203
    • unknown's avatar
      Fix for crashing mysqltest · 935ad7e8
      unknown authored
      
      client/mysqltest.c:
        Allocate one extra byte for string terminator in varname
      935ad7e8
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2fe75c38
      unknown authored
      into  mysql.com:/usr_rh9/home/elkin.rh9/MySQL/mysql-5.0
      
      
      2fe75c38
    • unknown's avatar
      BUG#9483 test was overworked to account reviews finally to leave only REVOKE check. · b49b86ae
      unknown authored
      There is a specific rpl_ignore_grant test case for GRANT.
      
      
      mysql-test/r/rpl_ignore_revoke.result:
        New BitKeeper file ``mysql-test/r/rpl_ignore_revoke.result''
      mysql-test/t/rpl_ignore_revoke-slave.opt:
        New BitKeeper file ``mysql-test/t/rpl_ignore_revoke-slave.opt''
      mysql-test/t/rpl_ignore_revoke.test:
        New BitKeeper file ``mysql-test/t/rpl_ignore_revoke.test''
      b49b86ae
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · cdf2eb4b
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/wl2930/my50-wl2930-integration
      
      
      cdf2eb4b
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 09ddf79d
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      09ddf79d
    • unknown's avatar
      Ajustement after merge · 8fd14af8
      unknown authored
      8fd14af8
  2. 09 Jan, 2006 15 commits
  3. 08 Jan, 2006 2 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/dev/mysql-4.1-0 · 48c82418
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      mysql-test/t/having.test:
        Auto merged
      mysql-test/r/having.result:
        Manual merge.
      sql/sql_select.cc:
        Manual merge.
      48c82418
    • unknown's avatar
      Fixed bug #14274: a query with a having clause containing only set function... · 770e0e81
      unknown authored
      Fixed bug #14274: a query with a having clause containing only set function returned a wrong result set.
      
      
      mysql-test/r/having.result:
        Added a test case for bug #14274.
      mysql-test/t/having.test:
        Added a test case for bug #14274.
      sql/sql_select.cc:
        Fixed bug #14274: a query with a having clause containing only set function returned a wrong result set.
        It happened because processing of the set functions in having started with a call of the split_sum_func
        method, instead of the split_sum_func2 method.
      770e0e81
  4. 07 Jan, 2006 1 commit
    • unknown's avatar
      Fixed bug #16016: MIN/MAX optimization was not applied to views. · 312c2f47
      unknown authored
      
      mysql-test/r/view.result:
        Added a test case for bug #16016.
      mysql-test/t/view.test:
        Added a test case for bug #16016.
      sql/opt_sum.cc:
        Fixed bug #16016: MIN/MAX optimization was not applied to views.
        The fix employs the standard way of handling direct references to view fields.
      312c2f47
  5. 06 Jan, 2006 3 commits
  6. 05 Jan, 2006 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 29fde528
      unknown authored
      into  mysql.com:/home/my/mysql-5.0
      
      
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/t/disabled.def:
        Manual merge
      sql/mysqld.cc:
        Manual merge
      sql/sp_head.cc:
        Manual merge
      sql/sql_trigger.cc:
        Manual merge
      29fde528
    • unknown's avatar
      Review fixes of new pushed code · 64206b18
      unknown authored
      - Fixed tests
      - Optimized new code
      - Fixed some unlikely core dumps
      - Better bug fixes for:
        - #14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        - #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null
      
      
      mysql-test/r/create.result:
        Update results after removing wrong warnings for CREATE ... SELECT
        New tests
      mysql-test/r/handler.result:
        Drop used tables
      mysql-test/r/kill.result:
        Make test portable
      mysql-test/r/mysqlshow.result:
        Drop tables used by previous test
      mysql-test/r/trigger.result:
        Reuse old procedure name
      mysql-test/r/view.result:
        Extra tests
      mysql-test/t/create.test:
        New tests to test fix of removing wrong warnings for CREATE ... SELECT
      mysql-test/t/disabled.def:
        Enable 'kill' test (should now be portable)
      mysql-test/t/handler.test:
        Drop used tables
      mysql-test/t/kill.test:
        Make test portable even if kill doesn't work at once
      mysql-test/t/mysqlshow.test:
        Drop tables used by previous test
      mysql-test/t/trigger.test:
        Reuse old procedure name
      mysql-test/t/view.test:
        Extra tests
      sql/field.cc:
        Removed compiler warning
      sql/ha_federated.cc:
        my_snprintf -> strmake()
        (Simple optimization)
      sql/ha_ndbcluster.cc:
        Indentation cleanups and trival optimization
      sql/item.cc:
        Moved save_org_in_field() to item.cc to make it easier to test
        Remove setting of null_value as this is not needed
      sql/item.h:
        Moved save_org_in_field() to item.cc to make it easier to test
      sql/log_event.cc:
        Remove inline of slave_load_file_stem()
        Added 'extension' parameter to slave_load_file_stem() to get smaller code
        Removed not critical (or needed) DBUG_ASSERT()'s
        Cleaned up usage of slave_load_file_stem() to not depend on constant string lengths
        Indentation fixes
      sql/opt_range.cc:
        Moved code from declaration to function body
        (To make it more readable)
      sql/parse_file.cc:
        Fixed DBUG_PRINT
      sql/sp.cc:
        Simple cleanups
        - Removed not needed {} level
        - Ensure saved variables starts with old_
      sql/sp_head.cc:
        Indentation fixes
        Remove core dump when using --debug when m_next_cached_sp == 0
        Fixed compiler warnings
        Trivial optimizations
      sql/sp_head.h:
        Changed argument to set_definer() to const
        Added THD argument to recursion_level_error() to avoid call to current_thd
      sql/sql_acl.cc:
        Removed not needed test (first_not_own_table is the guard)
      sql/sql_base.cc:
        Removed extra empty line
      sql/sql_handler.cc:
        Don't test table version in mysql_ha_read() as this is already tested in lock_tables()
        Moved call to insert_fields to be after lock_table() to guard aganst reopen of tables
        (Better fix for Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash)
      sql/sql_insert.cc:
        Mark fields that are set in CREATE ... SELECT as used
        (Removed wrong warnings about field not having a default value)
      sql/sql_parse.cc:
        Removed not needed test of 'tables' (first_not_own_table is the guard)
        Simplify code
      sql/sql_select.cc:
        Use group->field to check if value is null instead of item called by 'save_org_in_field'
        This is a better bug fix for #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null)
      sql/sql_trigger.cc:
        Move sql_modes_parameters outside of function
        Indentation fixes
        Fixed compiler warning
        Ensure that thd->lex->query_tables_own_last is set properly before calling check_table_access()
        (This allows us to remove the extra test in check_grant() and check_table_access())
      64206b18
    • unknown's avatar
      Merge mysql.com:/usr/local/mysql/mysql-5.0-win-fixes · f133b065
      unknown authored
      into  mysql.com:/usr/local/mysql/mysql-5.0
      
      
      include/config-win.h:
        Auto merged
      f133b065
    • unknown's avatar
      Port to Win64/x64 in Visual Studio 2005 · f6bcc388
      unknown authored
      
      include/config-win.h:
        Port to Win64/x64 in Visual Studio 2005.
        Avoid endless deprecation warnings.
      f6bcc388
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-15185 · 724f46c2
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      sql/handler.cc:
        Auto merged
      724f46c2
    • unknown's avatar
      Merge mysql.com:/usr/local/mysql/mysql-5.0-win-fixes · 23331172
      unknown authored
      into  mysql.com:/usr/local/mysql/mysql-5.0
      
      
      23331172
  7. 04 Jan, 2006 3 commits