1. 16 Nov, 2006 3 commits
    • unknown's avatar
      Fix for bug#24219 ALTER TABLE ... RENAME TO ... , DISABLE KEYS leads to crash · d63fa0a4
      unknown authored
      (this is the 5.0 patch, because 4.1 differs)
        
      There was an improper order of doing chained operations.
        
      To the documentor: ENABLE|DISABLE KEYS combined with RENAME TO, and no other
      ALTER TABLE clause, leads to server crash independent of the presence of
      indices and data in the table.
      
      
      mysql-test/r/alter_table.result:
        post-merge fix
        my locale is utf8, and this breaks non-utf8 stuff when doing manual merge :(
      sql/sql_table.cc:
        If there is operation on the KEYS, first do it
        and then do a rename if there is such. Or, we will crash because
        the underlying table has changed.
      d63fa0a4
    • unknown's avatar
      Merge example.com:/work/bug24219/my41 · db42257d
      unknown authored
      into  example.com:/work/bug24219/my50
      
      
      mysql-test/t/alter_table.test:
        Auto merged
      sql/sql_table.cc:
        manual merge
      mysql-test/r/alter_table.result:
        manual merge
      db42257d
    • unknown's avatar
      Fix for bug#24219 ALTER TABLE ... RENAME TO ... , DISABLE KEYS leads to crash · 09fc514b
      unknown authored
      There was an improper order of doing chained operations.
      
      To the documentor: ENABLE|DISABLE KEYS combined with RENAME TO, and no other
      ALTER TABLE clause, leads to server crash independent of the presence of
      indices and data in the table.
      
      
      mysql-test/r/alter_table.result:
        update result
      mysql-test/t/alter_table.test:
        add test for bug#24129
      sql/sql_table.cc:
        If there is operation on the KEYS, first do it
        and then do a rename if there is such. Or, we will crash because
        the underlying table has changed.
      09fc514b
  2. 15 Nov, 2006 2 commits
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug17700/my41-bug17700 · 574902e3
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/bug17700/my50-bug17700
      
      
      scripts/mysql_fix_privilege_tables.sh:
        Auto merged
      574902e3
    • unknown's avatar
      Bug#17700: mysql_fix_privilege_tables cannot handle a password \ · 78278bc4
      unknown authored
      	with embedded spaces
        
      Problem:  Original code written assuming password contains no spaces.
      Further, because of how sh interprets characters in variables, you
      cannot do the "simple solution".
        
      Solution:  Move the "was a password provided" check to the end. This
      allows us to correctly quote the password argument when passed to the
      mysql client program.  Addendum:  Put this check inside of a shell fn
      to simplify the code.
      
      
      scripts/mysql_fix_privilege_tables.sh:
        Moved password existence check to end to allow for passwords with
        with embedded spaces.
      78278bc4
  3. 13 Nov, 2006 1 commit
    • unknown's avatar
      Bug#18761: constant expression as UDF parameters not passed in as constant · 154c6e06
      unknown authored
      The code that set up data to be passed to user-defined functions was very
      old and analyzed the "Type" of the data that was passed into the UDF, when
      it really should analyze the "return_type", which is hard-coded for simple
      Items and works correctly for complex ones like functions.
      ---
      Added test at Sergei's behest.
      
      
      mysql-test/r/udf.result:
        Verify that various arguments work.
        ---
        Added test at Sergei's behest.
      mysql-test/t/udf.test:
        Verify that various arguments work.
        ---
        Added test at Sergei's behest.
      sql/item_func.cc:
        For function-Items, test whether it is constant and set the struct members 
        for the UDF parameter appropriately.
        
        Replace tabs with spaces in affected code.
      sql/udf_example.c:
        Include a simple function that is useful in testing.
      154c6e06
  4. 30 Oct, 2006 3 commits
    • unknown's avatar
      Improve comments around FLUSH STATUS · e948c64f
      unknown authored
      It's not possible to flush the global status variables in 5.0
      Update test case so it works by recording the value of handle_rollback
      before and compare it to the value after
      
      
      mysql-test/r/innodb_mysql.result:
        Update result file
      mysql-test/t/innodb_mysql.test:
        It's not possible to reset the global status variables in 5.0 so intead its value
        is recorded and compared to the after value.
        It should not have changed.
      sql/mysqld.cc:
        Improve comments
      sql/set_var.cc:
        Improve comments
      sql/sql_class.cc:
        Improve comments
      sql/sql_class.h:
        Improve comments
      e948c64f
    • unknown's avatar
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · c1b29d29
      unknown authored
      into  shellback.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      c1b29d29
  5. 27 Oct, 2006 1 commit
  6. 26 Oct, 2006 4 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · b2ea3624
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      b2ea3624
    • unknown's avatar
      Bug#23427 incompatible ABI change in 5.0.26? · fc72e762
      unknown authored
       - Improve icheck rules in Makefile.am
      
      
      include/Makefile.am:
        Remove m_ctype from BUILT_SOURCES, it has been in bk for a looong time.
        Improve the icheck rules
         - Abort make if icheck fails to compare, very important.
         - Don't include include files from /usr into the icheck file. Avoids problem when running
           icheck on different machines.
         - If no icheck is availabel, touch the mysql_h.ic file so it exists for "make dist"
      include/mysql_h_abi.ic:
        Remove all include files from /usr, no need to check that!
      fc72e762
    • unknown's avatar
      Bug#20894 Reproducible MySQL client segmentation fault · 08d43705
      unknown authored
       - Add two null bytes in  "buff" variable allowing us to call
         get_arg two times also for strings longer than sizeof(buff) 
      
      
      client/mysql.cc:
        Make sure there are _two_ zero bytes at the end of buff, to allow 'get_arg' to be
        called twice on long strings. The first time it will mark end of string with a
        zero and the second time it will "skip ahead" to the first zero, and the find the
        second one indicating end of buff.
      mysql-test/r/mysql.result:
        Update test results
      mysql-test/t/mysql.test:
        Add tests for "com_connect" function in mysql
        Add test reported in bug
      08d43705
    • unknown's avatar
      Fix for bug #22158: Errors in init_connect terminate connections silently · ac2f1cca
      unknown authored
      When executing the init_connect statement, thd->net.vio is set to 0, to         
      forbid sending any results to the client. As a side effect we don't log         
      possible errors, either.                                                        
                                                                                      
      Now we write warnings to the error log if an init_connect query                
      fails.                                                                          
      
      
      sql/sql_parse.cc:
        Fix for bug #22158: Errors in init_connect terminate connections silently
        - raise warnings if the init_connect execution fails.
      ac2f1cca
  7. 25 Oct, 2006 11 commits
  8. 24 Oct, 2006 15 commits
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint · 0a7a2b8f
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/lib/mtr_cases.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      0a7a2b8f
    • unknown's avatar
    • unknown's avatar
      Merge siva.hindu.god:/usr/home/tim/m/bk/g50 · d4bfae38
      unknown authored
      into  siva.hindu.god:/usr/home/tim/m/bk/50
      
      
      configure.in:
        Auto merged
      mysql-test/r/rename.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      mysys/mf_iocache.c:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_range.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      myisam/sort.c:
        Manual merge
      mysql-test/r/innodb_mysql.result:
        Manual merge
      mysql-test/t/innodb_mysql.test:
        Manual merge
      d4bfae38
    • unknown's avatar
      Update the reference file for mysql API/ABI for 5.0 · 47b1c7f9
      unknown authored
      
      include/mysql_h_abi.ic:
        Update the reference file for mysql API/ABI
      47b1c7f9
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint · 80bd3e38
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      BitKeeper/etc/ignore:
        auto-union
      configure.in:
        Auto merged
      include/mysql.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      include/Makefile.am:
        Merge, SUPERCLEANFILES and CLEANFILES has dissapeared in 5.0
      80bd3e38
    • unknown's avatar
      Pass --core-file option to mysqld when bootstrapping · f89efeb5
      unknown authored
      
      BitKeeper/etc/ignore:
        Added mysql-test/r/blackhole.log to the ignore list
      f89efeb5
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug23427/my41-bug23427 · c84d4bfa
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint
      
      
      c84d4bfa
    • unknown's avatar
      WL#3462 Add testing of MySQL client ABI to prevent unintentional ABI breaks · 9c9bf0af
      unknown authored
      BUG#23427 incompatible ABI change in 5.0.26?
         - Use the icheck tool if avaliable and compare the current mysql.h to a version
      controlled reference file 
      
      
      BitKeeper/etc/ignore:
        Added include/check_abi include/mysql_h.ic to the ignore list
      configure.in:
        Look for icheck in configure
      include/Makefile.am:
        Add rule to build mysql_h.ic if icheck is avaliable
        Add rule to compare mysql_h.ic to the version
        controlled reference file mysql_h_abi.ic
      include/mysql.h:
        Add comment about taking care when editing mysql.h
        Add example how to add reserved fiels in the structs to
        allow for features to be added without breaking ABI
      include/mysql_h_abi.ic:
        Add new file describing the libmysqlclient ABI used as a reference to detect ABI breakage
      9c9bf0af
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint · fa6d7c50
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      fa6d7c50
    • unknown's avatar
      Remove debug printout · c7cedcd6
      unknown authored
      c7cedcd6
    • unknown's avatar
      Bug#23037 Bug in field "Default" of query "SHOW COLUMNS FROM table" · 7941fdd0
      unknown authored
       - Fix check in mysql_client_test to reflect the change of datatype
         for DEFAULT column
      
      
      tests/mysql_client_test.c:
        Update check of datatype for field DEFAULT returned from "explain"
        as datatype has changed after patch for bug 23037
      7941fdd0
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint · 01290bee
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      tests/mysql_client_test.c:
        Remove the fflush(NULL) and instead explicitly fflush stdout and then stderr
      01290bee
    • unknown's avatar
      Run mysql_client_test without --silent · 297d968a
      unknown authored
      Flush both stdout and stderr before abort'ing mysql_client_test
      
      
      mysql-test/mysql-test-run.pl:
        Run mysql_client_test wihtout --silent flag
      tests/mysql_client_test.c:
        Before aborting mysql_client_test in die, make sure
        to first flush stdout and finally after the error message 
        has been printed also fflush stderr
      297d968a
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1-maint · 0dac6c35
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      0dac6c35
    • unknown's avatar
      Fix spelling errors in test files · 1023e010
      unknown authored
      
      mysql-test/r/mysqldump-max.result:
        Update test result after fix of spelling error
      mysql-test/r/rpl_trigger.result:
        Update test result after fix of spelling error
      mysql-test/r/type_newdecimal.result:
        Update test result after fix of spelling error
      mysql-test/t/mysqldump-max.test:
        Fix spelling error "disable_warnings"
        Write shorter "drop table..."
      mysql-test/t/rpl_trigger.test:
        Fix spelling error, there is no --ignore_warnings
      mysql-test/t/type_newdecimal.test:
        Fix spelling error
      1023e010