1. 19 Dec, 2008 1 commit
    • Davi Arnaut's avatar
      Bug#41612: resolve_stack_dump does not decode 5.1 stack trace · d6e7b04a
      Davi Arnaut authored
      resolve_stack_dump is not able to decode a stack trace produced
      by glibc's backtrace() functions. The problem is that the stack
      trace addresses are printed between brackets and the utility is
      not able to ignore the brackets.
      
      The solution is to modify resolve_stack_dump so it can recognize
      stack trace addresses surrounded by brackets. e.g. [0xdeadbeef].
      d6e7b04a
  2. 17 Dec, 2008 5 commits
  3. 16 Dec, 2008 4 commits
  4. 15 Dec, 2008 1 commit
  5. 12 Dec, 2008 8 commits
    • Andrei Elkin's avatar
      c9fb9be3
    • Andrei Elkin's avatar
      Bug #41003 log_bin_trust_function_creators_func test explicitly warns on a bug in it · d083ceab
      Andrei Elkin authored
      The test 
      1. did not verify that CREATE FUNCTION shall fails in a case of active binlog
         and @@log_bin_trust_function_creators is zero if there is no DETERMINISTIC qualifier
         and super user privilege;
      2. contained an explit warning on that CREATE FUNCTION actually succeeded whereas
         it was supposed to fail;
      3. did not demand the bin-log be set ON even though it has contained the opt file
         explictily setting the name for the binlog file.
            
      Fixed 1-3 with modifying the test accordingly.
      d083ceab
    • Andrei Elkin's avatar
      merge 5.1-bt repository to my local branch. · 97d0c8d9
      Andrei Elkin authored
      97d0c8d9
    • Gleb Shchepa's avatar
      e1f93509
    • Gleb Shchepa's avatar
      Bug #40761: Assert on sum function on · c1bf0475
      Gleb Shchepa authored
                  IF(..., CAST(longtext AS UNSIGNED), signed_val)
                  (was: LEFT JOIN on inline view crashes server)
      
      Select from a LONGTEXT column wrapped with an expression
      like "IF(..., CAST(longtext_column AS UNSIGNED), smth_signed)"
      failed an assertion or crashed the server. IFNULL function was
      affected too.
      
      LONGTEXT column item has a maximum length of 32^2-1 bytes,
      at the same time this is a maximum possible length of any
      MySQL item. CAST(longtext_column AS UNSIGNED) returns some
      unsigned numeric result of length 32^2-1, so the result of
      IF/IFNULL function of this number and some other signed number
      will have text length of (32^2-1)+1=32^2 (one byte for the
      minus sign) - there is integer overflow, and the length is
      equal to zero. That caused assert/crash.
      
      CAST AS UNSIGNED function has been modified to limit maximal
      length of resulting number to 67 (maximal length of DECIMAL
      and two characters for minus sign and dot).
      c1bf0475
    • Andrei Elkin's avatar
      Bug #41383 Test commit1_innodb fails with binlog-format=row · 2b761ffd
      Andrei Elkin authored
      The test explicitly warned on existence of a bug in its 27th part.
      The expected values of prepare and commit counters changed, corrected, by
      fixes to bug#40221.
      Notice, that binlog does not have to register for a statement with
      the statement binlog-format because the statement rollback does not need
      to do anything in that mode. It's not so with the ROW format which was
      bug#40221 concern.
      
      Fixed with correcting the expected values of the mentioned counters and
      explained that with comments in the test.
      2b761ffd
    • Gleb Shchepa's avatar
      rollback of bug #40761 fix · 5772a50b
      Gleb Shchepa authored
      5772a50b
    • Gleb Shchepa's avatar
      rollback of bug #40761 fix · 03f9b2ce
      Gleb Shchepa authored
      03f9b2ce
  6. 11 Dec, 2008 10 commits
    • Gleb Shchepa's avatar
      09219a03
    • Gleb Shchepa's avatar
      Bug #40761: Assert on sum function on · ce8ad64d
      Gleb Shchepa authored
                  IF(..., CAST(longtext AS UNSIGNED), signed_val)
                  (was: LEFT JOIN on inline view crashes server)
      
      Select from a LONGTEXT column wrapped with an expression
      like "IF(..., CAST(longtext_column AS UNSIGNED), smth_signed)"
      failed an assertion or crashed the server. IFNULL function was
      affected too.
      
      LONGTEXT column item has a maximum length of 32^2-1 bytes,
      at the same time this is a maximum possible length of any
      MySQL item. CAST(longtext_column AS UNSIGNED) returns some
      unsigned numeric result of length 32^2-1, so the result of
      IF/IFNULL function of this number and some other signed number
      will have text length of (32^2-1)+1=32^2 (one byte for the
      minus sign) - there is integer overflow, and the length is
      equal to zero. That caused assert/crash.
      
      The bug has been fixed by the same solution as in the CASE
      function implementation.
      ce8ad64d
    • Chad MILLER's avatar
      Merge from bugteam trunk. · f8b28604
      Chad MILLER authored
      f8b28604
    • Chad MILLER's avatar
      Merge fix for Bug 33812 from 5.0-bugteam. · 14f2ce6d
      Chad MILLER authored
      14f2ce6d
    • Chad MILLER's avatar
      Bug#33812: mysql client incorrectly parsing DELIMITER · cf9126a0
      Chad MILLER authored
      Fix parsing of mysql client commands, especially in relation to
      single-line comments when --comments was specified.
      
      This is a little tricky, because we need to allow single-line
      comments in the middle of statements, but we don't want to allow
      client commands in the middle of statements. So in
      comment-preservation mode, we go ahead and send single-line
      comments to the server immediately when we encounter them on their
      own. 
      
      This is still slightly flawed, in that it does not handle a
      single-line comment with leading spaces, followed by a client-side
      command when --comment has been enabled. But this isn't a new
      problem, and it is quite an edge condition. Fixing it would require
      a more extensive overall of how the mysql client parses commands. 
      cf9126a0
    • Luis Soares's avatar
      BUG#38826 · a0869f7c
      Luis Soares authored
      Merge from 5.0-bugteam. Additional fix for unused ret variable warning.
      a0869f7c
    • Luis Soares's avatar
      Fix PB warnings for parenthesis and valgrind leak report. · e0f4556d
      Luis Soares authored
      BUG#38826
      e0f4556d
    • Sergey Glukhov's avatar
      5.0-bugteam->5.1-bugteam merge · dfcefa20
      Sergey Glukhov authored
      dfcefa20
    • Sergey Glukhov's avatar
      fix for pushbuild failure on 64 linux · e419c5d3
      Sergey Glukhov authored
      e419c5d3
    • Sergey Glukhov's avatar
  7. 10 Dec, 2008 11 commits