- 04 Aug, 2015 1 commit
-
-
Jan Lindström authored
-
- 03 Aug, 2015 1 commit
-
-
Jan Lindström authored
Conflicts: client/mysql_upgrade.c mysql-test/r/func_misc.result mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result mysql-test/suite/innodb/r/innodb-fk.result mysql-test/t/subselect_sj_mat.test sql/item.cc sql/item_func.cc sql/log.cc sql/log_event.cc sql/rpl_utility.cc sql/slave.cc sql/sql_class.cc sql/sql_class.h sql/sql_select.cc storage/innobase/dict/dict0crea.c storage/innobase/dict/dict0dict.c storage/innobase/handler/ha_innodb.cc storage/xtradb/dict/dict0crea.c storage/xtradb/dict/dict0dict.c storage/xtradb/handler/ha_innodb.cc vio/viosslfactories.c
-
- 31 Jul, 2015 10 commits
-
-
Sergei Golubchik authored
Correct fix for this bug. The problem was that Item_func_group_concat() was calling setup_order(), passing args as the second argument, ref_pointer_array. While ref_pointer_array should have free space at the end, as setup_order() can append elements to it. In this particular case args[] elements were overwritten when setup_order() was pushing new elements into ref_pointer_array.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Cherry-pick from 10.0: commit 126523d1 Author: Sergei Golubchik <serg@mariadb.org> Date: Mon Feb 23 20:53:41 2015 +0100 MDEV-6703 Add "mysqlbinlog --binlog-row-event-max-size" support
-
Sergei Golubchik authored
Alternative fix that doesn't cause view.test crash in --ps: Remember when Item_ref was fixed right in the constructor and did not have a full Item_ref::fix_fields() call. Later in PS/SP, after Item_ref::cleanup, we use this knowledge to avoid doing full fix_fields() for items that were never supposed to be fix_field'ed. Simplify the test case.
-
Sergei Golubchik authored
-
Sergey Vojtovich authored
Let mysql_upgrade return zero exit status when installation is up to date.
-
Jan Lindström authored
-
Sergey Vojtovich authored
execution of PS GROUP_CONCAT() with ORDER BY column position may crash server on PS reexecution. The problem was that arguments array of GROUP_CONCAT() was adjusted to point to temporary elements (resolved ORDER BY fields) during first execution. This patch expands rev. 08763096 to restore original arguments array as well.
-
Jan Lindström authored
There is several different ways to incorrectly define foreign key constraint. In many cases earlier MariaDB versions the error messages produced by these cases are not very clear and helpful. This patch improves the warning messages produced by foreign key parsing.
-
Jan Lindström authored
Added better error message that will be printed when foreign key constraint name in create table is not unique in database.
-
- 29 Jul, 2015 2 commits
-
-
Sergey Vojtovich authored
GET_LOCK() silently accepted negative values and NULL for timeout. Fixed GET_LOCK() to issue a warning and return NULL in such cases.
-
Sergey Vojtovich authored
with plugin-load-add that are already registered at mysql.plugin - issue just one error message, without this extra warning - don't abuse ER_UDF_EXISTS, instead add a proper error message for plugins - report started initialization for each plugin source
-
- 27 Jul, 2015 7 commits
-
-
Sergei Golubchik authored
Don't forget to set thd->lex->unit.insert_table_with_stored_vcol in the mysql_load(). Othewise virtual columns will not be updated.
-
Sergei Golubchik authored
and don't check table privileges in external_lock(F_UNLCK).
-
Sergei Golubchik authored
(patch originally by Alexander Barkov)
-
Sergei Golubchik authored
Instead of checking user's privileges with check_access(), use the cached value in table->grant.privilege instead - it is correctly set to the invoker or definer, depending on SQL SECURITY mode. Continue to use check_access() for DDLs when table->grant.privilege may be not set (but these cases are only possible on tables, never for views). (patch originally by Alexander Barkov)
-
Sergei Golubchik authored
prevent concurrent cleanups in multi-threaded mysqlimport (they can happen if many threads get an error at the same time), safe_exit() is not thread-safe.
-
Sergei Golubchik authored
fix the previous patch to pass defaults-file to parse_arguments
-
Sergei Golubchik authored
backport https://github.com/MariaDB/server/pull/88 to 10.0
-
- 26 Jul, 2015 2 commits
-
-
Monty authored
Added some extra safety asserts in MyISAM key cache. my_thread_var->init is now: 0 at startup 1 at init 2 when thread dies
-
Monty authored
Fix was to add a test in Query_log_event::Query_log_event() if we are using CREATE ... SELECT and in this case use trans cache, like we do on the master. This avoid using (with doesn't have checksum) Other things: - Removed dummy call my_checksum(0L, NULL, 0) - More DBUG_PRINT - Cleaned up Log_event::need_checksum() to make it more readable (similar as in MySQL 5.6) - Renamed variable that was hiding another one in create_table_imp()
-
- 25 Jul, 2015 2 commits
-
-
Monty authored
Fixed memory loss detected on P8. This can happen when we call after_flush but never call after_rollback() or after_commit(). The old code used pthread_setspecific() to store temporary data used by the thread. This is not safe when used with thread pool, as the thread may change for the transaction. The fix is to save the data in THD, which is guaranteed to be properly freed. I also fixed the code so that we don't do a malloc() for every transaction.
-
Monty authored
field.cc - Fixed warning about overlapping memory copy (backport from 10.0) Item_subselect.cc - Fixed core dump in main.view - Problem was that thd->lex->current_select->master_unit()->item was not set, which caused crash in maxr_as_dependent sql/mysqld.cc - Got error on shutdown as we where freeing mutex before all THD objects was freed (~THD uses some mutex). Fixed by during shutdown freeing THD inside mutex. sql/log.cc - log_space_lock and LOCK_log where locked in inconsistenly. Fixed by not having a log_space_lock around purge_logs. sql/slave.cc - Remove unnecessary log_space_lock - Move cond_broadcast inside lock to ensure we don't miss the signal
-
- 24 Jul, 2015 1 commit
-
-
Elena Stepanova authored
Do not attempt to run unix-specific code on Windows
-
- 23 Jul, 2015 2 commits
-
-
Dmitry Lenev authored
FUNCTIONS/PRIVILEGES DIFFERENTLY' Fix for bug#11759114 - '51401: GRANT TREATS NONEXISTENT FUNCTIONS/PRIVILEGES DIFFERENTLY'. The problem was that attempt to grant EXECUTE or ALTER ROUTINE privilege on stored procedure which didn't exist succeed instead of returning an appropriate error like it happens in similar situation for stored functions or tables. The code which handles granting of privileges on individual routine calls sp_exist_routines() function to check if routine exists and assumes that the 3rd parameter of the latter specifies whether it should check for existence of stored procedure or function. In practice, this parameter had completely different meaning and, as result, this check was not done properly for stored procedures. This fix addresses this problem by bringing sp_exist_routines() signature and code in line with expectation of its caller. Conflicts: mysql-test/r/grant.result mysql-test/t/grant.test sql/sp.cc
-
Sergey Vojtovich authored
- since param is quite small store it on stack - fixed a few memory leaks
-
- 22 Jul, 2015 1 commit
-
-
Alexander Barkov authored
"mtr connect.odbc_postgresql"
-
- 21 Jul, 2015 1 commit
-
-
Jan Lindström authored
Analysis: At check_trx_exists function InnoDB allocates a new trx if no trx is found from thd but this newly allocated trx is not registered to thd. This is unsafe, because nothing prevents InnoDB plugin from being uninstalled while there's active transaction. This can cause crashes, hang and any other odd behavior. It may also corrupt stack, as functions pointers are not available after dlclose. Fix: The fix is to use thd_set_ha_data() when manipulating per-connection handler data. It does appropriate plugin locking.
-
- 20 Jul, 2015 2 commits
-
-
Elena Stepanova authored
The test has performance-schema in the opt file, so it failed when the server was compiled without performance schema. Make the option loose, then MTR will be able to reach have_perfschema.inc check and will skip the test gracefully.
-
Jan Lindström authored
Problem was that test just takes too long time in slow I/O and triggers testcase timeout. Reduced the number of operations and inserts to make test shorter.
-
- 19 Jul, 2015 2 commits
-
-
Kristian Nielsen authored
-
Kristian Nielsen authored
--gtid-ignore-duplicates was comparing sequence numbers as 32-bit, so after 2**32 transactions things would start to fail.
-
- 16 Jul, 2015 5 commits
-
-
Monty authored
-
Monty authored
The fix is that if the slave has a different integer size than the master, then they will assume the master has the same signed/unsigned modifier as the slave. This means that one can safely change a coon the slave an int to a bigint or an unsigned int to an unsigned int. Changing an unsigned int to an signed bigint will cause replication failures when the high bit of the unsigned int is set. We can't give an error if the signess is different on the master and slave as the binary log doesn't contain the signess of the column on the master.
-
Monty authored
The fix is that if the slave has a different integer size than the master, then they will assume the master has the same signed/unsigned modifier as the slave. This means that one can safely change a coon the slave an int to a bigint or an unsigned int to an unsigned int. Changing an unsigned int to an signed bigint will cause replication failures when the high bit of the unsigned int is set. We can't give an error if the signess is different on the master and slave as the binary log doesn't contain the signess of the column on the master.
-
Alexander Barkov authored
-
Sergey Vojtovich authored
Let mysqld_safe_syslog.cnf force disable error log so that logging to syslog is not affected by previous log_error setting. Added handling of --skip-log-error to mysqld_safe.
-
- 14 Jul, 2015 1 commit
-
-
Jan Lindström authored
Merge error on srv0start.cc
-