- 17 Oct, 2005 1 commit
-
-
unknown authored
droping trigger on InnoDB table". Deadlock occured in cases when we were trying to create two triggers for the same InnoDB table concurrently and both threads were able to reach close_cached_table() simultaneously. Bugfix implements new approach to table locking and table cache invalidation during creation/dropping of trigger. No testcase is supplied since bug was repeatable only under high concurrency. sql/mysql_priv.h: reopen_name_locked_table(): Changed function signature to make it more robust against erroneous usage. sql/sql_base.cc: reopen_name_locked_table(): Changed function signature to make it more robust against erroneous usage. Obtaining LOCK_open lock is now resposibility of caller. When searching for the table to open we should not prefer connection's current database over database which was explicitly specified in TABLE_LIST::db member (even if database is not explicitly specified for table in original query TABLE_LIST::db will be set properly at parsing stage). Fixed behavior of function in cases when error occurs during opening of table. sql/sql_table.cc: prepare_for_restore()/prepare_for_repair(): We should not prefer connection's current database over database which was specified in TABLE_LIST::db member (even if database is not explicitly specified for table in original query TABLE_LIST::db will be set properly at parsing stage). Fixed behavior in unlikely case when we are unable to open table which we are restoring/reparing at the end of preparation stage. sql/sql_trigger.cc: mysql_create_or_drop_trigger(): Now instead of opening and locking table, creating trigger, and then trying to invalidate all instances of this table in table cache, we obtain name lock on table first (thus ensuring that no other thread has this table open), open it, create trigger and then close table therefore releasing lock. New approach is more in line with other places where change .frm files (i.e. change table meta-data). With this change we also get rid of deadlock which occured in cases when we were trying to create two triggers for the same InnoDB table concurrently and both threads were able to reach close_cached_table() simultaneously. (Alternative was to forbid to InnoDB downgrade locks for CREATE/DROP TRIGGER statements in one way or another but I think that proposed solution is better long term).
-
- 07 Oct, 2005 7 commits
-
-
unknown authored
into mysql.com:/home/cps/mysql/trees/mysql-5.0
-
unknown authored
server-tools/instance-manager/mysql_connection.cc: fix pragma statement server-tools/instance-manager/user_map.cc: fix pragma statement
-
unknown authored
ndb/src/mgmsrv/Services.cpp: Auto merged
-
unknown authored
-
unknown authored
client/mysql.cc: Auto merged mysql-test/t/rpl_openssl.test: Auto merged mysql-test/r/rpl_openssl.result: manual merge
-
unknown authored
allow select into outfile from I_S tables it is enough to add FILE_ACL for I_S tables only to 'check_table_access' function as we use 'any_db' for 'check_access' function in places where FILE_ACL is required mysql-test/t/outfile.test: Fix for bug#13202 SELECT * INTO OUTFILE ... FROM information_schema.schemata now fails test case
-
unknown authored
into mysql.com:/home/psergey/mysql-5.0-bug13484 sql/ha_innodb.cc: Auto merged mysql-test/r/index_merge_innodb.result: Auto merged mysql-test/r/rowid_order_innodb.result: Auto merged mysql-test/t/index_merge_innodb.test: Auto merged
-
- 06 Oct, 2005 15 commits
-
-
unknown authored
Corrected platform name output Services.cpp: Dont print null address (back port from 5.0) ndb/src/mgmsrv/Services.cpp: Dont print null address (back port from 5.0) scripts/make_binary_distribution.sh: Corrected platform name output
-
unknown authored
Reintroduced --machine Better sh compatibility, "for i ; do" is not portable scripts/make_binary_distribution.sh: Reintroduced --machine Better sh compatibility, "for i ; do" is not portable
-
unknown authored
into mysql.com:/home/dellis/mysqlab/bk/mysql-5.0
-
unknown authored
into mysql.com:/home/dellis/mysqlab/bk/mysql-4.1
-
unknown authored
into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
-
unknown authored
Fixed documentation for findopt(). Cleaned code a bit.
-
unknown authored
(bug#13791 - mysqld crashes at startup in TC_LOG_MMAP::open)
-
unknown authored
Replaced --machine with --platform General code cleanup scripts/make_binary_distribution.sh: Replaced --machine with --platform General code cleanup
-
unknown authored
into mysql.com:/home/gluh/MySQL/Bugs/4.1.13605
-
unknown authored
-
unknown authored
-
unknown authored
into msdesk.(none):/home/msvensson/mysql-5.0 BUILD/SETUP.sh: Auto merged BitKeeper/deleted/.del-ctype-cp932.c: Auto merged BitKeeper/deleted/.del-ctype_cp932.result: Auto merged BitKeeper/deleted/.del-ctype_cp932.test: Auto merged BitKeeper/deleted/.del-ndb_range_bounds.pl~ff7e47a35fb44c74: Auto merged innobase/os/os0sync.c: Auto merged mysql-test/r/ctype_tis620.result: Auto merged mysql-test/r/ctype_ucs.result: Auto merged mysql-test/r/ctype_utf8.result: Auto merged mysql-test/t/ctype_uca.test: Auto merged mysql-test/t/ctype_ucs.test: Auto merged mysql-test/t/ctype_ujis.test: Auto merged mysql-test/t/ctype_utf8.test: Auto merged sql/ha_innodb.cc: Auto merged sql/item_cmpfunc.cc: Auto merged strings/ctype-big5.c: Auto merged strings/ctype-gbk.c: Auto merged strings/ctype-simple.c: Auto merged strings/ctype-sjis.c: Auto merged strings/ctype-ucs2.c: Auto merged client/mysql.cc: Sam change in both 4.1 and 5.0 mysql-test/r/ctype_uca.result: Merge mysql-test/r/ctype_ujis.result: Merge strings/ctype-mb.c: Merge strings/ctype-tis620.c: Merge
-
unknown authored
Wrong variable. sql/item_cmpfunc.cc: Wrong variable.
-
unknown authored
BitKeeper/deleted/.del-ndb_range_bounds.pl~ff7e47a35fb44c74: Delete: mysql-test/ndb/ndb_range_bounds.pl
-
unknown authored
Let pthread_mutex_init() macro return 0 on Windows mysql_priv.h: Return type is to be 'my_bool' for 'opt_enable_shared_memory' sql/mysql_priv.h: Return type is to be 'my_bool' for 'opt_enable_shared_memory' include/my_pthread.h: Let pthread_mutex_init() macro return 0 on Windows
-
- 05 Oct, 2005 13 commits
-
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-5.0
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-5.0
-
unknown authored
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-5.0 sql/sql_table.cc: Auto merged
-
unknown authored
fixed CHECKSUM TABLE to be independent from the first 'deleted' bit in the null bitmask (undefined in the InnoDB) bug#13710 sql/sql_table.cc: fixed CHECKSUM TABLE to be independent from the first 'deleted' bit in the null bitmask (undefined in the InnoDB) bug#13710
-
unknown authored
into mysql.com:/home/jimw/my/mysql-5.0-clean
-
unknown authored
server error messages file. (Bug #13071) extra/comp_err.c: Fail when two messages for the same language are given for an error
-
unknown authored
-
unknown authored
BUILD/SETUP.sh: Remove -ansi
-
unknown authored
into mysql.com:/usr/home/bar/mysql-4.1.b12476
-
unknown authored
BUILD/SETUP.sh: Remov -ansi flag
-
unknown authored
wrong variable. sql/item_cmpfunc.cc: wrong variable.
-
unknown authored
into mysql.com:/usr/home/bar/mysql-4.1.b13046
-
- 04 Oct, 2005 4 commits
-
-
unknown authored
scripts/mysql_fix_privilege_tables.sh: Make the script not dependent on the current directory.
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-5.0 sql/ha_innodb.cc: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/handler.h: Auto merged
-
unknown authored
into serg.mylan:/usr/home/serg/Abk/mysql-5.0
-
unknown authored
somehow it didn't get into the previous changeset mysql-test/r/innodb.result: somehow it didn't get into the previous changeset
-