1. 07 Mar, 2008 7 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG34656/mysql-5.1-engines · e0075179
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.1-engines
      
      
      e0075179
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.0-engines · 0d4fb8b4
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.1-engines
      
      
      0d4fb8b4
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1-engines · 928c449a
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.1-engines
      
      
      928c449a
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.0-engines · e78f6284
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.0-engines
      
      
      e78f6284
    • unknown's avatar
      BUG#34656 - KILL a query = Assertion failed: m_status == DA_ERROR || · 44df0f6e
      unknown authored
                  m_status == DA_OK
      
      Reading from information_scema.tables or information_schema.columns
      may cause assertion failure in debug builds. This may happen under
      rare circumstances when information_schema fails to get information
      about a table (e.g. when a connection is killed).
      
      This happens because open_normal_and_derived_tables() can return an
      error without setting an error message in THD. But information_schema
      attempts to get an error message from THD unconditionally.
      
      With this fix information_schema attempts to get an error message
      from THD only in case error message is set in THD.
      
      
      mysql-test/r/information_schema.result:
        A test case for BUG#34656.
      mysql-test/t/information_schema.test:
        A test case for BUG#34656.
      sql/item_func.cc:
        Set proc info to "User sleep".
      sql/sql_show.cc:
        open_normal_and_derived_tables() can return an error without
        setting an error message in THD. That means we must access
        error message conditionally, only in case thd->is_error() is
        true.
      44df0f6e
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-work/mysql-5.0.b27580v2 · a03f1a4c
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.1.b27580
      Additonal after merge fix
      
      
      mysql-test/r/ctype_cp1250_ch.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_cp1250_ch.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      sql/item_create.cc:
        After merge fix
      a03f1a4c
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-work/mysql-5.0-engines · 613fe6ac
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.1-engines
      
      
      613fe6ac
  2. 06 Mar, 2008 2 commits
    • unknown's avatar
      additional test fixes for bug 27580 · f2c9483d
      unknown authored
      f2c9483d
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-work/mysql-5.0.b27580 · 89fb97c5
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.0.b27580v2
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/include/ctype_common.inc:
        after merge fix
      mysql-test/r/ctype_big5.result:
        after merge fix
      mysql-test/r/ctype_euckr.result:
        after merge fix
      mysql-test/r/ctype_gb2312.result:
        after merge fix
      mysql-test/r/ctype_gbk.result:
        after merge fix
      mysql-test/r/ctype_uca.result:
        after merge fix
      89fb97c5
  3. 04 Mar, 2008 1 commit
    • unknown's avatar
      Bug#23097 mysql can't insert korean on mysql prompt. · 8e4a3fcb
      unknown authored
      Problem: libedit is a very pure-ASCII oriented library,
      and it is not aware of extended (0x80..0xFF) or even multi-byte
      characters. It considered such characters as non-printable
      and didn't allow to input them.
      Fix: make libedit think that all bytes >= 0x80 are printable.
      
      
      cmd-line-utils/libedit/el.h:
        Defining macro, a locale's isprint() replacement.
        We'll consider all 8bit values as printable characters.
      cmd-line-utils/libedit/key.c:
        Changing isprint() to el_isprint().
      cmd-line-utils/libedit/map.c:
        Changing isprint() to el_isprint().
      cmd-line-utils/libedit/read.c:
        Changing isprint() to el_isprint().
      cmd-line-utils/libedit/refresh.c:
        Changing isprint() to el_isprint().
      8e4a3fcb
  4. 29 Feb, 2008 1 commit
    • unknown's avatar
      Bug#23924 general_log truncates queries with character set introducers. · 1ed34fed
      unknown authored
      Problem: logging of utf8-incompatible binary strings didn't work
      Fix: hex-encoding of incompatible sequences.
      
      
      mysql-test/r/log_tables.result:
        Adding test
      mysql-test/t/log_tables.test:
        Adding test
      sql/field.cc:
        Copying with hex escaping
      sql/field.h:
        New field flag
      sql/log.cc:
        Marking the column "general_log.argument" as hex-escaping field.
      sql/sql_string.cc:
        New function to copy strings with hex-encoding of incompatible characters.
      sql/sql_string.h:
        Prototype for the new function
      1ed34fed
  5. 27 Feb, 2008 3 commits
    • unknown's avatar
      BUG#13861 - START SLAVE UNTIL may stop 1 evnt too late if · 83bcd5df
      unknown authored
                  log-slave-updates and circul repl
      
      After merge fixes.
      
      
      mysql-test/suite/rpl/t/rpl_dual_pos_advance-slave.opt:
        Rename: mysql-test/t/rpl_dual_pos_advance-slave.opt -> mysql-test/suite/rpl/t/rpl_dual_pos_advance-slave.opt
      mysql-test/include/wait_for_slave_sql_to_stop.inc:
        Do not change connection if it was requested by caller (needed for
        circular replication tests).
      mysql-test/suite/rpl/t/rpl_dual_pos_advance.test:
        Let include/wait_for_slave_sql_to_stop.inc know that we do not want to
        change connection to slave.
      sql/rpl_rli.cc:
        After merge fix.
      sql/rpl_rli.h:
        After merge fix.
      sql/slave.cc:
        After merge fix.
      83bcd5df
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.0-engines · eec647ba
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.1-engines
      
      
      mysql-test/suite/rpl/r/rpl_dual_pos_advance.result:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/slave.h:
        Use local.
      mysql-test/suite/rpl/t/rpl_dual_pos_advance.test:
        Manual merge.
      sql/slave.cc:
        Manual merge.
      eec647ba
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.0-engines · 432bc1f2
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.0-engines
      
      
      432bc1f2
  6. 26 Feb, 2008 1 commit
  7. 25 Feb, 2008 1 commit
    • unknown's avatar
      Post push fix · db9b2bdc
      unknown authored
      Fixed a missed case in the patch for Bug#31931.
      Also makes Bug#33722 a duplicate of Bug#31931.
      Added tests for better coverage.
      Replaced some legacy function calls.
      
      
      mysql-test/r/partition.result:
        Added tests for better coverage
      mysql-test/r/partition_datatype.result:
        Added tests for better coverage
      mysql-test/r/partition_error.result:
        Added tests for better coverage
      mysql-test/suite/parts/inc/partition_engine.inc:
        Bug#31931: Mix of handlers error message
        
        Bug#33722 is fixed within this patch too
      mysql-test/suite/parts/r/partition_engine_innodb.result:
        Bug#31931: Mix of handlers error message
        
        Bug#33722 is fixed within this patch too
      mysql-test/suite/parts/r/partition_engine_myisam.result:
        Bug#31931: Mix of handlers error message
        
        Bug#33722 is fixed within this patch too
      mysql-test/t/partition.test:
        Added tests for better coverage
      mysql-test/t/partition_datatype.test:
        Added tests for better coverage
      mysql-test/t/partition_error.test:
        Added tests for Bug#31931
      sql/partition_info.cc:
        Bug#31931: Mix of handlers error message
        
        Fixed case where given info->db_type not matched
        thd->lex->create_info.db_type
        
        And the check for inconsistent subpartition engines-clauses.
      sql/sql_partition.cc:
        Changed ha_legacy_type to ha_resolve_storage_engine_name
      sql/sql_table.cc:
        Changed ha_legacy_type to ha_resolve_storage_engine_name
      db9b2bdc
  8. 24 Feb, 2008 5 commits
    • unknown's avatar
      Pre push fixes · c37fdbcd
      unknown authored
      Test file fixes for bugs 20129, 31931 and 34225
      
      
      mysql-test/suite/parts/r/partition_basic_symlink_innodb.result:
        Manual merge, new test case to be modified for Bug#20129
      mysql-test/suite/parts/r/partition_basic_symlink_myisam.result:
        Manual merge, new test case to be modified for Bug#20129
      mysql-test/suite/parts/r/partition_engine_innodb.result:
        Manual merge, fix for bug#31931
      mysql-test/suite/parts/r/partition_engine_myisam.result:
        Manual merge, fix for bug#31931
      mysql-test/suite/parts/t/disabled.def:
        These should work now since Bug#34225 is fixed
      sql/ha_partition.cc:
        Bug#20129: partition maintenance command not working with crashed tables
        
        Fix for compiler warnings.
      c37fdbcd
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/mysql-5.1-bug20129.2 · 8144fd1a
      unknown authored
      into  witty.:/Users/mattiasj/clones/topush-51
      
      
      mysql-test/r/partition.result:
        Auto merged
      mysql-test/suite/parts/t/disabled.def:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      sql/sql_partition.cc:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Manual merge
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Manual merge
      mysql-test/suite/parts/r/partition_engine_innodb.result:
        Manual merge
      mysql-test/suite/parts/r/partition_engine_myisam.result:
        Manual merge
      8144fd1a
    • unknown's avatar
      Merge witty.:/Users/mattiasj/clones/mysql-5.1-bug31931.2 · 1864caea
      unknown authored
      into  witty.:/Users/mattiasj/clones/topush-51
      
      
      mysql-test/r/partition.result:
        Auto merged
      mysql-test/suite/ndb/r/ndb_partition_key.result:
        Auto merged
      mysql-test/suite/ndb/t/ndb_partition_key.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      sql/sql_partition.cc:
        Auto merged
      sql/partition_info.cc:
        SCCS merged
      1864caea
    • unknown's avatar
      Merge mysql.com:/home/ram/work/mysql-5.0-engines · 197b4119
      unknown authored
      into  mysql.com:/home/ram/work/b33304/b33304.5.0
      
      
      197b4119
    • unknown's avatar
      Merge mysql.com:/home/ram/work/mysql-5.1-engines · 86bad436
      unknown authored
      into  mysql.com:/home/ram/work/b33304/b33304.5.1
      
      
      86bad436
  9. 22 Feb, 2008 1 commit
    • unknown's avatar
      BUG#13861 - START SLAVE UNTIL may stop 1 evnt too late if · fea2a5d8
      unknown authored
                  log-slave-updates and circul repl
      
      Slave SQL thread may execute one extra event when there are events
      skipped by slave I/O thread (e.g. originated by the same server).
      Whereas it was requested not to do so by the UNTIL condition.
      
      This happens because we compare with the end position of previously
      executed event. This is fine when there are no skipped by slave I/O
      thread events, as end position of previous event equals to start
      position of to be executed event. Otherwise this position equals to
      start position of skipped event.
      
      This is fixed by:
      - reading the event to be executed before checking if the until condition
        is satisfied.
      - comparing the start position of the event to be executed. Since we do
        not have the start position available, we compute it by subtracting
        event length from end position (which is available).
      - if there are no events on the event queue at the slave sql starting
        time, that meet until condition, we stop immediately, as in this
        case we do not want to wait for next event.
      
      
      mysql-test/r/rpl_dual_pos_advance.result:
        A test case for BUG#13861.
      mysql-test/t/rpl_dual_pos_advance.test:
        A test case for BUG#13861.
      sql/log_event.cc:
        Store length of event. This is needed for further calculation of
        the beginning of event.
      sql/slave.cc:
        Slave SQL thread may execute one extra event when there are events
        skipped by slave I/O thread (e.g. originated by the same server).
        Whereas it was requested not to do so by the UNTIL condition.
        
        This happens because we compare with the end position of previously
        executed event. This is fine when there are no skipped by slave I/O
        thread events, as end position of previous event equals to start
        position of to be executed event. Otherwise this position equals to
        start position of skipped event.
        
        This is fixed by:
        - reading the event to be executed before checking if the until condition
          is satisfied.
        - comparing the start position of the event to be executed. Since we do
          not have the start position available, we compute it by subtracting
          event length from end position (which is available).
        - if there are no events on the event queue at the slave sql starting
          time, that meet until condition, we stop immediately, as in this
          case we do not want to wait for next event.
      sql/slave.h:
        Added master_log_pos parametr to is_until_satisfied().
      mysql-test/t/rpl_dual_pos_advance-slave.opt:
        New BitKeeper file ``mysql-test/t/rpl_dual_pos_advance-slave.opt''
      fea2a5d8
  10. 21 Feb, 2008 3 commits
  11. 20 Feb, 2008 2 commits
  12. 19 Feb, 2008 5 commits
    • unknown's avatar
      backport valgrind cleanups from 6.0-engines · 40089da1
      unknown authored
      
      mysql-test/valgrind.supp:
        silence valgrind warning of memory leak in dlopen
      strings/strmake.c:
        silence valgrind warning cause by strlen examining unset bytes.
      40089da1
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p1-bug34598.2 · 53fe1435
      unknown authored
      into  xiphis.org:/anubis/antony/work/p1-bug34598.2.merge.1
      
      
      sql/sql_plugin.cc:
        Auto merged
      53fe1435
    • unknown's avatar
      Bug#34598 · a1915039
      unknown authored
        "crash on hpita: Invalid address alignment"
        Replace dangerous pointer arithmetic - it may occurr where sizeof(int) is
        less than size of machine alignment requirement.
      
      
      include/mysql/plugin.h:
        bug34598
          change of update func prototype
      sql/sql_plugin.cc:
        bug34598
          Avoid dangerous pointer arithmetic which can cause unaligned word access.
          Change of update function prototype
      a1915039
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.1 · ded39d5a
      unknown authored
      into  poseidon.bredbandsbolaget.se:/home/tomas/mysql-5.1-new-ndb-merge
      
      
      ded39d5a
    • unknown's avatar
      BUG#34289 - Incorrect NAME_CONST substitution in stored procedures · f802cd51
      unknown authored
                  breaks replication
      
      NAME_CONST() didn't replicate constant character set and collation
      correctly.
      
      With this fix NAME_CONST() inherits collation from the value argument.
      
      
      mysql-test/r/func_misc.result:
        A test case for BUG#34289.
      mysql-test/t/func_misc.test:
        A test case for BUG#34289.
      sql/item.cc:
        Inherit collation from value argument.
      f802cd51
  13. 16 Feb, 2008 1 commit
  14. 15 Feb, 2008 5 commits
  15. 14 Feb, 2008 2 commits