1. 12 Nov, 2013 2 commits
    • Venkatesh Duggirala's avatar
      Bug#17641586 INCORRECTLY PRINTED BINLOG DUMP INFORMATION · e0efc2c3
      Venkatesh Duggirala authored
      Problem:
      When log_warnings is greater than 1, master prints binlog
      dump thread information in mysqld.1.err file.
      The information contains slave server id, binlog file and
      binlog position. The slave server id is uint32 and the print
      format was wrongly specifified (%d instead of %u).
      Hence a server id which is more than 2 billion is getting
      printed with a negative value.
      Eg: Start binlog_dump to slave_server(-1340259414),
      pos(mysql-bin.001663, 325187493)
      
      Fix: Changed the uint32 format to %u.
      e0efc2c3
    • mithun's avatar
      Bug #14057034 : WASTED CPU CYCLES IN MY_UTF8_UNI WHERE · 7c9112b9
      mithun authored
                      RESULTING MY_WC_T RESULT IS NOT USED
      Issue         : handler functions my_ismbchar_utf8,
                    my_well_formed_len_mb for charset utf8
                    is calling unicode converion function
                    to validate and to find the character
                    length. Because of this, instructions
                    which will convert the utf8 to unicode
                    are executed for no use.
                    A similar issue exist with charset utf8mb4
      Solution      : reorganized the code such that character
                    validation part of unicode conversion
                    handler is extracted(duplicated) in to
                    separate function. Hence
                    my_ismbchar_utf8, my_well_formed_len_mb
                    will call the new function which only
                    validates and return the length of mb(utf8).
                    A similar fix for charset utf8mb4.
      
      strings/ctype-utf8.c:
        New functions has been added for charset utf8 and utf8mb4
        to validate and to get the length of the character.
      7c9112b9
  2. 07 Nov, 2013 4 commits
    • Christopher Powers's avatar
      Bug#17702677 WRONG INSTRUMENTATION INTERFACE FOR MYSQL_COND_TIMEDWAIT · 4189e05c
      Christopher Powers authored
      Fix Windows build break
      4189e05c
    • Marc Alff's avatar
      Push to mysql-5.5 · 51efb2e0
      Marc Alff authored
      51efb2e0
    • Sujatha Sivakumar's avatar
      Bug#16736412: THE SERVER WAS CRASHED WHILE EXECUTING · 81fd7f8a
      Sujatha Sivakumar authored
      "SHOW BINLOG EVENTS"
      
      Fixing post push test issue. 
      Changing the debug simulation.
      81fd7f8a
    • Neeraj Bisht's avatar
      Bug#16691598 - ORDER BY LOWER(COLUMN) PRODUCES OUT-OF-ORDER RESULTS · 88680a99
      Neeraj Bisht authored
      Problem:-
      We have created a table with UTF8_BIN collation.
      In case, when in our query we have ORDER BY clause over a function 
      call we are getting result in incorrect order.
      Note:the bug is not there in 5.5.
      
      Analysis:
      In 5.5, for UTF16_BIN, we have min and max multi-byte length is 2 and 4 
      respectively.In make_sortkey(),for 2 byte character character we are 
      assuming that the resultant length will be 2 byte/character. But when we 
      use my_strnxfrm_unicode_full_bin(), we store sorting weights using 3 bytes 
      per character.This result in truncated result.
      
      Same thing happen for UTF8MB4, where we have 1 byte min multi-byte and 
      4 byte max multi-byte.We will accsume resultant data as 1 byte/character, 
      which result in truncated result.
      
      Solution:-
      use strnxfrm(means use of MY_CS_STRNXFRM macro) is used for sort, in 
      which the resultant length is not dependent on source length.
      88680a99
  3. 06 Nov, 2013 3 commits
    • unknown's avatar
      No commit message · e6949c24
      unknown authored
      No commit message
      e6949c24
    • Sujatha Sivakumar's avatar
      Bug#16736412: THE SERVER WAS CRASHED WHILE EXECUTING · 2a2641ad
      Sujatha Sivakumar authored
      "SHOW BINLOG EVENTS"
      
      Problem:
      ========
      mysql was crashed after executing "show binlog events in
      'mysql-bin.000005' from 99", the crash happened randomly.
      
      Analysis:
      ========
      During construction of LOAD EVENT or NEW LOAD EVENT object
      if the starting offset is provided as incorrect value then
      all the object members that are retrieved from the offset
      are also invalid.  Some times it will lead to out of bound
      address offsets.  In the bug scenario, the file name is
      extracrated from an invalid address and the same is fed to
      strlen(fname) function. Passing invalid address to strlen
      will lead to crash.
      
      Fix:
      ===
      Validate if the given offset falls within the event boundary
      or not.
      
      sql/log_event.cc:
        Added code to validate fname's address. "fname" should
        be within event boundary. Added code to find invalid
        invents.
      2a2641ad
    • Marc Alff's avatar
      Bug#17702677 WRONG INSTRUMENTATION INTERFACE FOR MYSQL_COND_TIMEDWAIT · 63819ccb
      Marc Alff authored
      The pthread_cond_timedwait(3P) api
      uses a const struct timespec for parameter 3.
      
      The instrumentation api for the same, mysql_cond_timedwait,
      which expands to inline_mysql_cond_timedwait,
      should also take a const parameter for the timespec.
      
      This fix add the missing const to inline_mysql_cond_timedwait.
      63819ccb
  4. 05 Nov, 2013 2 commits
    • Aditya A's avatar
      Bug#17588348: INDEX MERGE USED ON PARTITIONED TABLE · 5f83a7fb
      Aditya A authored
                     CAN RETURN WRONG RESULT SET
      
      PROBLEM
      -------
      In ha_partition::cmp_ref() we were only calling the 
      underlying cmp_ref() of storage engine if the records
      are in the same partiton,else we sort by partition and
      returns the result.But the index merge intersect 
      algorithm expects first to sort by row-id first and 
      then by partition id.
      
      FIX
      ---
      Compare the refernces first using storage engine cmp_ref
      and then if references are equal(only happens if 
      non clustered index is used) then sort it by partition id.
      
      [Approved by Mattiasj #rb3755]
      -
      5f83a7fb
    • Tor Didriksen's avatar
      Bug#12368495 CRASH AND/OR VALGRIND ERRORS WITH REVERSE FUNCTION AND CHARSET CONVERTS · 7ad0e1c5
      Tor Didriksen authored
      Item_func_trim::val_str: we were using the non-mb algorithm for skipping leading spaces
      in a multibyte-charset string.
      7ad0e1c5
  5. 04 Nov, 2013 4 commits
  6. 01 Nov, 2013 3 commits
  7. 31 Oct, 2013 5 commits
    • unknown's avatar
      No commit message · 8f705054
      unknown authored
      No commit message
      8f705054
    • unknown's avatar
      No commit message · e87a37a2
      unknown authored
      No commit message
      e87a37a2
    • Venkata Sidagam's avatar
      Bug #12917164 DROP USER CAN'T DROP USERS WITH LEGACY · 186a9fc7
      Venkata Sidagam authored
          UPPER CASE HOST NAME ANYMORE
      Merging from mysql-5.1 to mysql-5.5
      186a9fc7
    • Venkata Sidagam's avatar
      Bug #12917164 DROP USER CAN'T DROP USERS WITH LEGACY · 19990c92
      Venkata Sidagam authored
          UPPER CASE HOST NAME ANYMORE
      
      Description:
      It is not possible to drop users with host names with upper case
      letters in them. i.e DROP USER 'root'@'Tmp_Host_Name'; is failing
      with error.
      
      Analysis: Since the fix 11748570 we came up with lower case hostnames
      as standard. But in the current bug the hostname is created by
      mysql_install_db script is still having upper case hostnames. 
      So, if we have the hostname with upper case letters like(Tmp_Host_Name)
      then we will have as it is stored in the mysql.user table. 
      In this case if use "'DROP USER 'root'@'Tmp_Host_Name';" it gives 
      error because we do compare with the lower case of hostname since the 
      11748570 fix.
      
      Fix: We need to convert the hostname to lower case before storing into 
      the mysql.user table when we run the mysql_install_db script.
      19990c92
    • unknown's avatar
      No commit message · 6e059fd1
      unknown authored
      No commit message
      6e059fd1
  8. 30 Oct, 2013 2 commits
  9. 29 Oct, 2013 3 commits
  10. 28 Oct, 2013 1 commit
  11. 25 Oct, 2013 2 commits
  12. 21 Oct, 2013 2 commits
    • Jon Olav Hauglid's avatar
      Bug#17632386: WITH_ASAN CONFLICTS WITH -WL,--NO-UNDEFINED · 63a205d4
      Jon Olav Hauglid authored
      -Wl,--no-undefined (=-z defs) gives linking errors when used with WITH_ASAN.
      According to the documentation:
      "When linking shared libraries, the AddressSanitizer run-time is not linked,
      so -Wl,-z,defs may cause link errors (don’t use it with AddressSanitizer)."
      
      This patch turns off -Wl,--no-undefined if WITH_ASAN is used.
      63a205d4
    • Aditya A's avatar
      Bug #16051817 GOT ERROR 124 FROM STORAGE ENGINE · c5896384
      Aditya A authored
                     ON DELETE FROM A PARTITIONED TABLE
      
      PROBLEM
      -------
      
      The user first disables all the non unique indexes
      in the table and then rebuilds one partition.
      During rebuild the indexes on that particular
      partition are enabled. Now when we give a query 
      the optimizer is unaware that on one partition 
      indexes are enabled and if the optimizer selects
      that index,myisam thinks that the index is not 
      active and gives an error.
      
      FIX
      ---
      
      Before rebuilding a partition check whether non
      unique indexes are disabled on the partitons.
      If they are disabled then after rebuild disable
      the index on the partition. 
      
      [Approved by Mattiasj #rb3469]
      c5896384
  13. 19 Oct, 2013 1 commit
  14. 18 Oct, 2013 6 commits
    • Mattias Jonsson's avatar
      post-push fix for bug17565888. · a91fcaf4
      Mattias Jonsson authored
      Too restrictive assertion, failing during purge
      a91fcaf4
    • Mattias Jonsson's avatar
      post-push fix for bug17565888. · e6a734a7
      Mattias Jonsson authored
      Too restrictive assertion, can fail during purge
      e6a734a7
    • Mattias Jonsson's avatar
      Bug#17565888: UP TO 75% INCREASE IN DBT3 QUERY (Q7) EXECUTION TIME · 20f579ea
      Mattias Jonsson authored
      Regression from bug#14621190 due to disabled optimistic restoration
      of cursor, which required full key lookup instead of verifying
      if previously positioned btree cursor could be reused.
      
      Fixed by enable optimistic restore and adjust cursor afterward.
      
      rb#3324 approved by Marko.
      20f579ea
    • Anirudh Mangipudi's avatar
      Bug #17357535 BACKPORT BUG#16241992 TO 5.5 · 18079ac9
      Anirudh Mangipudi authored
      Problem:
      COM_CHANGE_USER allows brute-force attempts to crack a password at a very high
      rate as it does not cause any significant delay after a login attempt has
      failed. This issue was reproduced using John-The-Ripper password
      cracking tool through which about 5000 passwords per second could be attempted.
      
      Solution:
      The non-GA version's solution was to disconnect the connection when a login
      attempt failed. Now since our aim to to reduce the rate at which passwords 
      are tested, we introduced a sleep(1) after every login attempt failed. This
      significantly increased the delay with which the password was cracked.
      18079ac9
    • Luis Soares's avatar
      BUG#17460821 · 6fd6b38c
      Luis Soares authored
      Automerged from mysql-5.5 bug branch into latest mysql-5.5.
      6fd6b38c
    • Aditya A's avatar
      Bug#17559867 AFTER REBUILDING , A MYISAM PARTITION ENDS UP · 94630ddd
      Aditya A authored
                   AS A INNODB PARTITTION.
      [Merged from 5.1]             
      94630ddd