1. 14 Nov, 2007 1 commit
  2. 12 Nov, 2007 9 commits
  3. 10 Nov, 2007 2 commits
  4. 08 Nov, 2007 2 commits
  5. 07 Nov, 2007 2 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/build/50 · 3a7e070f
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/b20748/50
      
      
      include/my_sys.h:
        Auto merged
      3a7e070f
    • unknown's avatar
      Bug #20748: Configuration files should not be read more than once · 707f42a6
      unknown authored
      A user could not override system-wide settings in their ~/.my.cnf,
      because the DEFAULT_SYSCONFDIR was being searched last.  Also, in
      some configurations (especially when the --sysconfdir compile-time
      option is set to /etc or /etc/mysql), the system-wide my.cnf file
      was read multiple times, causing confusion and potential problems.
      
      Rearrange default directories to conform to the manual and logic.
      Move --sysconfdir=<path> (DEFAULT_SYSCONFDIR) from the last default
      directory to the middle of the list.  $HOME/.my.cnf should be last,
      so the user is able to override the system-wide settings.
      
      Change init_default_directories() to remove duplicates from the
      list.
      
      
      include/my_sys.h:
        Add array_append_string_unique(), from mf_arr_appstr.c
      libmysql/Makefile.shared:
        Add new mf_arr_appstr.lo object
      mysys/CMakeLists.txt:
        Add new mf_arr_appstr.c source.
      mysys/Makefile.am:
        Add new mf_arr_appstr.c source.
      mysys/default.c:
        Change order in which defaults files are added to default_directories,
        in order to conform to the manual (and to common sense).  This fixes
        a particularly bad problem on Unix, where ~/.my.cnf was read before
        /usr/local/etc/my.cnf.
        
        Also, don't add duplicate entries; move the existing entry to the
        end of the list instead.
        
        
        Here is a comparison of the order of defaults files, BEFORE and AFTER
        this patch.
        
        On Windows:
        
        BEFORE:  C:\, GetWindowsDirectory(), GetSystemWindowsDirectory(),
                 $MYSQL_HOME, defaults-extra-file, INSTALLDIR
        
        AFTER:  GetSystemWindowsDirectory(), GetWindowsDirectory(), C:\,
                INSTALLDIR, $MYSQL_HOME, defaults-extra-file
        
        GetSystemWindowsDirectory() is moved before GetWindowsDirectory() because
        the former is shared by all Terminal Services users, while the latter is
        private for each user.
        
        
        On Netware (no change):
        
        BEFORE:  sys:/etc/, $MYSQL_HOME, defaults-extra-file
        
        AFTER:  sys:/etc, $MYSQL_HOME, defaults-extra-file
        
        
        On OS/2:
        
        BEFORE:  $ETC, /etc, $MYSQL_HOME, defaults-extra-file
        
        AFTER:  /etc, $ETC, $MYSQL_HOME, defaults-extra-file
        
        
        On everything else (general Unix):
        
        BEFORE:  /etc, $MYSQL_HOME, defaults-extra-file, ~/, --sysconfdir
        
        AFTER:  /etc/, --sysconfdir, $MYSQL_HOME, defaults-extra-file, ~/
        
        The BEFORE code added --sysconfdir on all systems, but only the
        Unix build system actually defined a value for it.
      mysys/mf_arr_appstr.c:
        BitKeeper file /home/tsmith/m/bk/build/50-b20748/mysys/mf_arr_appstr.c
      707f42a6
  6. 06 Nov, 2007 5 commits
    • unknown's avatar
      BUG#32111 - Security Breach via DATA/INDEX DIRECORY and RENAME TABLE · ff4b438b
      unknown authored
      RENAME TABLE against a table with DATA/INDEX DIRECTORY overwrites
      the file to which the symlink points.
      
      This is security issue, because it is possible to create a table with
      some name in some non-system database and set DATA/INDEX DIRECTORY
      to mysql system database. Renaming this table to one of mysql system
      tables (e.g. user, host) would overwrite the system table.
      
      Return an error when the file to which the symlink points exist.
      
      
      mysql-test/r/symlink.result:
        A test case for BUG#32111.
      mysql-test/t/symlink.test:
        A test case for BUG#32111.
      mysys/my_symlink2.c:
        Return an error when the file to which the symlink points exist.
      ff4b438b
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 85425773
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      85425773
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 1a359e14
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      1a359e14
    • unknown's avatar
      Bug#4692 - DISABLE/ENABLE KEYS waste a space · 42829c61
      unknown authored
      Disabling and enabling indexes on a non-empty table grows the
      index file.
      
      Disabling indexes just sets a flag per non-unique index and does not
      free the index blocks of the affected indexes. Re-enabling indexes
      creates new indexes with new blocks. The old blocks remain unused
      in the index file.
      
      Fixed by dropping and re-creating all indexes if non-empty disabled
      indexes exist when enabling indexes. Dropping all indexes resets
      the internal end-of-file marker to the end of the index file header.
      It also clears the root block pointers of every index and clears the
      deleted blocks chains. This way all blocks are declared as free.
      
      
      myisam/mi_check.c:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added function mi_drop_all_indexes() to support drop of all indexes
        in case we want to re-enable non-empty disabled indexes.
        Changed mi_repair(), mi_repair_by_sort(), and mi_repair_parallel()
        to use the new function instead of duplicate drop index code.
      mysql-test/r/myisam.result:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test result.
      mysql-test/t/myisam.test:
        Bug#4692 - DISABLE/ENABLE KEYS waste a space
        Added test.
      42829c61
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 0c185254
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG31950/mysql-5.0-engines
      
      
      0c185254
  7. 05 Nov, 2007 4 commits
  8. 02 Nov, 2007 15 commits