1. 16 Nov, 2006 1 commit
    • unknown's avatar
      BUG#17047: CHAR() and IN() can return NULL without signaling NULL result · e40e8052
      unknown authored
      The problem was that some functions (namely IN() starting with 4.1, and
      CHAR() starting with 5.0) were returning NULL in certain conditions,
      while they didn't set their maybe_null flag.  Because of that there could
      be some problems with 'IS NULL' check, and statements that depend on the
      function value domain, like CREATE TABLE t1 SELECT 1 IN (2, NULL);.
      
      The fix is to set maybe_null correctly.
      
      
      mysql-test/r/func_in.result:
        Add result for bug#17047: CHAR() and IN() can return NULL without
        signaling NULL result.
      mysql-test/t/func_in.test:
        Add test case for bug#17047: CHAR() and IN() can return NULL without
        signaling NULL result.
      sql/item_cmpfunc.cc:
        Remove assignment to maybe_null, as it was already set in fix_fields()
        based on all arguments, not only on the first.
      e40e8052
  2. 01 Nov, 2006 1 commit
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 2886e07d
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      2886e07d
  3. 30 Oct, 2006 2 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-runtime · 49c9509a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug21915
      
      
      49c9509a
    • unknown's avatar
      BUG#21915: Changing limits of table_cache when setting max_connections · 885dc1cb
      unknown authored
      If the user has specified --max-connections=N or --table-open-cache=M
      options to the server, a warning could be given that some values were
      recalculated, and table-open-cache could be assigned greater value.
      
      Note that both warning and increase of table-open-cache were totally
      harmless.
      
      This patch fixes recalculation code to ensure that table-open-cache will
      be never increased automatically and that a warning will be given only if
      some values had to be decreased due to operating system limits.
      
      No test case is provided because we neither can't predict nor control
      operating system limits for maximal number of open files.
      
      
      sql/mysql_priv.h:
        Add constants for table_cache minimum and default values.
      sql/mysqld.cc:
        Fix max_connections and table_cache_size re-computation.
      885dc1cb
  4. 27 Oct, 2006 4 commits
  5. 25 Oct, 2006 9 commits
  6. 23 Oct, 2006 2 commits
  7. 20 Oct, 2006 4 commits
    • unknown's avatar
      ndb - bug#23499 and bug#23502 · 9070859e
      unknown authored
        Fix some too small buffers in backup
        
      
      
      ndb/include/kernel/ndb_limits.h:
        backport for 5.1
        add MAX_WORDS_META_FILE for computing Backup::NO_OF_PAGES_META_FILE
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Make sure to set maxInsert so that we actually can handle NO_OF_META_PAGES
      ndb/src/kernel/blocks/backup/Backup.hpp:
        backport for 5.1
        add MAX_WORDS_META_FILE for computing Backup::NO_OF_PAGES_META_FILE
      9070859e
    • unknown's avatar
      ndb - · b81cc9c3
      unknown authored
        Fixed a 4.1/5.0 vs. 5.1 name change in latest SR bug fix
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Fixed a 4.1/5.0 vs. 5.1 name change in latest SR bug fix
      b81cc9c3
    • unknown's avatar
      ndb - · 608e9207
      unknown authored
        Fix monster SR bug making SR with ordered indexes (or temporary tables) broken
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Fix monster SR bug making SR with ordered indexes (or temporary tables) broken
      608e9207
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 0153d67e
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      0153d67e
  8. 19 Oct, 2006 6 commits
  9. 18 Oct, 2006 3 commits
    • unknown's avatar
      ndb - bug#23200 · 1028185a
      unknown authored
        Make sure postExecute is not run for blobs if AO_IgnoreError
      
      
      ndb/src/ndbapi/NdbConnection.cpp:
        If AO_IgnoreError, error codes arent always set on individual operations, making postExecute impossible
      1028185a
    • unknown's avatar
      Merge mysql.com:/windows/Linux_space/MySQL/mysql-4.1 · 364cda0a
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-4.1-ndb
      
      
      mysql-test/r/ndb_update.result:
        Auto merged
      364cda0a
    • unknown's avatar
      BUG#23175 - MYISAM crash/repair failed during repair · 48cf65c0
      unknown authored
      Repair table could crash a server if there is not sufficient
      memory (myisam_sort_buffer_size) to operate. Affects not only
      repair, but also all statements that use create index by sort:
      repair by sort, parallel repair, bulk insert.
      
      Return an error if there is not sufficient memory to store at
      least one key per BUFFPEK.
      
      Also fixed memory leak if thr_find_all_keys returns an error.
      
      
      myisam/sort.c:
        maxbuffer is number of BUFFPEK-s for repair. It is calculated
        as records / keys. keys is number of keys that can be stored
        in memory (myisam_sort_buffer_size). There must be sufficient
        memory to store both BUFFPEK-s and keys. It was checked
        correctly before this patch. However there is another
        requirement that wasn't checked: there must be sufficient
        memory for at least one key per BUFFPEK, otherwise repair
        by sort/parallel repair cannot operate.
        
        Return an error if there is not sufficient memory to store at
        least one key per BUFFPEK.
        
        Also fixed memory leak if thr_find_all_keys returns an error.
      mysql-test/r/repair.result:
        A test case for BUG#23175.
      mysql-test/t/repair.test:
        A test case for BUG#23175.
      48cf65c0
  10. 17 Oct, 2006 2 commits
  11. 16 Oct, 2006 3 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 53924bdc
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/B14019-4.1-opt
      
      
      53924bdc
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1--team · 29929bb6
      unknown authored
      into  chilla.local:/home/mydev/mysql-4.1-bug12240
      
      
      29929bb6
    • unknown's avatar
      BUG#14019 : group by converts literal string to column name · 750a2a0b
      unknown authored
         When resolving unqualified name references MySQL was not
         checking what is the item type for the reference. Thus
         e.g a string literal item that has by convention a name
         equal to its string value will also work as a reference to 
         a SELECT list item or a table field.
         Fixed by allowing only Item_ref or Item_field to referenced by
         (unqualified) name.
      
      
      mysql-test/r/func_gconcat.result:
        Bug #14019: group by converts literal string to column name
         - removed undeterministic testcase : order by a constant 
           means no order.
      mysql-test/r/group_by.result:
        Bug #14019: group by converts literal string to column name
         - test case
      mysql-test/t/func_gconcat.test:
        Bug #14019: group by converts literal string to column name
         - removed undeterministic testcase : order by a constant 
           means no order.
      mysql-test/t/group_by.test:
        Bug #14019: group by converts literal string to column name
         - test case
      sql/sql_base.cc:
        Bug #14019: group by converts literal string to column name
         - resolve unqualified by name refs only for real references
      750a2a0b
  12. 13 Oct, 2006 2 commits
  13. 12 Oct, 2006 1 commit
    • unknown's avatar
      ndb - bug#23210 · 855c4e06
      unknown authored
        Fix race-condition between COPY_GCIREQ (GCP) and lcpSetActiveStatusEnd
        Solution is _not_ to copy sysfileData from COPY_GCIREQ from "self"
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        Add error insert for dealying of copy sysfileData
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        1) Add error insert for delaying of sysfileData
        2) Change to that master is _not_ copying sysfileData from COPY_GCIREQ
           as it might be updating it while COPY_GCIREQ is "in the fly"
      855c4e06