1. 09 Jan, 2007 3 commits
    • unknown's avatar
      Merge moonlight.home:/home/tomash/src/mysql_ab/mysql-4.1-runtime · e5c1d478
      unknown authored
      into  moonlight.home:/home/tomash/src/mysql_ab/mysql-4.1-bug23443
      
      
      e5c1d478
    • unknown's avatar
      Merge moonlight.home:/home/tomash/src/mysql_ab/mysql-4.0-bug23443 · beac4a6f
      unknown authored
      into  moonlight.home:/home/tomash/src/mysql_ab/mysql-4.1-bug23443
      
      
      heap/hp_block.c:
        Auto merged
      sql/item_func.cc:
        Auto merged
      heap/hp_write.c:
        Manual merge.
      beac4a6f
    • unknown's avatar
      BUG#23443: user-defined variables can consume too much memory in the · 4fe1561f
      unknown authored
                 server
      
      The problem was that when memory was exhausted HEAP engine could crash
      (GROUP BY uses HEAP TABLE).  Alternatively, if SET was used, it could
      report an error "You may only use constant expressions with SET" instead
      of "Out of memory (Needed NNNNNN bytes)".
      
      The solution is:
       - pass MY_WME to (some) calls to my_malloc() to get correct message.
       - fix heap_write() so that the first key is skipped during cleanup
         on ENOMEM because it wasn't inserted and doesn't have to be
         deleted.
      
      No test case is provided because we can't test out-of-memory behaviour
      in our current test framework.
      
      
      heap/hp_block.c:
        If allocation fails, write an error message.
      heap/hp_write.c:
        On ENOMEM, skip the first key in cleanup, as it wasn't inserted yet.
      sql/item_func.cc:
        Add MY_WME so that OOM error will be reported.
      4fe1561f
  2. 30 Nov, 2006 1 commit
  3. 29 Nov, 2006 6 commits
  4. 28 Nov, 2006 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 760bd9d1
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-4.1-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      760bd9d1
    • unknown's avatar
      Makefile.am: · 0fb76499
      unknown authored
        If using \$(srcdir)/mysql.info in action, use same in rule.
      
      
      Docs/Makefile.am:
        If using \$(srcdir)/mysql.info in action, use same in rule.
      0fb76499
  5. 27 Nov, 2006 3 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · eb63927c
      unknown authored
      into  mysql.com:/home/kent/bk/mysql-4.1-merge
      
      
      eb63927c
    • unknown's avatar
      Makefile.am: · f53733db
      unknown authored
        BSD compatibility
      
      
      Docs/Makefile.am:
        BSD compatibility
      f53733db
    • unknown's avatar
      gen_rec.awk: · 8d6f67f3
      unknown authored
        Fix undefined behaviour.
      Many files:
        Reenabled build outside ource tree
      
      
      bdb/dist/gen_rec.awk:
        Fix undefined behaviour.
      acinclude.m4:
        Reenabled build outside ource tree
      configure.in:
        Reenabled build outside ource tree
      libmysql_r/Makefile.am:
        Reenabled build outside ource tree
      libmysqld/Makefile.am:
        Reenabled build outside ource tree
      ndb/config/common.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_kernel.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapi.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapitest.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_ndbapitools.mk.am:
        Reenabled build outside ource tree
      ndb/config/type_util.mk.am:
        Reenabled build outside ource tree
      ndb/src/kernel/Makefile.am:
        Reenabled build outside ource tree
      8d6f67f3
  6. 24 Nov, 2006 1 commit
    • unknown's avatar
      fixes for mtr_unique.pl · 6de6b97e
      unknown authored
      
      mysql-test/lib/mtr_unique.pl:
        - add info message to mtr_require_unique_id_and_wait as suggested
        - fix for security issue
        - locks for pids of processes that don't exist anymore are reused, if ps is present and working as expected
      6de6b97e
  7. 22 Nov, 2006 3 commits
    • unknown's avatar
      Cleanup: remove const. · a7aecabc
      unknown authored
      a7aecabc
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-runtime · 33d63bec
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug21635
      
      
      tests/mysql_client_test.c:
        Manual merge.
      33d63bec
    • unknown's avatar
      BUG#21635: MYSQL_FIELD struct's member strings seem to misbehave for · 18770d2f
      unknown authored
      expression cols.
      
      The problem was that MYSQL_FIELD::org_name was set for MIN() and MAX()
      functions (COUNT() is also mentioned in the bug report but was already
      fixed).
      
      After this patch for expressions MYSQL_FIELD::name is set to either
      expression itself or its alias, and other data origin fields of
      MYSQL_FILED (db, org_table, table, org_name) are empty strings.
      
      
      sql/item_sum.cc:
        For expressions only col_name should be non-empty string.
      tests/mysql_client_test.c:
        Add test case for bug#21635: MYSQL_FIELD struct's member strings seem
        to misbehave for expression cols.
      18770d2f
  8. 21 Nov, 2006 2 commits
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-runtime · 75432f3f
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug23159
      
      
      75432f3f
    • unknown's avatar
      BUG#23159: prepared_stmt_count should be status variable · 7a45fb54
      unknown authored
      Make Prepared_stmt_count a global status variable, accessible via
      SHOW STATUS LIKE 'Prepared_stmt_count';.  Documentation should be
      updated.
      
      
      mysql-test/r/ps.result:
        Update result for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      mysql-test/t/ps.test:
        Update test case for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      sql/mysqld.cc:
        Add Prepared_stmt_count as global status variable.
      sql/set_var.cc:
        Remove prepared_stmt_count as system variable.
      7a45fb54
  9. 17 Nov, 2006 4 commits
    • unknown's avatar
      MTR_BUILD_THREAD=auto selects a value for MTR_BUILD_THREAD from a pool (WL#2690) · c3d6927d
      unknown authored
      
      mysql-test/lib/mtr_unique.pl:
        Library file used by mysql-test-run.pl to determine unique test run identifiers.
      c3d6927d
    • unknown's avatar
      ABI fix · a3d04155
      unknown authored
      
      include/mysql_h.ic:
        this one should actually be removed from the ABI
      a3d04155
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-runtime · 07a6c293
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug23383
      
      
      07a6c293
    • unknown's avatar
      BUG#23383: mysql_affected_rows() returns different values than · 2d04b191
      unknown authored
      mysql_stmt_affected_rows()
      
      The problem was that affected_rows for prepared statement wasn't updated
      in the client library on the error.  The solution is to always update
      affected_rows, which will be equal to -1 on the error.
      
      
      libmysql/libmysql.c:
        Update status variables even in the case of an error.  Some variables
        have a defined value on the error (like affected_rows is -1), others are
        undefined, so updating them won't harm.
      libmysqld/lib_sql.cc:
        Update status variables even in the case of an error.  Some variables
        have a defined value on the error (like affected_rows is -1), others are
        undefined, so updating them won't harm.
      tests/mysql_client_test.c:
        Add test for bug#23383: mysql_affected_rows() returns different values
        than mysql_stmt_affected_rows().
      2d04b191
  10. 16 Nov, 2006 7 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M41/mysql-4.1 · 16599454
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      
      16599454
    • unknown's avatar
      merging · e78fd1d1
      unknown authored
      e78fd1d1
    • unknown's avatar
      merging · 83a7bbf7
      unknown authored
      83a7bbf7
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 17c238a1
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1-mrg
      
      
      include/mysql.h:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/rename.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_class.h:
        Auto merged
      Makefile.am:
        merging
      client/mysqltest.c:
        merging
      mysql-test/t/mysql_client.test:
        merging
      17c238a1
    • unknown's avatar
      support-files/mysql.spec.sh : Add an "Obsoletes" note relative to SuSE RPMs (bug#22081). · aa13653a
      unknown authored
      
      support-files/mysql.spec.sh:
        Explicitly note that the "MySQL-shared" RPMs (as built by MySQL AB) replace 
        "mysql-shared" (as distributed by SuSE) to allow easy upgrading (bug#22081).
      aa13653a
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-runtime · db336c05
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-4.1-bug17047
      
      
      db336c05
    • unknown's avatar
      BUG#17047: CHAR() and IN() can return NULL without signaling NULL result · e40e8052
      unknown authored
      The problem was that some functions (namely IN() starting with 4.1, and
      CHAR() starting with 5.0) were returning NULL in certain conditions,
      while they didn't set their maybe_null flag.  Because of that there could
      be some problems with 'IS NULL' check, and statements that depend on the
      function value domain, like CREATE TABLE t1 SELECT 1 IN (2, NULL);.
      
      The fix is to set maybe_null correctly.
      
      
      mysql-test/r/func_in.result:
        Add result for bug#17047: CHAR() and IN() can return NULL without
        signaling NULL result.
      mysql-test/t/func_in.test:
        Add test case for bug#17047: CHAR() and IN() can return NULL without
        signaling NULL result.
      sql/item_cmpfunc.cc:
        Remove assignment to maybe_null, as it was already set in fix_fields()
        based on all arguments, not only on the first.
      e40e8052
  11. 15 Nov, 2006 3 commits
  12. 14 Nov, 2006 2 commits
  13. 13 Nov, 2006 3 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · e56742d7
      unknown authored
      into  rakia.gmz:/home/kgeorge/mysql/autopush/B19216-4.1-opt
      
      
      e56742d7
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-4.1-rpl · 8fd48cce
      unknown authored
      into  mysql.com:/home/bk/MERGE/mysql-4.1-merge
      
      
      8fd48cce
    • unknown's avatar
      Bug #19216: Client crashes on long SELECT · f53af7b8
      unknown authored
       The server sends a number of columns to the client.
       It uses a limited "fast" function for that instead of the
       general one. This fast function cannot send numbers larger 
       than 2 bytes. 
       This causes the client to expect smaller number of columns. 
       The client writes outside of the allocated memory buffer 
       as a result.
       Fixed the server to use the general function to send column
       count.
       Fixed the client to check the column count before writing
       column data. 
      
      
      mysql-test/t/mysql_client.test:
        Bug #19216: Client crashes on long SELECT
         - test case
      sql/protocol.cc:
        Bug #19216: Client crashes on long SELECT
         - renamed the function for bether comprehention
           and made it local
         - used the right (non-local) function to transfer 
           the column count in Protocol::send_fields
      sql/protocol.h:
        Bug #19216: Client crashes on long SELECT
         - made optimized net_store_length local
      sql-common/client.c:
        Bug #19216: Client crashes on long SELECT
         - fixed the client to check for older servers (without the fix).
      f53af7b8