1. 23 Aug, 2004 2 commits
    • unknown's avatar
      Fix for BUG#5033 "When using temporary tables truncate does NOT reset the auto_increment counter" · e9c25d93
      unknown authored
      (ok'd by CTO to fix it in 4.0).
      Fix to make mysql-test-run work with all Valgrind versions.
      
      
      mysql-test/mysql-test-run.sh:
        fixing mysql-test-run.sh so that it works indifferently with Valgrind 1.x, 2.x
        (versions <= 2.0.0 refuse --tool option; versions >=2.1.2 require it; 2.1.0 accepts it).
        I hope the shell code is portable enough; anyway Valgrind only runs on Linux...
        I tested it with 2.0.0, 2.1.0, 2.1.2.
      mysql-test/r/truncate.result:
        result update
      mysql-test/t/truncate.test:
        testing if TRUNCATE resets autoinc counter for temp tables (BUG#5033); testing difference with DELETE FROM.
      sql/sql_delete.cc:
        in mysql_truncate(), always reset the autoinc counter, as manual says (even if it's a temp table, which was BUG#5033).
      e9c25d93
    • unknown's avatar
      unnecessary LINT_INIT removed · 38b8c985
      unknown authored
      38b8c985
  2. 22 Aug, 2004 3 commits
  3. 21 Aug, 2004 1 commit
    • unknown's avatar
      null.test, null.result: · c1fd20bb
      unknown authored
        Added test case for bug #4256.
      join_outer.result:
        Fixed bug #4256.
      item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      
      
      sql/item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      mysql-test/r/join_outer.result:
        Fixed bug #4256.
      mysql-test/r/null.result:
        Added test case for bug #4256.
      mysql-test/t/null.test:
        Added test case for bug #4256.
      c1fd20bb
  4. 20 Aug, 2004 3 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 4f0e2da3
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      4f0e2da3
    • unknown's avatar
      Making FLUSH TABLES WITH READ LOCK block COMMITs of existing transactions, · cd8054d4
      unknown authored
      in a deadlock-free manner. This splits locking the global read lock in two steps.
      This fixes a consequence of this bug, known as:
      BUG#4953 'mysqldump --master-data may report incorrect binlog position if using InnoDB'
      And a test.
      
      
      sql/handler.cc:
        making COMMIT wait if FLUSH TABLES WITH READ LOCK happened.
      sql/lock.cc:
        an additional stage so that FLUSH TABLES WITH READ LOCK blocks COMMIT:
        make_global_read_lock_block_commit():
        taking the global read lock is TWO steps (2nd step is optional; without
        it, COMMIT of existing transactions will be allowed):
        lock_global_read_lock() THEN make_global_read_lock_block_commit().
      sql/mysql_priv.h:
        new argument to wait_if_global_read_lock()
      sql/sql_class.h:
        THD::global_read_lock now an uint to reflect the 2 steps of global read lock (does not block COMMIT / does)
      sql/sql_db.cc:
        update for new prototype
      sql/sql_parse.cc:
        implementing the two steps of global read lock so that FLUSH TABLES WITH READ LOCK can block COMMIT without deadlocking with COMMITs.
      cd8054d4
    • unknown's avatar
      A fix (bug #5115: Erronious Syntax Error when comment placed inside of "create table") · 7c3e8f62
      unknown authored
      
      client/mysql.cc:
        in_comment is now outside the add_line().
      7c3e8f62
  5. 19 Aug, 2004 9 commits
  6. 18 Aug, 2004 4 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · ac866d9e
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      ac866d9e
    • unknown's avatar
      Fix for BUG#4971 "CREATE TABLE ... TYPE=HEAP SELECT ... stops slave (wrong DELETE in binlog)": · 95334ac6
      unknown authored
      replacing the no_log argument of mysql_create_table() by some safer method
      (temporarily setting OPTION_BIN_LOG to 0) which guarantees that even the automatic
      DELETE FROM heap_table does not get into the binlog when a not-yet-existing HEAP table
      is opened by mysql_create_table().
      
      
      mysql-test/r/rpl_heap.result:
        result update
      mysql-test/t/rpl_heap.test:
        testing a bug
      sql/log.cc:
        new class Disable_binlog used to temporarily disable binlogging for one thread.
      sql/mysql_priv.h:
        removing argument no_log from mysql_create_table(); no_log was perfect as some
        binlogging could still be done by open_unireg_entry() for a HEAP table.
      sql/sql_class.h:
        new class Disable_binlog used to temporarily disable binlogging for one thread.
      sql/sql_parse.cc:
        removing no_log
      sql/sql_table.cc:
        removing no_log from mysql_create_table(); instead using new class Disable_binlog.
        Disabling binlogging in some cases, where the binlogging is done later by some other code
        (case of CREATE SELECT and ALTER).
      95334ac6
    • unknown's avatar
      Bug 4937: different date -> string conversion when using · 0c6b9665
      unknown authored
      SELECT ... UNION and INSERT ... SELECT ... UNION
      
      
      0c6b9665
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 8ddcba9d
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      8ddcba9d
  7. 17 Aug, 2004 6 commits
    • unknown's avatar
      srv0start.c, ut0mem.c, ut0dbg.c, ut0dbg.h, srv0start.h: · 0c062ae6
      unknown authored
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      mysqld.cc, ha_innodb.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri) 
      
      
      sql/ha_innodb.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      sql/mysqld.cc:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/include/srv0start.h:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/include/ut0dbg.h:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/ut/ut0dbg.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/ut/ut0mem.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      innobase/srv/srv0start.c:
        Changes for NetWare to exit the InnoDB gracefully instead of crashing the server (patch by PRam@novell.com, polished a little by Heikki Tuuri)
      0c062ae6
    • unknown's avatar
      use my_vsnprintf() just in case · fdc8712c
      unknown authored
      bug#4925
      
      
      fdc8712c
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 35daaa5e
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      35daaa5e
    • unknown's avatar
      Fix for BUG#5073 "--disable-local-infile has no effect if client reads it with MYSQL_READ_DEFAULT": · d13c9acf
      unknown authored
      that was a forgotten '~' probably.
      
      
      libmysql/libmysql.c:
        When we read "disable-local-infile" from the option file specified by mysql_options(MYSQL_READ_DEFAULT_FILE),
        we must take CLIENT_LOCAL_FILES down (it was probably a forgotten '~').
      d13c9acf
    • unknown's avatar
      Merge heikki@build.mysql.com:/home/bk/mysql-4.0 · 0f7bf119
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-4.0
      
      
      0f7bf119
    • unknown's avatar
      A fix (bug #5055: SQL_SELECT_LIMIT=0 crashes command line client): · 1146f38f
      unknown authored
      mysql outwits itself.
      
      
      1146f38f
  8. 16 Aug, 2004 2 commits
  9. 14 Aug, 2004 2 commits
  10. 13 Aug, 2004 4 commits
    • unknown's avatar
      row0mysql.c: · 6ca65795
      unknown authored
        Fix bug: if we RENAME a table, InnoDB forgot to load the foreign key constraints that reference the new table name, and forgot to check that they are compatible with the table
      
      
      innobase/row/row0mysql.c:
        Fix bug: if we RENAME a table, InnoDB forgot to load the foreign key constraints that reference the new table name, and forgot to check that they are compatible with the table
      6ca65795
    • unknown's avatar
      - manual merge · 9003c146
      unknown authored
      9003c146
    • unknown's avatar
      Escaping [] so that darwin[7-8] gets into 'configure' and not darwin7-8 · 62150681
      unknown authored
      Adding a compilation define so that on recent Darwin mysqld does not react to SIGHUP and SIGQUIT:
      this fixes a rpl000001 problem on our Powermac G5 machine (popping after an upgrade from 10.3.4 to
      10.3.5) and is expected to fix 
      BUG#2030 "relay bin log on slave resets multiple times a second"
      (i.e. under some Mac OS X Panther versions, mysqld receives many SIGHUP and SIGQUIT).
      So this fix is more a problem-hider than a real understanding of why mysqld receives so many signals.
      Note that we saw other problems on this OS where mysqld reacts to Ctrl-Z but apparently only once,
      where using SSL seems to make the problem more frequent...
      
      
      configure.in:
        Escaping [] so that darwin[7-8] gets into 'configure' and not darwin7-8
        Adding a compilation define so that on recent Darwin mysqld does not react to SIGHUP and SIGQUIT.
      sql/mysqld.cc:
        optionally ignore SIGHUP and SIGQUIT, for some Mac OS X Panther versions which send too many of those.
      62150681
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · 271b2dd8
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      
      271b2dd8
  11. 12 Aug, 2004 4 commits