1. 11 Oct, 2004 3 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.0 · eb107ffe
      unknown authored
      into mysql.com:/mnt/tmp/mysql-4.0-bug-myisampack
      
      
      eb107ffe
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · a66a4dfb
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      a66a4dfb
    • unknown's avatar
      Fix for BUG#5949 "error code 1223 in binlog when using innobackup": · c5f9a412
      unknown authored
      when one connection had done FLUSH TABLES WITH READ LOCK, some updates, and then COMMIT,
      it was accepted but my_error() was called and so, while client got no error, error was logged in binlog.
      We now don't call my_error() in this case; we assume the connection know what it does.
      This problem was specific to 4.0.21. The change is needed to make replication work with existing versions of innobackup.
      
      
      sql/lock.cc:
        If a connection has done FLUSH TABLES WITH READ LOCK and now is doing COMMIT, don't give error
        (applies only if it's the same connection; others' COMMITs are still blocked).
      c5f9a412
  2. 08 Oct, 2004 1 commit
  3. 07 Oct, 2004 2 commits
    • unknown's avatar
      Fixed Bug#5575, mysqlhotcopy is broken when using --noindices · 66bdcf84
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      66bdcf84
    • unknown's avatar
      InnoDB: tolerate system clock glitches a little better · 7949ffc8
      unknown authored
      in the error monitor thread.  (Bug #5898)
      
      
      innobase/include/sync0arr.h:
        sync_array_print_long_waits(): return error status
      innobase/srv/srv0srv.c:
        srv_error_monitor_thread(): Keep track on successive fatal timeouts,
        and crash the server only if the timeouts have been exceeded for
        several times in succession.
      innobase/sync/sync0arr.c:
        sync_array_print_long_waits(): return error status
      7949ffc8
  4. 06 Oct, 2004 3 commits
  5. 05 Oct, 2004 11 commits
  6. 04 Oct, 2004 5 commits
    • unknown's avatar
      Bug #5829 mysqlimport garbles path of the file to be imported · bb6fe04c
      unknown authored
      Original code was checking ! unix_socket for local_file flag.  This doesn't work and so was removed.  Now
      to import a local file, you must use the --local command line option.
      
      mysqlimport.c:
        Removed check of unix_socket to set local_file
      
      
      client/mysqlimport.c:
        Removed check of unix_socket to set local_file
      bb6fe04c
    • unknown's avatar
      patch fixing after review on patch-fixing of · c0364263
      unknown authored
      Bug #5492 
      "set @@session.read_rnd_buffer_size=33554432" crashes server on query
      
      1. added warning comments for uint3korr (need one more byte allocated)
      2. unsigned long in uint3korr was replaced by unsigned int to 
         avoid problems on 64-bits platforms
      3. shorten warning comments in init_rr_cache in sql/records.cc
      
      
      include/config-win.h:
        1. added warning comments for uint3korr (need one more byte allocated)
        2. unsigned long in uint3korr was replaced by unsigned int to 
           avoid problems on 64-bits platforms
      include/my_global.h:
        1. added warning comments for uint3korr (need one more byte allocated)
        2. unsigned long in uint3korr was replaced by unsigned int to 
           avoid problems on 64-bits platforms
      sql/records.cc:
        shorten warning comments for my_malloc_lock in init_rr_cache
      c0364263
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.0 · cef86787
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_5492/mysql-4.0
      
      
      cef86787
    • unknown's avatar
      InnoDB: make ALTER TABLE to work on table names containing '#' (Bug #5856) · a31b8f24
      unknown authored
      
      innobase/dict/dict0dict.c:
        dict_strip_comments(): do not look for comments within quotes (Bug #5856)
      innobase/row/row0mysql.c:
        row_drop_table_for_mysql(): Remove a memory leak
      a31b8f24
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.0 · fcf27382
      unknown authored
      into hundin.mysql.fi:/home/marko/k/mysql-4.0
      
      
      fcf27382
  7. 02 Oct, 2004 3 commits
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-4.0 · 34474695
      unknown authored
      into ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/antony/work/bug4118
      
      
      34474695
    • unknown's avatar
      Merge ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/staff/repositories/mysql-4.0 · 52ee9687
      unknown authored
      into ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/antony/work/bug4118
      
      
      sql/sql_parse.cc:
        Auto merged
      52ee9687
    • unknown's avatar
      Bug#4118: multi-table UPDATE takes WRITE lock on read table · a49f5cae
      unknown authored
        Ensures that WRITE lock is not obtained on all tables referenced.
      
      
      mysql-test/r/lock_multi.result:
        Bug#4118
          New test for multi-update locking
      mysql-test/r/multi_update.result:
        Bug#4118
          Fix test
      mysql-test/t/lock_multi.test:
        Bug#4118
          New test for multi-update locking
      mysql-test/t/multi_update.test:
        Bug#4118
          Fix test
      sql/sql_parse.cc:
        Bug#4118
          Split multi-update to its own case statement in sql_parse.cc
      sql/sql_update.cc:
        Bug#4118
          Overview of locking checking:    
            1. Open and acquire READ lock
            2. Check to see which tables need WRITE lock
            3. Unlock tables and relock
      sql/sql_yacc.yy:
        Bug#4118
          Split multi-update to its own case statement in sql_parse.cc
      a49f5cae
  8. 01 Oct, 2004 1 commit
    • unknown's avatar
      delete.result, delete.test: · dc3f3ce6
      unknown authored
        A fix (bug #5733: Table handler error with self-join multi-table DELETE).
      records.cc:
        A fix (bug #5733: Table handler error with self-join multi-table DELETE).
      
      
      sql/records.cc:
        ]A fix (bug #5733: Table handler error with self-join multi-table DELETE).
      mysql-test/t/delete.test:
        A fix (bug #5733: Table handler error with self-join multi-table DELETE).
      mysql-test/r/delete.result:
        A fix (bug #5733: Table handler error with self-join multi-table DELETE).
      dc3f3ce6
  9. 30 Sep, 2004 1 commit
  10. 29 Sep, 2004 1 commit
    • unknown's avatar
      Fix for BUG#4785 part two: · 4bf11aac
      unknown authored
      * If at least one of indexes is disabled, use data file size as an estimate 
        for key file size.
      * Added handling for joined tables.
      
      
      4bf11aac
  11. 27 Sep, 2004 1 commit
  12. 26 Sep, 2004 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · fb1407d5
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.0-bg4131-3
      
      
      sql/sql_parse.cc:
        Auto merged
      fb1407d5
    • unknown's avatar
      Fix for bug #4131 "TIMESTAMP columns missing minutes and seconds when · e6f924ef
      unknown authored
      using GROUP BY"
      Now we are setting Field_timestamp::field_length to 19 in open_table()
      if we are in new mode (and we are restoring it back when we are coming
      back to normal mode). This also should solve potential problems with
      some of LOAD DATA INFILE and SELECT * INTO in this mode.
      
      
      mysql-test/r/type_timestamp.result:
        Added test for bug #4131 'TIMESTAMP columns missing minutes and seconds
        when using GROUP BY' and other --new mode related behavior.
      mysql-test/t/type_timestamp.test:
        Added test for bug #4131 'TIMESTAMP columns missing minutes and seconds
        when using GROUP BY' and other --new mode related behavior.
      sql/field.cc:
        Added Field_timestamp::orig_field_length member for saving original
        field_length value, because this member can be modified if new_mode is
        in effect.
        Lot of Field_timestamp code simplified and Field_timestamp::make_field()
        is no longer needed because we are setting field_length to 19 if we are
        in --new mode now.
      sql/field.h:
        Added Field_timestamp::orig_field_length member for saving original
        field_length value, because this member can be modified if new_mode
        is in effect. 
        Field_timestamp::make_field() is no longer needed because we are setting
        field_length to 19 if we are in --new mode now.
      sql/sql_base.cc:
        If --new mode is in effect all TIMESTAMP fields should pretend that they
        have length of 19. We are achieving this by setting 
        Field_timestamp::field_length to 19 (or original value) in open_table().
        We are using TABLE::timestamp_mode variable for avoiding of unnecessary
        looping over all fields of the table and setting field_length if table
        was used with same new_mode value before.
        
        Note: We do not introduce general framework for setting up Field objects
        for usage with current THD here because this fix is only needed in 4.0
        and Monty said that we will also remove looping over all fields when
        updating table_name member at some point. This more general framework
        will also complicate nice optimization with avoiding of unneeded looping.
      sql/sql_parse.cc:
        Now when we are creating TIMESTAMP(19) fields by default in --new mode,
        otherwise we will have unaligned behavior between ALTER and CREATE.
      sql/table.h:
        Added TABLE::timestamp_mode field for saving information whenever we set 
        field_length members of table's TIMESTAMP fields to 19 (to honor 
        new_mode) or they have original values.
      e6f924ef
    • unknown's avatar
      added --without-man option similar to --without-docs · 85d98034
      unknown authored
      (part of BUG#5379)
      
      
      85d98034
    • unknown's avatar
      make --with-openssl work with parameters as expected, · dc955863
      unknown authored
      old options for include path and library settings still
      work for backwards compatibility
      (fix for BUG #5494)
      
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      dc955863
  13. 25 Sep, 2004 1 commit
    • unknown's avatar
      Bug #5539 SHOW DATABASES LIKE and symlinks · 550c4eb7
      unknown authored
      sql_show.cc:
        Made change suggested by Serge. REmoved else in mysql_find_files so symlink files fall through to the wildcard check
      
      
      sql/sql_show.cc:
        Made change suggested by Serge. REmoved else in mysql_find_files so symlink files fall through to the wildcard check
      550c4eb7
  14. 24 Sep, 2004 3 commits
    • unknown's avatar
      BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S). · 697cb7b1
      unknown authored
      BUG#4335 - one name can be handler open'ed many times.
      Reworked the HANDLER functions and interface.
      Using a HASH to store information on open tables that
      survives FLUSH TABLE.
      HANDLER tables alias names must now be unique, though it
      is allowed in 4.0 to qualify them with the database name
      of the base table.
      
      
      mysql-test/r/flush_table.result:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Moved pure handler test results to handler.result.
        Added the new test results.
      mysql-test/r/handler.result:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Moved pure handler test results from flush_table.result to here.
      mysql-test/t/flush_table.test:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Moved pure handler tests to handler.test.
        Added new tests.
      mysql-test/t/handler.test:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Moved pure handler tests from flush_table.test to here.
      sql/mysql_priv.h:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Reworked the handler interface.
      sql/sql_base.cc:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Replaced mysql_ha_close_list() by the better named
        function mysql_ha_flush() with readable options.
      sql/sql_class.cc:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Added initialization for the handler tables hash.
        Changed the handler tables clean-up code.
        Unreleted to bug: Changed the order of THD initialization
        to avoid warning messages on Linux with gcc.
      sql/sql_class.h:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Added the handler tables HASH to THD.
      sql/sql_handler.cc:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        Completely reworked the handler functions.
        Added an introducing comment, describing the new functionality.
      sql/sql_table.cc:
        BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S).
        BUG#4335 - one name can be handler open'ed many times.
        replaced mysql_ha_close() by the better named
        function mysql_ha_flush() with readable options.
      697cb7b1
    • unknown's avatar
      Fix for BUG#3248 "Doc says MyISAM warns if disk full but it does not": · c8682133
      unknown authored
      we force the message to the error log, and we make it more informative;
      we treat EDQUOT like ENOSPC.
      
      
      mysys/errors.c:
        more informative message
      mysys/my_fstream.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_pread.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_write.c:
        Treat EDQUOT like ENOSPC.
      mysys/mysys_priv.h:
        Define EDQUOT when it does not exist. Finally decided to put it here after discussion with Monty:
        as this constant is used only in 3 files only in mysys/, I don't make it visible everywhere
        (there currently is no file of choice for such defines; my_base.h does not contain any).
        Using a value which never happens avoids collisions.
      sql/mysqld.cc:
        If ME_NOREFRESH, we write message to error log, even if it has been saved for client (because if operation
        is hanging, the message does not get to client now; example is MyISAM waiting for free disk space).
      c8682133
    • unknown's avatar
      Bug #5539 SHOW DATABASES LIKE and symlinks · ecd3172b
      unknown authored
      sql_show.cc:
        Added wild card check to symdir block in mysql_find_files
      
      
      sql/sql_show.cc:
        Added wild card check to symdir block in mysql_find_files
      ecd3172b