1. 14 Oct, 2013 6 commits
  2. 13 Oct, 2013 2 commits
  3. 12 Oct, 2013 1 commit
    • Igor Babaev's avatar
      Fixed bug mdev-5132. · 78b580b7
      Igor Babaev authored
      Objects of the classes Item_func_isnull and Item_func_isnotnull
      must have the flag sargable set to TRUE.
      Set the value of the flag sargable only in constructors of the 
      classes inherited from Item_int_func.
      78b580b7
  4. 11 Oct, 2013 3 commits
  5. 10 Oct, 2013 2 commits
    • Igor Babaev's avatar
      Fixed bug mdev-5105. · 7c87385e
      Igor Babaev authored
      The bug caused a memory overwrite in the function update_ref_and_keys()
      It happened due to a wrong value of SELECT_LEX::cond_count. This value
      historically was calculated by the fix_fields method. Now the logic of
      calling this method became too complicated and, as a result, this value
      is calculated not always correctly.
      The patch changes the way how and when  the values of SELECT_LEX::cond_count
      and of SELECT_LEX::between_count are calculated. The new code does it just at
      the beginning of update_ref_and_keys().
       
      7c87385e
    • Alexey Botchkov's avatar
      MDEV-4788 check mysql-5.5 changes in spatial.cc. · 508d40fb
      Alexey Botchkov authored
              Additional patch for the 5.5.
      508d40fb
  6. 09 Oct, 2013 1 commit
    • Alexey Botchkov's avatar
      MDEV-3856 Import of a large polygon fails/hangs. · ae826010
      Alexey Botchkov authored
              The Gis_point::init_from_wkt called the String::realloc(),
              and this call is quite slow in the DEBUG mode. Which makes
              loading the huge polygon hang forever.
              Fixed by using the String::realloc(size, inc_size) version instead
              as it's done for other spatial features.
      ae826010
  7. 08 Oct, 2013 1 commit
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · 1bcd2beb
      Alexander Barkov authored
      Do not pass PCRE_UCP flag for binary data.
      This makes bytes 0x80..FF not to belong to 
      generic character classes \d (digit) and \w (word character).
      
      SELECT 0xFF RLIKE '\\w';
       -> 0
      
      Note, this change does not affect non-binary data,
      which is still examined with the PCRE_UCP flag by default.
      1bcd2beb
  8. 04 Oct, 2013 2 commits
    • Igor Babaev's avatar
      Fixed bug mdev-5078. · ec226e55
      Igor Babaev authored
      For aggregated fields from views/derived tables the possible adjustment
      of thd->lex->in_sum_func->max_arg_level in the function Item_field::fix_fields
      must be done before we leave the function.
      ec226e55
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · 43c09c15
      Alexander Barkov authored
      Fixing compilation failure on Solaris.
      The int64_t type was not defined because stdint.h was not included
      due to a missing definition in pcre/config-cmake.h.in.
      43c09c15
  9. 03 Oct, 2013 5 commits
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · c8e6cb96
      Alexander Barkov authored
      Clean-up: moving initialization of my_string_stack_guard
      and pcre_stack_guard into init_libstrings() and init_pcre().
      c8e6cb96
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · 30ad3354
      Alexander Barkov authored
      Adding tests with 0x00 characters from
      
      Bug#70470 REGEXP fails to find matches after NUL character
      30ad3354
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · 01f83356
      Alexander Barkov authored
      Adding more tests for case sensitivity,
      with various collation and (?i) flags combinations.
      01f83356
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · f37e0a88
      Alexander Barkov authored
      PCRE unit tests failed on Ubuntu Precise, because "source" 
      is not a known command in "dash" (the default shell in Precise).
      
      Changing "source" to ".", which should be understood in all shells.
      f37e0a88
    • Igor Babaev's avatar
      Fixed bug mdev-5028. · 00816a96
      Igor Babaev authored
      Apparently in a general case a short-cut for the distinct optimization
      is invalid if join buffers are used to join tables after the tables whose
      values are to selected.
      00816a96
  10. 02 Oct, 2013 5 commits
    • Alexander Barkov's avatar
      A follow-up for the previous commit: · 1a3bb948
      Alexander Barkov authored
      MDEV-4425 Regexp enhancements
      Adding ${CMAKE_BINARY_DIR}/pcre into search path for *.h files.
      Needed for find pcre.h (which is generated from pcre.h.in) when
      build directory != source directory.
      1a3bb948
    • Alexander Barkov's avatar
      MDEV-4425 · f71e2539
      Alexander Barkov authored
      Adding ${CMAKE_BINARY_DIR}/pcre into search path for *.h files.
      Needed for find pcre.h (which is generated from pcre.h.in) when
      build directory != source directory.
      f71e2539
    • Alexander Barkov's avatar
      MDEV-4425 REGEXP enhancements · fcf992ba
      Alexander Barkov authored
      Adding pcre_stack_guard to avoid crashes in pcre_compile()
      on a long recursive patterns with parenthesizes:
      
      SELECT a RLIKE '((((...((((x)))...))))';
      fcf992ba
    • Alexander Barkov's avatar
      MDEV-4425 Regexp enhancements · d83648f2
      Alexander Barkov authored
      Removing pcre.h from the tree, it's generated from pcre.h.in 
      d83648f2
    • Alexander Barkov's avatar
      MDEV-4424 Regexp enhancements · bf410884
      Alexander Barkov authored
      - Commenting out unused instructions in pcre/CMakeLists.txt
      - Don't print PCRE configuration status by default.
      bf410884
  11. 01 Oct, 2013 3 commits
  12. 30 Sep, 2013 4 commits
    • Alexander Barkov's avatar
    • Alexander Barkov's avatar
      pcre: fixing a test failure in character_sets_dir_basic in this command: · 62260434
      Alexander Barkov authored
      --replace_regex /.prefix.sql.share.charsets[/\]/MYSQL_CHARSETSDIR/
      select @@global.character_sets_dir;
      
      The intention of the '[/\]' part was to replace both slash
      '/' and backslash '\\', so it does not depend on the OS.
      
      The pattern '[/\]' was actually wrong, because ']' is escaped
      and should be considered as a part of the class, instead of
      being a closing bracket for the class. However, due to some bug
      in the old REGEX library it worked fine.
      
      After switching to PCRE, mysqltest correctly complains about unbalaced '[]'.
      The expected correct pattern should be '[/\\]'.
      However, due to some bug in mysqltest, it eats consequetive baskslashes
      in a strange way, so there is no a way to have to consequetive 
      backslashes after unescaping.
      
      Workaround:
      
      using [[:punct:]] as a pattern that matches both slash and backslash,
      which should be fine for this test purposes.
      62260434
    • Alexander Barkov's avatar
      Always include the local copy of pcre.h and pcreposix.h instead of the · 038554ec
      Alexander Barkov authored
      system installed (if any).
      038554ec
    • Alexander Barkov's avatar
      pcre: fixing linking error one some systems: · 61a1c036
      Alexander Barkov authored
      libmysqld.a(pcre_exec.c.o): relocation R_X86_64_32S against
      `_pcre_ucd_stage1' can not be used when making a shared object;
      make[2]: Leaving directory `/mnt/buildbot/build/mariadb-10.0.3'
      recompile with -fPIC
      
      Changing ADD_LIBRARY(pcre) to ADD_CONVENIENCE_LIBRARY(pcre)
      61a1c036
  13. 27 Sep, 2013 4 commits
  14. 26 Sep, 2013 1 commit