1. 09 Oct, 2015 2 commits
  2. 08 Oct, 2015 5 commits
  3. 06 Oct, 2015 3 commits
    • Sergei Petrunia's avatar
      MDEV-8903: Buildbot valgrind failure: Invalid read of size 1 in sql_memdup... · 4a602046
      Sergei Petrunia authored
      When we calculate max_key_len for RANGE_OPT_PARAM::min_key/max_key, take
      into account that QUICK_RANGE::QUICK_RANGE for some reason assumes
      that there is one more byte there:
      
            max_key((uchar*) sql_memdup(max_key_arg,max_length_arg+1)),
      4a602046
    • Sergei Petrunia's avatar
      Fix for MDEV-8321, MDEV-6223 · 12897947
      Sergei Petrunia authored
      EXPLAIN INSERT ... SELECT tried to use SELECT's execution path. This
      caused a collection of problems:
      - SELECT_DESCRIBE flag was not put into select_lex->options, which
        means it was not in JOIN::select_options either (except for the first
        member of the UNION).
      - This caused UNION members to be executed. They would attempt to write
        join output rows to the output.
      - (Actual cause of the crash) second join sibling would call
        result->send_eof() when finished execution. Then,
        Explain_query::print_explain would attempt to write to query output
        again, and cause an assertion due to non-empty query output.
      12897947
    • Sergei Petrunia's avatar
      MDEV-8299: MyISAM or Aria table gets corrupted after EXPLAIN INSERT and INSERT · a7dd24cd
      Sergei Petrunia authored
      [EXPLAIN] INSERT .. SELECT creates a select_insert object.
      select_insert calls handler->start_bulk_insert() during
      initialization.
      
      For MyISAM/Aria this requires that a matching call to
      handler->end_bulk_insert() call is made.
      
      Regular INSERT .. SELECT accomplishes this by calling either
      select_result->send_eof() or select_result->abort_result_set().
      
      EXPLAIN INSERT ... SELECT didn't call either, which resulted in
      improper de-initializaiton of handler object. Make it call
      abort_result_set(), which invokes handler->end_bulk_insert().
      a7dd24cd
  4. 01 Oct, 2015 2 commits
    • Sergey Vojtovich's avatar
      MDEV-8379 - SUSE mariadb patches · bb22eb55
      Sergey Vojtovich authored
      Corrected variable name in dead code for consistency.
      
      Patch contributed by Michal Hrusecky.
      bb22eb55
    • Sergey Vojtovich's avatar
      MDEV-8379 - SUSE mariadb patches · 727da9c8
      Sergey Vojtovich authored
      Fixed unclean prototype declaration. According to ISO/IEC 9899:TC2:
      ...
      10. The special case of an unnamed parameter of type void as the only item in
          the list specifies that the function has no parameters.
      ...
      14. An identifier list declares only the identifiers of the parameters of the
          function. An empty list in a function declarator that is part of a
          definition of that function specifies that the function has no parameters.
          The empty list in a function declarator that is not part of a definition of
          that function specifies that no information about the number or types of the
          parameters is supplied. 124)
      ...
      6.11.6 Function declarators
      
      The use of function declarators with empty parentheses (not prototype-format
      parameter type declarators) is an obsolescent feature.
      ...
      
      Patch contributed by Michal Hrusecky.
      727da9c8
  5. 22 Sep, 2015 2 commits
  6. 21 Sep, 2015 1 commit
  7. 14 Sep, 2015 1 commit
  8. 11 Sep, 2015 4 commits
  9. 06 Sep, 2015 1 commit
  10. 04 Sep, 2015 1 commit
  11. 03 Sep, 2015 1 commit
  12. 02 Sep, 2015 3 commits
    • Kristian Nielsen's avatar
      Merge MDEV-8725 into 10.0 · 83c7b1e9
      Kristian Nielsen authored
      83c7b1e9
    • Kristian Nielsen's avatar
      Fix a potential lost wakeup for binlog_commit_wait_usec · 09bfaf3a
      Kristian Nielsen authored
      If a transaction T1 needs to wait for a transaction T2, T2's commit will
      skip the normal binlog_commit_wait_usec delay, in order not to needlessly
      stall throughput.
      
      This works by checking if T2 is already ready to commit. If so, it is woken
      up. If not, we set a flag in T2 so that when it gets ready to commit, it
      will do so immediately.
      
      But there was a potential race due to insufficient locking, if T2 gets ready
      to commit just at the point where T1 does the check. If the race hits, the
      wakeup (and early commit) of T2 might be lost.
      
      The race is only theoretical (from code inspection, no known test case), but
      seems best to fix it anyway, by properly locking LOCK_prepare_ordered around
      the check.
      09bfaf3a
    • Kristian Nielsen's avatar
      MDEV-8725: Assertion `!(thd->rgi_slave && thd->... · 999c43ae
      Kristian Nielsen authored
      MDEV-8725: Assertion `!(thd->rgi_slave && thd-> rgi_slave->did_mark_start_commit)' failed in ha_rollback_trans
      
      The assertion is there to catch cases where we rollback while
      mark_start_commit() is active. This can allow following event groups
      to be replicated too early, causing conflicts.
      
      But in this case, we have an _explicit_ ROLLBACK event in the binlog,
      which should not assert.
      
      We fix this by delaying the mark_start_commit() in the explicit
      ROLLBACK case. It seems safest to delay this in ROLLBACK case anyway,
      and there should be no reason to try to optimise this corner case.
      999c43ae
  13. 31 Aug, 2015 1 commit
  14. 23 Aug, 2015 2 commits
  15. 18 Aug, 2015 1 commit
    • Sergei Petrunia's avatar
      MDEV-8289: Semijoin inflates number of rows in query result · 9b475ee3
      Sergei Petrunia authored
      - Make semi-join optimizer not to choose LooseScan
        when 1) the index is not covered and 2) full index
        scan will be required.
      
      - Make sure that the code in make_join_select() that may change
        full index scan into a range scan is not invoked when the table
        uses full scan.
      9b475ee3
  16. 12 Aug, 2015 2 commits
    • Monty's avatar
      Fixed mysqltest run failure: · 1bfe4da1
      Monty authored
      Test did not clean up after itself properly
      1bfe4da1
    • Monty's avatar
      Fixed overrun in key cache if one tried to allocate a key cache · afa9cb75
      Monty authored
      of more than 45G with a key_cache_block_size of 1024 or less.
      
      The problem was that some of the arguments to my_multi_malloc() got to be
      more than 4G.
      
      Fix:
      - Inntroduced my_multi_malloc_large() that can handle big regions.
      - Changed MyISAM and Aria key caches to use my_multi_malloc_large().
      
      I didn't change the default my_multi_malloc() as this would be a too big
      patch and we don't allocate 4G blocks anywhere else.
      afa9cb75
  17. 05 Aug, 2015 3 commits
  18. 04 Aug, 2015 5 commits