1. 06 Jul, 2006 6 commits
  2. 04 Jul, 2006 3 commits
    • sergefp@mysql.com's avatar
      d581287b
    • gkodinov@mysql.com's avatar
      Merge mysql.com:/home/kgeorge/mysql/5.0/teamclean · ae0a3e0d
      gkodinov@mysql.com authored
      into  mysql.com:/home/kgeorge/mysql/5.0/B16110
      ae0a3e0d
    • gkodinov@mysql.com's avatar
      Bug #16110: insert permitted into view col w/o default value · b64089e6
      gkodinov@mysql.com authored
      When compiling INSERT statements the check whether columns are provided values
      depends on the flag whether a field is used in that query (Field::query_id).
      However the check for updatability of VIEW columns (check_view_insertability())
      was calling fix_fields() and thus setting the Field::query_id even for the 
      view fields that are not referenced in the current INSERT statement.
      So the correct check for columns without default values 
      ( check_that_all_fields_are_given_values() ) is assuming that all the VIEW
      columns were mentioned in the INSERT field list and was issuing no 
      warnings or errors.
      Fixed check_view_insertability() to turn off the flag whether or not to set
      Field::query_id (THREAD::set_query_id) before calling fix fields and restore
      it when it's done.
      b64089e6
  3. 29 Jun, 2006 31 commits