1. 07 Aug, 2003 1 commit
    • unknown's avatar
      Review of changesets since last pull. · fa1613be
      unknown authored
      (Mostly code cleanups)
      
      
      include/my_sys.h:
        Removed not used define
      myisam/mi_check.c:
        Indentation change
      mysql-test/t/rpl_insert_id.test:
        Add test if server supports innodb
      mysys/mf_format.c:
        Remove QUOTE handling from fn_format()
        (fn_format() should not have anything to do with quoting things)
      sql/log_event.cc:
        Removed some unnecessary casts (by changing functions to use const char *)
        Cleaned up some error messages to make them shorter and (hopefully) more readable.
        Fixed wrong format strings
        Restored 'thd->options' on error.
      sql/mini_client.cc:
        Changed order of include files to remove compilation warning
      sql/mysqld.cc:
        Add proper quoting of service arguments (don't use fn_format)
      sql/slave.cc:
        Simple optimization and cleanup.
        Changed rewrite_db() and print_slave_db_safe() to use const char* to avoid casting of arguments when calling functions.
        Cleanup of some error messages.
      sql/slave.h:
        Changed protypes to use const char *
      sql/sql_acl.cc:
        Simple optimization
      vio/viosslfactories.c:
        Changed order of include files to remove compilation warning
      fa1613be
  2. 02 Aug, 2003 3 commits
    • unknown's avatar
      Fix so that SET PASSWORD is not replicated by the slave if running with · 3b013646
      unknown authored
      replicate-*-table rules which exclude 'mysql' tables
      (e.g. replicate-wild-ignore-table=mysql.%).
      This was already the behaviour for GRANT/REVOKE, I'm extending it to
      SET PASSWORD because it seems very logical (the contrary seems illogical).
      2 new tests:
      - one to test if GRANT and SET PASSWORD are replicated
      - one to test if they are not replicated if replicate-wild-ignore-table=mysql.%
      The 2nd is also a testcase for BUG#980.
      
      
      sql/sql_acl.cc:
        Fix so that SET PASSWORD is not replicated by the slave if running with
        replicate-*-table rules which exclude 'mysql' tables
        (e.g. replicate-wild-ignore-table=mysql.%).
        This was already the behaviour for GRANT/REVOKE, I'm extending it to
        SET PASSWORD because it seems very logical (the contrary seems illogical).
      3b013646
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · b1c56d68
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      sql/sql_acl.cc:
        Auto merged
      b1c56d68
    • unknown's avatar
      Mark tables 'updating' in sql_acl.cc (mysql_grant(), mysql_table_grant()) so that · 5a696ebd
      unknown authored
      tables_ok() does not ignore them. This fixes random bug #980.
      
      
      sql/sql_acl.cc:
        Mark tables 'updating' so that tables_ok() does not ignore them;
        this fixes random bug #980.
      5a696ebd
  3. 01 Aug, 2003 5 commits
  4. 31 Jul, 2003 1 commit
  5. 30 Jul, 2003 4 commits
  6. 29 Jul, 2003 2 commits
    • unknown's avatar
      Fix security bug. mysqld server without ssl support was completly · 880088ba
      unknown authored
      ignorant about ssl_type attribute
      
      
      sql/sql_acl.cc:
        Now acl_getroot() honors ssl_type attribute even if we compile without openssl
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      880088ba
    • unknown's avatar
      dict0dict.c: · 30b751f8
      unknown authored
        Fix bug introduced in 4.0.13 and reported by Emic: if a CREATE TABLE ended in a comment, a memory overrun could happen
      
      
      innobase/dict/dict0dict.c:
        Fix bug introduced in 4.0.13 and reported by Emic: if a CREATE TABLE ended in a comment, a memory overrun could happen
      30b751f8
  7. 28 Jul, 2003 2 commits
    • unknown's avatar
      mysqld.cc: · 17a6d749
      unknown authored
        innodb_fast_shutdown CAN take an argument though it was not specified so in mysqld.cc
      
      
      sql/mysqld.cc:
        innodb_fast_shutdown CAN take an argument though it was not specified so in mysqld.cc
      17a6d749
    • unknown's avatar
      Avoid segfault when LOAD DATA FROM MASTER is run on a master which does no · 46f96a30
      unknown authored
      binary logging.
      
      
      sql/repl_failsafe.cc:
        If the master is running without --log-bin, SHOW MASTER STATUS will return
        "empty set", i.e. row==0; we must test this before invoking row[0], or
        segfault.
      46f96a30
  8. 26 Jul, 2003 2 commits
  9. 25 Jul, 2003 4 commits
    • unknown's avatar
      srv0srv.c, os0file.c, log0recv.h, log0log.h, fil0fil.h, fsp0fsp.c, fil0fil.c: · df5b0889
      unknown authored
        Merge
      trx0trx.c:
        Print more info about a trx in SHOW INNODB status; try to find the bug reported by Plaxo
      buf0buf.c:
        Check that page log sequence numbers are not in the future
      log0recv.c, log0log.c:
        Fixed a bug: if you used big BLOBs, and your log files were relatively small, InnoDB could in a big BLOB operation temporarily write over the log produced AFTER the latest checkpoint. If InnoDB would crash at that moment, then the crash recovery would fail, because InnoDB would not be able to scan the log even up to the latest checkpoint. Starting from this version, InnoDB tries to ensure the latest checkpoint is young enough. If that is not possible, InnoDB prints a warning to the .err log
      
      
      innobase/log/log0log.c:
        Fixed a bug: if you used big BLOBs, and your log files were relatively small, InnoDB could in a big BLOB operation temporarily write over the log produced AFTER the latest checkpoint. If InnoDB would crash at that moment, then the crash recovery would fail, because InnoDB would not be able to scan the log even up to the latest checkpoint. Starting from this version, InnoDB tries to ensure the latest checkpoint is young enough. If that is not possible, InnoDB prints a warning to the .err log
      innobase/log/log0recv.c:
        Fixed a bug: if you used big BLOBs, and your log files were relatively small, InnoDB could in a big BLOB operation temporarily write over the log produced AFTER the latest checkpoint. If InnoDB would crash at that moment, then the crash recovery would fail, because InnoDB would not be able to scan the log even up to the latest checkpoint. Starting from this version, InnoDB tries to ensure the latest checkpoint is young enough. If that is not possible, InnoDB prints a warning to the .err log
      innobase/buf/buf0buf.c:
        Check that page log sequence numbers are not in the future
      innobase/trx/trx0trx.c:
        Print more info about a trx in SHOW INNODB status; try to find the bug reported by Plaxo
      innobase/fil/fil0fil.c:
        Merge
      innobase/fsp/fsp0fsp.c:
        Merge
      innobase/include/fil0fil.h:
        Merge
      innobase/include/log0log.h:
        Merge
      innobase/include/log0recv.h:
        Merge
      innobase/os/os0file.c:
        Merge
      innobase/srv/srv0srv.c:
        Merge
      df5b0889
    • unknown's avatar
      2763b52d
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.0 · cff7465b
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/mysql-4.0.fix
      
      
      cff7465b
    • unknown's avatar
      Fix: remove compile warnings on RH(with openssl) · c786689a
      unknown authored
      c786689a
  10. 24 Jul, 2003 4 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 6ccd8cfa
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      6ccd8cfa
    • unknown's avatar
      Fix for BUG#858 "CHANGE MASTER forgets to update relay-log.info"; · 14d9a2e5
      unknown authored
      just a flush_relay_log_info() at the end of CHANGE MASTER
      (there was already flush_master_info()).
      
      
      sql/sql_repl.cc:
        Comments.
        Flush relay-log.info after CHANGE MASTER, or the changes
        to the relay log parameters (relay log name and position, and
        the corresponding master's binlog name and position) will be
        lost if the slave mysqld is shutdown immediately after the 
        CHANGE MASTER (without the slave threads being started).
      14d9a2e5
    • unknown's avatar
      WL#1036 (print the db in slave error messages). · ab34adf6
      unknown authored
      I extended the task to cleaning error messages, making them look nicer,
      and making the output of SHOW SLAVE STATUS (column Last_error) be as complete
      as what's printed on the .err file;
      previously we would have, for a failure of a replicated LOAD DATA INFILE:
      - in the .err, 2 lines:
      "duplicate entry 2708 for key 1"
      "failed loading SQL_LOAD-5-2-2.info"
      - and in SHOW SLAVE STATUS, only:
      "failed loading SQL_LOAD-5-2-2.info".
      Now SHOW SLAVE STATUS will contain the concatenation of the 2 messages.
      
      
      sql/log_event.cc:
        Print the default database when replication stops because of an error. Previously, we had:
        "error "Duplicate entry 87987 for key 1", query 'insert into t values(87987)'", ie the db
        was not mentioned, making it hard for cases where the same table name is used in
        several databases.
        Lengthened some error messages (for failing replication of LOAD DATA: mention the table
        and the db).
        Changes so that SHOW SLAVE STATUS reports as complete errors as the .err file.
      sql/slave.cc:
        Removed a useless declaration (the rewrite_db() function is already declared in slave.h).
        Added missing ')' in error messages.
        Tried to make error messages look nicer (previously we had
        "do START SLAVE;, error_code=1062"
        now we'll have
        "do START SLAVE; . Error_code=1062".
        This form has been discussed, I agree it's no panacea, but it's still more readable
        like this. To be improved in the future :)
      sql/slave.h:
        declarations.
      ab34adf6
    • unknown's avatar
      c67f50f3
  11. 23 Jul, 2003 1 commit
  12. 22 Jul, 2003 6 commits
  13. 21 Jul, 2003 3 commits
  14. 19 Jul, 2003 2 commits