1. 02 Nov, 2007 2 commits
    • kaa@polly.(none)'s avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · fa462599
      kaa@polly.(none) authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      fa462599
    • kaa@polly.(none)'s avatar
      Fix for: · 9cd5f49c
      kaa@polly.(none) authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      9cd5f49c
  2. 01 Nov, 2007 1 commit
  3. 30 Oct, 2007 2 commits
  4. 29 Oct, 2007 5 commits
  5. 27 Oct, 2007 2 commits
  6. 26 Oct, 2007 3 commits
  7. 25 Oct, 2007 2 commits
    • kaa@polly.(none)'s avatar
      Fix for bug #29131: SHOW VARIABLES reports variable 'log' but SET · 99f4b743
      kaa@polly.(none) authored
      doesn't recognize it
      
      This is a 5.0 version of the patch, it will be null-merged to 5.1
      
      Problem:
      
      'log' and 'log_slow_queries' were "fixed" variables, i.e. they showed up
      in SHOW VARIABLES, but could not be used in expressions like 
      "select @@log". Also, using them in the SET statement produced an 
      incorrect "unknown system variable" error.
      
      Solution:
      
      Make 'log' and 'log_slow_queries' read-only dynamic variables to make 
      them available for use in expressions, and produce a correct error 
      about the variable being read-only when used in the SET statement.
      99f4b743
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #27695: View should not be allowed to have empty or · e36846de
      gshchepa/uchum@gleb.loc authored
      all space column names.
      
      The parser has been modified to check VIEW column names
      with the check_column_name function and to report an error
      on empty and all space column names (same as for TABLE
      column names).
      e36846de
  8. 24 Oct, 2007 2 commits
    • gkodinov/kgeorge@magare.gmz's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B30715-5.0-opt · 1cda34d3
      gkodinov/kgeorge@magare.gmz authored
      into  magare.gmz:/home/kgeorge/mysql/work/B30715-merged-5.0-opt
      1cda34d3
    • gkodinov/kgeorge@magare.gmz's avatar
      Bug #30715: Assertion failed: item_field->field->real_maybe_null(), · 54cea400
      gkodinov/kgeorge@magare.gmz authored
        file .\opt_sum.cc, line
      The optimizer pre-calculates the MIN/MAX values for queries like
       SELECT MIN(kp_k) WHERE kp_1 = const AND ... AND kp_k-1 = const
      when there is a key over kp_1...kp_k
      In doing so it was not checking correctly nullability and 
      there was a superfluous assert(). 
      Fixed by making sure that the field can be null before checking and
      taking out the wrong assert().
      .
      Introduced a correct check for nullability 
      The MIN(field) can return NULL when all the row values in the group
      are NULL-able or if there were no rows.
      Fixed the assertion to reflect the case when there are no rows.
      54cea400
  9. 23 Oct, 2007 19 commits
  10. 22 Oct, 2007 2 commits
    • gkodinov/kgeorge@magare.gmz's avatar
      Bug #28687: Search fails on '0000-00-00' date after sql_mode change · 52b35112
      gkodinov/kgeorge@magare.gmz authored
      When doing indexed search the server constructs a key image for 
      faster comparison to the stored keys. While doing that it must not
      perform (and stop if they fail) the additional date checks that can 
      be turned on by the SQL mode because there already may be values in 
      the table that don't comply with the error checks.
      Fixed by ignoring these SQL mode bits while making the key image.
      52b35112
    • kaa@polly.(none)'s avatar
      Fix for bug #31742: delete from ... order by function call that causes · 53a9e7f4
      kaa@polly.(none) authored
      an error, asserts server
      
      In case of a fatal error during filesort in find_all_keys() the error
      was returned without the necessary handler uninitialization.
      Fixed by changing the code so that handler uninitialization is performed
      before returning the error.
      53a9e7f4