1. 29 Jun, 2007 1 commit
    • evgen@moonbone.local's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · fc601d77
      evgen@moonbone.local authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      fc601d77
  2. 25 Jun, 2007 3 commits
  3. 24 Jun, 2007 3 commits
    • igor@olga.mysql.com's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · da416060
      igor@olga.mysql.com authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug25602
      da416060
    • gshchepa/uchum@gleb.loc's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 684d0ced
      gshchepa/uchum@gleb.loc authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      684d0ced
    • igor@olga.mysql.com's avatar
      Fixed bug #25602. A query with DISTINCT in the select list to which · 59b9077c
      igor@olga.mysql.com authored
      the loose scan optimization for grouping queries was applied returned 
      a wrong result set when the query was used with the SQL_BIG_RESULT
      option.
      
      The SQL_BIG_RESULT option forces to use sorting algorithm for grouping
      queries instead of employing a suitable index. The current loose scan
      optimization is applied only for one table queries when the suitable
      index is covering. It does not make sense to use sort algorithm in this
      case. However the create_sort_index function does not take into account
      the possible choice of the loose scan to implement the DISTINCT operator
      which makes sorting unnecessary. Moreover the current implementation of
      the loose scan for queries with distinct assumes that sorting will
      never happen. Thus in this case create_sort_index should not call
      the function filesort.
      59b9077c
  4. 23 Jun, 2007 3 commits
  5. 22 Jun, 2007 9 commits
  6. 21 Jun, 2007 17 commits
  7. 20 Jun, 2007 4 commits
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #28293. · 1b5d8931
      gshchepa/uchum@gleb.loc authored
      Occasionally mysqlbinlog --hexdump failed with error:
        ERROR 1064 (42000) at line ...: You have an error in your
        SQL syntax; check the manual that corresponds to your MySQL
        server version for the right syntax to use near
        'Query thread_id=... exec_time=... error_code=...
      
      When the length of hexadecimal dump of binlog header was
      divisible by 16, commentary sign '#' after header was lost.
      The Log_event::print_header function has been modified to always
      finish hexadecimal binlog header with "\n# ".
      1b5d8931
    • igor@olga.mysql.com's avatar
      Fixed bug #29104: assertion abort for grouping queries using views. · c6cc5096
      igor@olga.mysql.com authored
      The abort happened when a query contained a conjunctive predicate
      of the form 'view column = constant' in the WHERE condition and 
      the grouping list also contained a reference to a view column yet
      a different one.
      
      Removed the failing assertion as invalid in a general case.
      
      Also fixed a bug that prevented applying some optimization for grouping
      queries using views. If the WHERE condition of such a query contains
      a conjunctive condition of the form 'view column = constant' and
      this view column is used in the grouping list then grouping by this
      column can be eliminated. The bug blocked performing this elimination.
      c6cc5096
    • mats@kindahl-laptop.dnsalias.net's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.0-rpl · 6f9f5b01
      mats@kindahl-laptop.dnsalias.net authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b29030-mysql-5.0-rpl
      6f9f5b01
    • mats@kindahl-laptop.dnsalias.net's avatar
      BUG#29030 (DROP USER command that errors still gets written to binary log · 2f748263
      mats@kindahl-laptop.dnsalias.net authored
      and replicated):
      
      A DROP USER statement with a non-existing user was correctly written to
      the binary log (there might be users that were removed, but not all),
      but the error code was not set, which caused the slave to stop with an
      error.
      
      The error reporting code was moved to before the statement was logged
      to ensure that the error information for the thread was correctly set
      up. This works since my_error() will set the fields net.last_errno and
      net.last_error for the thread that is reporting the error, and this
      will then be picked up when the Query_log_event is created and written
      to the binary log.
      2f748263