1. 08 Apr, 2006 2 commits
  2. 07 Apr, 2006 9 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · f37d6101
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-16365
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge
      mysql-test/t/ps.test:
        Manual merge
      f37d6101
    • unknown's avatar
      A fix and a test case for Bug#16365 "Prepared Statements: DoS with · 5b5530da
      unknown authored
      too many open statements". The patch adds a new global variable
      @@max_prepared_stmt_count. This variable limits the total number
      of prepared statements in the server. The default value of
      @@max_prepared_stmt_count is 16382. 16382 small statements
      (a select against 3 tables with GROUP, ORDER and LIMIT) consume 
      100MB of RAM. Once this limit has been reached, the server will 
      refuse to prepare a new statement and return ER_UNKNOWN_ERROR 
      (unfortunately, we can't add new errors to 4.1 without breaking 5.0). The limit is changeable after startup
      and can accept any value from 0 to 1 million. In case
      the new value of the limit is less than the current
      statement count, no new statements can be added, while the old
      still can be used. Additionally, the current count of prepared 
      statements is now available through a global read-only variable 
      @@prepared_stmt_count.
      
      
      mysql-test/r/ps.result:
        Test results fixed (a test case for Bug#16365)
      mysql-test/t/ps.test:
        A test case for Bug#16365 "Prepared Statements: DoS with too many 
        open statements". Also fix statement leaks in other tests.
      sql/mysql_priv.h:
        Add declarations for new global variables.
      sql/mysqld.cc:
        Add definitions of max_prepared_stmt_count, prepared_stmt_count.
      sql/set_var.cc:
        Implement support for @@prepared_stmt_count and 
        @@max_prepared_stmt_count. Currently these variables are queried
        without acquiring LOCK_prepared_stmt_count due to limitations of
        the set_var/sys_var class design. Updates are, however, protected 
        with a lock.
      sql/set_var.h:
        New declarations to add support for @@max_prepared_stmt_count.
        Implement a new class, where the lock to be used when updating
        a variable is a parameter.
      sql/sql_class.cc:
        Add accounting of the total number of prepared statements in the
        server to the methods of Statement_map.
      sql/sql_class.h:
        Add accounting of the total number of prepared statements in the
        server to the methods of Statement_map.
      sql/sql_prepare.cc:
        Statement_map::insert will now send a message in case of an
        error.
      5b5530da
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-4.1 · e4e37ae5
      unknown authored
      into mysql.com:/M41/mtr-4.1
      
      
      e4e37ae5
    • unknown's avatar
      A fix and a test case for Bug#16248 "WHERE (col1,col2) IN ((?,?)) · 9b6e83f4
      unknown authored
      gives wrong results". Implement previously missing 
      Item_row::cleanup. The bug is not repeatable in 5.0, probably 
      due to a coincidence: the problem is present in 5.0 as well.
      
      
      mysql-test/r/ps.result:
        Update the result file (Bug#16248)
      mysql-test/t/ps.test:
        Add a test case for Bug#16248 "WHERE (col1,col2) IN ((?,?)) gives 
        wrong results"
      sql/item_row.cc:
        Implement Item_row::cleanup(): we should reset used_tables_cache
        before reexecution of a prepared statement. In case ROW
        arguments contain a placeholder, used_tables_cache has PARAM_TABLE
        bit set in statement prepare. As a result, when executing a statement,
        the condition push down algorithm (make_cond_for_table) would think
        that the WHERE clause belongs to the non-existent PARAM_TABLE and
        wouldn't attach the WHERE clause to any of the real tables, 
        effectively optimizing the clause away.
      sql/item_row.h:
        Remove a never used member 'array_holder'. Add declaration for
        Item_row::cleanup.
      9b6e83f4
    • unknown's avatar
      Manual merge. · a024fd69
      unknown authored
      a024fd69
    • unknown's avatar
      mysql-test/mysql-test-run.sh : Provide info about the options used. · 747f81c2
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        Provide info about the options used for this run to any evaluation tool.
      747f81c2
    • unknown's avatar
      mysql-test/mysql-test-run.pl : Add option "with-ndbcluster-only" (ignored). · 7bb18828
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Add option "with-ndbcluster-only" (ignored) for compatibility with newer "Do-compile".
      7bb18828
    • unknown's avatar
      Perl test script: Avoid some aborts, which made the whole build/test process terminate. · 8fc0c48d
      unknown authored
      
      mysql-test/lib/mtr_process.pl:
        Change from "mtr_error()" to "mtr_warning()" on some problems,
        because "error" makes the whole suite abort which then makes "Do-compile" terminate,
        so none of the following steps (including other etst suites) will be done.
      8fc0c48d
    • unknown's avatar
      mysql-test/mysql-test-run.sh : Add option "--with-ndbcluster-only" (backport from 5.1) · 6206e7c2
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        Manual merge from 4.0 (which was a 5.1 backport):
        "--with-ndbcluster" is already present,
        "--with-ndbcluster-only" is really usable here.
      6206e7c2
  3. 06 Apr, 2006 4 commits
    • unknown's avatar
      Backport of 5.1 test options "--with-ndbcluster" and "--with-ndbcluster-only" as dummies (ignored). · ff85ba77
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        Make "mysql-test-run.sh" accept (and ignore) the options "--with-ndbcluster" 
        and "--with-ndbcluster-only".
        This is necessary because newer build tools will issue them, and the test 
        script should tolerate that.
        Backport from 5.1 (Tomas Ulin, 2006-01-17)
      ff85ba77
    • unknown's avatar
      libmysql.c: · 00cfd1a7
      unknown authored
        Bug#18830: incompatibility new libraries with old server
        Don't execute SET NAMES with pre-4.1 server.
      
      
      libmysql/libmysql.c:
        Bug#18830: incompatibility new libraries with old server
        Don't execute SET NAMES with pre-4.1 server.
      00cfd1a7
    • unknown's avatar
      This problem has already been fixed by one of the previous changes. · 5475703b
      unknown authored
      Adding test case to cover queries which worked incorrectly earlier:
      Bug#18321: Can't store EuroSign with latin1_german1_ci and latin1_general_ci
      
      
      mysql-test/r/ctype_latin1.result:
        Adding test case for Bug#18321: Can't store EuroSign with latin1_german1_ci and latin1_general_ci
      mysql-test/t/ctype_latin1.test:
        Adding test case for Bug#18321: Can't store EuroSign with latin1_german1_ci and latin1_general_ci
      5475703b
    • unknown's avatar
      conf_to_src.c: · fafa4c5a
      unknown authored
        Backporting a 5.0 change:
        MAX_BUF was too small for Index.xml
        Changeing MAX_BUF and adding assert to easier
        catch the same problem in the future.
      ctype-extra.c:
        Regenerating ctype-extra.c with the fixed conf_to_src.
      
      
      strings/ctype-extra.c:
        Regenerating ctype-extra.c with the fixed conf_to_src.
      strings/conf_to_src.c:
        Backporting a 5.0 change:
        MAX_BUF was too small for Index.xml
        Changeing MAX_BUF and adding assert to easier
        catch the same problem in the future.
      fafa4c5a
  4. 03 Apr, 2006 4 commits
  5. 02 Apr, 2006 1 commit
    • unknown's avatar
      Makefile.am: · 6de1d9d3
      unknown authored
        Install Perl mysql-test-run into test directory
      
      
      mysql-test/Makefile.am:
        Install Perl mysql-test-run into test directory
      6de1d9d3
  6. 01 Apr, 2006 5 commits
    • unknown's avatar
      Makefile.am: · 2a4e2e8d
      unknown authored
        Let "make install" install mysql-test-run.pl
      mysql.spec.sh:
        Set $LDFLAGS from $MYSQL_BUILD_LDFLAGS (bug#16662)
      
      
      support-files/mysql.spec.sh:
        Set $LDFLAGS from $MYSQL_BUILD_LDFLAGS (bug#16662)
      mysql-test/Makefile.am:
        Let "make install" install mysql-test-run.pl
      2a4e2e8d
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · 3eb7f2a2
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-new
      
      
      README:
        Auto merged
      3eb7f2a2
    • unknown's avatar
      README: · c19a6fc5
      unknown authored
        Typo (bug#17167)
      
      
      README:
        Typo (bug#17167)
      c19a6fc5
    • unknown's avatar
      acinclude.m4: · 1f762dab
      unknown authored
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      
      
      acinclude.m4:
        Use CPPFLAGS when testing to link "libz" found in --with-zlib-dir=,
        and search the given include directory first (bug#18369)
      1f762dab
    • unknown's avatar
      vcproj files: · 0ad405f9
      unknown authored
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard
        code it into Visual Studio project files, bug#15974
      
      
      VC++Files/bdb/bdb.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/innobase/innobase.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/libmysqld/libmysqld.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/mysqldemb/mysqldemb.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/mysys/mysys.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      VC++Files/sql/mysqld.vcproj:
        Set MYSQL_SERVER_SUFFIX from build scripts, not hard code into project files, bug#15974
      0ad405f9
  7. 30 Mar, 2006 3 commits
  8. 29 Mar, 2006 11 commits
    • unknown's avatar
      Fix error in prefix compression of keys in MyISAM when key length changed from 254 -> 255 · 2d6a51b4
      unknown authored
      Bug #17705 "FT Index corruption occurs with UTF8 data..."
      (Actually, the bug had nothing to do with FT index but with general key compression)
      
      
      
      myisam/mi_search.c:
        Fix error in prefix compression of keys in MyISAM when key length changed from 254 -> 255
      mysql-test/r/ctype_utf8.result:
        Test of fix for key compression bug
      mysql-test/t/ctype_utf8.test:
        Test of fix for key compression bug
      2d6a51b4
    • unknown's avatar
      mysql-test-run.pl: · 3479ec37
      unknown authored
        Check that port range is valid, bug#16807
      
      
      mysql-test/mysql-test-run.pl:
        Check that port range is valid, bug#16807
      3479ec37
    • unknown's avatar
      mysqld_safe.sh: · 2d8acd2f
      unknown authored
        Added --help option, bug#16392
      acinclude.m4:
        Use "$shrext_cmds" when testing if shared library exists, bug#16332
      
      
      acinclude.m4:
        Use "$shrext_cmds" when testing if shared library exists, bug#16332
      scripts/mysqld_safe.sh:
        Added --help option, bug#16392
      2d8acd2f
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · 92df85b4
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-new
      
      
      92df85b4
    • unknown's avatar
      Makefile.am: · 113efc00
      unknown authored
        Use "dist_bin_SCRIPTS" to get a script distributed
      
      
      ndb/tools/Makefile.am:
        Use "dist_bin_SCRIPTS" to get a script distributed
      113efc00
    • unknown's avatar
      Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries · b2531546
      unknown authored
      The GROUP_CONCAT uses its own temporary table. When ROLLUP is present
      it creates the second copy of Item_func_group_concat. This copy receives the
      same list of arguments that original group_concat does. When the copy is
      set up the result_fields of functions from the argument list are reset to the
      temporary table of this copy.
      As a result of this action data from functions flow directly to the ROLLUP copy
      and the original group_concat functions shows wrong result.
      Since queries with COUNT(DISTINCT ...) use temporary tables to store
      the results the COUNT function they are also affected by this bug.
      
      The idea of the fix is to copy content of the result_field for the function
      under GROUP_CONCAT/COUNT from  the first temporary table to the second one,
      rather than setting result_field to point to the second temporary table.
      To achieve this goal force_copy_fields flag is added to Item_func_group_concat
      and Item_sum_count_distinct classes. This flag is initialized to 0 and set to 1
      into the make_unique() member function of both classes.
      To the TMP_TABLE_PARAM structure is modified to include the similar flag as
      well.
      The create_tmp_table() function passes that flag to create_tmp_field().
      When the flag is set the create_tmp_field() function will set result_field
      as a source field and will not reset that result field to newly created 
      field for Item_func_result_field and its descendants. Due to this there
      will be created copy func to copy data from old result_field to newly 
      created field.
      
      
      mysql-test/t/func_gconcat.test:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      mysql-test/r/func_gconcat.result:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      sql/sql_table.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added 0 as a last parameter to create_tmp_field()  to force old behaviour.
      sql/sql_select.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        
        Added the flag 'make_copy_field' to create_tmp_field(), so that for Item_result_field descendants create_tmp_field() sets the item's result field as a source field and deny resetting that result field to a new value.
      sql/sql_class.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the structure TMP_TABLE_PARAM in order to make create_tmp_field() force the creation of 'copy_field' objects.
      sql/mysql_priv.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the bool parameter 'make_copy_field' to create_tmp_field().
      sql/item_sum.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added initialization of the force_copy_fields flag and passing it to create_tmp_table() through TMP_TBLE_PARAM in the Item_func_group_concat and Item_sum_count_distinct member functions.
      sql/item_sum.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the Item_func_group_concat and Item_sum_count_distinct classes.
      b2531546
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.1 · c819b62b
      unknown authored
      into mysql.com:/home/gluh/MySQL/Merge/4.1
      
      
      c819b62b
    • unknown's avatar
      Fix for bug#15316 SET value having comma not correctly handled · 4af4e1e7
      unknown authored
       disallow the use of comma in SET members
      
      
      mysql-test/r/create.result:
        Fix for bug#15316 SET value having comma not correctly handled
         test case
      mysql-test/t/create.test:
        Fix for bug#15316 SET value having comma not correctly handled
         test case
      4af4e1e7
    • unknown's avatar
      mysql_config.sh: · 0fb36d1b
      unknown authored
        If installed, search built in lib path first, bug#13158
      
      
      scripts/mysql_config.sh:
        If installed, search built in lib path first, bug#13158
      0fb36d1b
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · 42750573
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-new
      
      
      42750573
    • unknown's avatar
      Makefile.am: · d800af4b
      unknown authored
        Install "ndb_size.pl" script and template, bug#18421
      
      
      ndb/tools/Makefile.am:
        Install "ndb_size.pl" script and template, bug#18421
      d800af4b
  9. 28 Mar, 2006 1 commit