1. 15 Jun, 2011 1 commit
  2. 14 Jun, 2011 1 commit
  3. 12 Jun, 2011 1 commit
  4. 14 Jun, 2011 1 commit
    • unknown's avatar
      Another attempt at fixing the rare random failures of rpl_corruption · 54fcd3b8
      unknown authored
      The previous patch partially fixed things by waiting for the old dump thread
      on the master to exit before injecting the DBUG error. This prevents the error
      injection going to the wrong thread.
      
      However, there is still the problem that the old dump thread may never exit,
      causing the wait to time out. This happens if the dump thread manages to write
      all events down the socket before the socket is closed by the slave. The
      master dump thread only checks for slave gone when writing a new event, so if
      no new events are generated, old dump threads can hang around forever on the
      master after the slave disconnects.
      
      Fix by explicitly killing the old dump thread if it is still around.
      54fcd3b8
  5. 13 Jun, 2011 1 commit
  6. 11 Jun, 2011 4 commits
  7. 10 Jun, 2011 6 commits
  8. 09 Jun, 2011 9 commits
    • Michael Widenius's avatar
      A bit better fix for tmp-table problem · 13f55aac
      Michael Widenius authored
      Fixed reference to not initialized memory detected by valgrind
      
      sql/sql_select.cc:
        A bit better fix for tmp-table problem:
        Use only dynamic_record format for group by and distinct.
      storage/maria/ma_create.c:
        DYNAMIC_RECORD format doesn't pack VARCHAR fields.
        This change fixes a non-fatal uninitialized memory copy.
      13f55aac
    • Michael Widenius's avatar
      9e3570ea
    • Michael Widenius's avatar
      Merge with bug fixes · 5831ddcf
      Michael Widenius authored
      5831ddcf
    • Michael Widenius's avatar
      Use dynamic row format when creating temporary tables without sumary fields. · 97e834e1
      Michael Widenius authored
      The reason for this is that BLOCK_RECORD format is not good when there is a lot of duplicated keys as it first writes the data (to get the row position) and
      then writes the key (and thus checks for duplicates).
      97e834e1
    • Sergei Golubchik's avatar
      small optimization in Field_time_hires. · fdfeb4be
      Sergei Golubchik authored
      Fix Field_time_hires::reset()
      fdfeb4be
    • Sergei Golubchik's avatar
      bugfixes: · c3f665dc
      Sergei Golubchik authored
        microsecond(TIME)
        alter table datetime<->datetime(6)
        max(TIME), mix(TIME) 
      
      mysql-test/t/func_if.test:
        fix the test case of avoid overflow
      sql/field.cc:
        don't use make_date() and make_time()
      sql/field.h:
        correct eq_def() for temporal fields
      sql/item.cc:
        move datetime caching from Item_cache_int
        to Item_cache_temporal
      sql/item.h:
        move datetime caching from Item_cache_int
        to Item_cache_temporal
      sql/item_func.cc:
        use existing helper methods, don't duplicate
      sql/item_sum.cc:
        argument cache must use argument's cmp_type, not result_type.
      sql/item_timefunc.cc:
        use existing methods, don't tuplicate.
        remove unused function.
        fix micorseconds() to support TIME argument
      sql/mysql_priv.h:
        dead code
      sql/time.cc:
        dead code
      c3f665dc
    • Michael Widenius's avatar
      Fixed problem that global status variables 'bytes_recieved' and... · 3600e6b8
      Michael Widenius authored
      Fixed problem that global status variables 'bytes_recieved' and 'binlog_bytes_written' where not correctly updated 
      3600e6b8
    • Michael Widenius's avatar
      Fixed compile failure when we don't use system zlib · 60bd2133
      Michael Widenius authored
      Fixed crash when setting query_cache_type to 0.
      
      client/Makefile.am:
        Added zlib include (needed by checksum.c)
      sql/set_var.cc:
        Updated call to disable_query_cache()
      sql/sql_cache.cc:
        Don't give warning if we start mysqld with --query_cache_type=0 --query_cache-size=0
        Fixed crash when setting query_cache_type to 0 (we shouldn't call query_cache.disable_query_cache() when there is no current_thd)
      sql/sql_cache.h:
        Added THD to disable_query_cache()
      60bd2133
    • Michael Widenius's avatar
      Fixed build failure on OpenSolaris · 163d7acc
      Michael Widenius authored
      strings/ctype-simple.c:
        Fixed some compiler warnings
      163d7acc
  9. 08 Jun, 2011 2 commits
  10. 07 Jun, 2011 5 commits
  11. 06 Jun, 2011 5 commits
    • Igor Babaev's avatar
      Fixed LP bug #784441. · 059aff15
      Igor Babaev authored
      The code that added semi-join transformations missed checking
      the state of the fixed flag for the items built with the
      and_items function before calls of the fix_fields method.
      This could lead to an abort failure when the first argument
      of and_items() happened to be NULL.
       
      059aff15
    • Sergei Golubchik's avatar
      revert a suggested "optimization" that introduced a bug · 4d128777
      Sergei Golubchik authored
      compilation error in mysys/my_getsystime.c fixed
      some redundant code removed
      sec_to_time, time_to_sec, from_unixtime, unix_timestamp, @@timestamp now
        use decimal, not double for numbers with a fractional part.
      purge_master_logs_before_date() fixed
      many bugs in corner cases fixed
      
      mysys/my_getsystime.c:
        compilation failure fixed
      sql/sql_parse.cc:
        don't cut corners. it backfires.
      4d128777
    • Michael Widenius's avatar
      29af1aef
    • Michael Widenius's avatar
      Fixed that SHOW COLUMNS for a virtual persistent column shows 'PERSISTENT' instead of 'VIRTUAL' · 7e04f7c8
      Michael Widenius authored
      Strict mode now gives error if one tries to update a virtual column.
      
      mysql-test/suite/vcol/r/vcol_column_def_options_innodb.result:
        Updated test results
      mysql-test/suite/vcol/r/vcol_column_def_options_myisam.result:
        Updated test results
      mysql-test/suite/vcol/r/vcol_keys_innodb.result:
        Updated test results
      mysql-test/suite/vcol/r/vcol_keys_myisam.result:
        Updated test results
      mysql-test/suite/vcol/r/vcol_misc.result:
        Added new test for 'show columns' and error handling when trying to update a virtual column.
      mysql-test/suite/vcol/t/vcol_misc.test:
        Added new test for 'show columns' and error handling when trying to update a virtual column.
      sql/sql_base.cc:
        Strict mode now gives error if one tries to update a virtual column.
      sql/sql_show.cc:
        Show PERSISTENT instead of VIRTUAL for persistent columns.
      7e04f7c8
    • Michael Widenius's avatar
      Fixed lock sorting and lock check issues with thr_lock that caused warnings... · 6ae42b75
      Michael Widenius authored
      Fixed lock sorting and lock check issues with thr_lock that caused warnings when running test suite.
      Safety check that could cause core dump when doing create table with virtual column.
      
      mysql-test/mysql-test-run.pl:
        Show also warnings from thr_lock (which starts with just Warning, not Warning:)
      mysql-test/r/lock.result:
        Added test that showed not relevant warning when using table locks.
      mysql-test/t/lock.test:
        Added test that showed not relevant warning when using table locks.
      mysys/thr_lock.c:
        Fixed sorting of locks.
        (Old sort code didn't handle case where TL_WRITE_CONCURRENT_INSERT must be sorted before TL_WRITE)
        Added more information to check_locks warning output.
        Fixed wrong testing of multiple different write locks for same table.
      sql/item_cmpfunc.cc:
        Safety check that could cause core dump when doing create table with virtual column.
      6ae42b75
  12. 03 Jun, 2011 4 commits