Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
N
neo
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
Kirill Smelkov
neo
Commits
4bedfba7
Commit
4bedfba7
authored
Jan 29, 2021
by
Kirill Smelkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
.
parent
6409111e
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
4 deletions
+5
-4
go/neo/mastered.go
go/neo/mastered.go
+5
-4
No files found.
go/neo/mastered.go
View file @
4bedfba7
...
...
@@ -127,7 +127,6 @@ func newMasteredNode(typ proto.NodeType, clusterName string, net xnet.Networker,
}
// TalkMaster dials master, identifies to it, and receives master notifications and requests.
//
// Notifications to node/partition tables and cluster state are automatically
...
...
@@ -161,8 +160,10 @@ func (node *_MasteredNode) TalkMaster(ctx context.Context, f func(context.Contex
})
err
:=
node
.
talkMaster1
(
ctx
,
ctx0
,
f
)
log
.
Warning
(
ctx
,
err
)
// XXX Warning ok? -> Error?
// TODO if err == "reject identification / protocol error" -> shutdown client
// TODO if err == shutdown -> return
if
errors
.
Is
(
err
,
cmdShutdown
)
{
return
err
// M commands to shutdown
}
// TODO if err == "reject identification / protocol error" -> shutdown client?
// TODO if err == "not a primary" -> try redirected address
// exit on cancel / throttle reconnecting
...
...
@@ -445,7 +446,7 @@ func (node *_MasteredNode) updateNodeTab(ctx context.Context, msg *proto.NotifyN
}
}
//
FIXME
logging under lock ok? (if caller took e.g. .opMu before applying updates)
//
XXX
logging under lock ok? (if caller took e.g. .opMu before applying updates)
log
.
Infof
(
ctx
,
"full nodetab:
\n
%s"
,
node
.
state
.
NodeTab
)
return
nil
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment