Commit df579315 authored by Kirill Smelkov's avatar Kirill Smelkov

.

parent f615b0e2
// Copyright (C) 2017-2018 Nexedi SA and Contributors. // Copyright (C) 2017-2021 Nexedi SA and Contributors.
// Kirill Smelkov <kirr@nexedi.com> // Kirill Smelkov <kirr@nexedi.com>
// //
// This program is free software: you can Use, Study, Modify and Redistribute // This program is free software: you can Use, Study, Modify and Redistribute
......
// Copyright (C) 2017-2020 Nexedi SA and Contributors. // Copyright (C) 2017-2021 Nexedi SA and Contributors.
// Kirill Smelkov <kirr@nexedi.com> // Kirill Smelkov <kirr@nexedi.com>
// //
// This program is free software: you can Use, Study, Modify and Redistribute // This program is free software: you can Use, Study, Modify and Redistribute
...@@ -46,7 +46,7 @@ Run NEO master node. ...@@ -46,7 +46,7 @@ Run NEO master node.
func masterMain(argv []string) { func masterMain(argv []string) {
flags := flag.NewFlagSet("", flag.ExitOnError) flags := flag.NewFlagSet("", flag.ExitOnError)
flags.Usage = func() { masterUsage(os.Stderr); flags.PrintDefaults() } // XXX prettify flags.Usage = func() { masterUsage(os.Stderr); flags.PrintDefaults() }
netSetup := netFlags(flags) netSetup := netFlags(flags)
cluster := flags.String("cluster", "", "cluster name") cluster := flags.String("cluster", "", "cluster name")
// XXX masters here too? // XXX masters here too?
......
// Copyright (C) 2016-2020 Nexedi SA and Contributors. // Copyright (C) 2016-2021 Nexedi SA and Contributors.
// Kirill Smelkov <kirr@nexedi.com> // Kirill Smelkov <kirr@nexedi.com>
// //
// This program is free software: you can Use, Study, Modify and Redistribute // This program is free software: you can Use, Study, Modify and Redistribute
...@@ -63,7 +63,7 @@ XXX currently storage is read-only. ...@@ -63,7 +63,7 @@ XXX currently storage is read-only.
func storageMain(argv []string) { func storageMain(argv []string) {
flags := flag.NewFlagSet("", flag.ExitOnError) flags := flag.NewFlagSet("", flag.ExitOnError)
flags.Usage = func() { storageUsage(os.Stderr); flags.PrintDefaults() } // XXX prettify flags.Usage = func() { storageUsage(os.Stderr); flags.PrintDefaults() }
netSetup := netFlags(flags) netSetup := netFlags(flags)
cluster := flags.String("cluster", "", "the cluster name") cluster := flags.String("cluster", "", "the cluster name")
masters := flags.String("masters", "", "list of masters") masters := flags.String("masters", "", "list of masters")
...@@ -95,6 +95,9 @@ func storageMain(argv []string) { ...@@ -95,6 +95,9 @@ func storageMain(argv []string) {
// https://github.com/golang/go/issues/6817 // https://github.com/golang/go/issues/6817
// //
// XXX check how varying this affects performance // XXX check how varying this affects performance
//
// NOTE should be not needed once, hopefuly, Go runtime uses io_uring for IO
// https://github.com/golang/go/issues/31908
maxprocs := runtime.GOMAXPROCS(0) maxprocs := runtime.GOMAXPROCS(0)
runtime.GOMAXPROCS(maxprocs*8) // XXX *8 is enough? runtime.GOMAXPROCS(maxprocs*8) // XXX *8 is enough?
...@@ -116,7 +119,7 @@ func storageMain(argv []string) { ...@@ -116,7 +119,7 @@ func storageMain(argv []string) {
return stor.Run(ctx, l) return stor.Run(ctx, l)
}) })
// XXX back.Close // XXX back.Close here or in Storage?
if err != nil { if err != nil {
prog.Fatal(err) prog.Fatal(err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment