git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@327 71dcc9de-d417-0410-9af5-da40c76e7ee4

Move "lock" calls outside of "try" block: if "lock" call raises, there are chances "unlock" call from "finally" will also raise, and hide original exception.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@326 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@325 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@324 71dcc9de-d417-0410-9af5-da40c76e7ee4

 - There is no need for dispatcher to be a thread
 - Polling thread does not need to be a dispatcher
In turns, this allows simplifying Storage.__init__ by moving Dispatcher, ThreadedPoll and EventManager class instantiations to App class.
Add a TODO about missing ThreadedPoll shutdown.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@323 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@322 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@321 71dcc9de-d417-0410-9af5-da40c76e7ee4

Move connectToPrimaryMasterNode from Dispatcher class to App class since it does not functionally belong to dispatcher.
This simplifies connectToPrimaryMasterNode code and startup code a bit:
 - connectToPrimaryMasterNode does not need to manually poll to get a response (we use normal code for this)
   This removes a difference between initial master connection and a reconnection.
 - make App instance get a workable dispatcher from the beginning
 - make App handle initial master connection instead of Storage
 - rename "connector" parameter of connectToPrimaryMasterNode into "connector_handler", since it's what it really is
Update caller (ClientEventHandler class).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@320 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@319 71dcc9de-d417-0410-9af5-da40c76e7ee4

 - One to handle events expected as answers only, and to treat in their own thread.
 - One to handle all other events, and to tread them in dispatcher thread.
Update "expected answer" caller (app.py's _waitMessage).
Update test.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@318 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@317 71dcc9de-d417-0410-9af5-da40c76e7ee4

Remove explicit locking from one caller.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@316 71dcc9de-d417-0410-9af5-da40c76e7ee4

Test for partition table readiness at the end of the loop before sleeping rather than at the begining.
 - prevents from sleeping before exiting the loop in the even of a successful connection attemp
 - partition table got flushed a few lines above, so this test is always true on the first loop iteration.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@315 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@314 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@313 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@312 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@311 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@310 71dcc9de-d417-0410-9af5-da40c76e7ee4

Note: there are 3 unimplemented tests (raising NotImplementedError).
 test_StopOperation: looks unimplemented in current code (no action besides logging).
 test_knownMasterNotifyNodeInformation & test_unknownMasterNotifyNodeInformation: it is yet unsure on how to test those cases.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@309 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@308 71dcc9de-d417-0410-9af5-da40c76e7ee4

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to make it unit-test-friendly: Client node does not have any listening socket, so there cannot be any (MT)ServerConnection instance used to reach handler. Also, Multi-Thread safety is not a runtime but a static criterion (ie, it is most likely a bug to use non-multi-thread-safe Connection subclasses in client). So this test is an always-true check, and can be removed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@307 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@306 71dcc9de-d417-0410-9af5-da40c76e7ee4

Change "if" into "elif": it is obviously wrong to call app.master_conn.getUUID() on None, so this test should only be executed in "not None" case.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@305 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@304 71dcc9de-d417-0410-9af5-da40c76e7ee4

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and similar). This makes things easier to unit test.
Add missing imports.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@303 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@302 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@301 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@300 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@299 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@298 71dcc9de-d417-0410-9af5-da40c76e7ee4

rows are the same rows thanks to implicit pointer


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@297 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@296 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@295 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@294 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@293 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@292 71dcc9de-d417-0410-9af5-da40c76e7ee4

fix class name


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@291 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@290 71dcc9de-d417-0410-9af5-da40c76e7ee4

Revert commit 254: super(MTClientConnection, self).__init__ sends self to event_manager, which registers it to epoll, and epoll_wait is pending in another thread. So this lock is really needed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@289 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@288 71dcc9de-d417-0410-9af5-da40c76e7ee4