Commits · b37d9755a71eb019e537b7547c4eb3438d899f4b · Kirill Smelkov / neo

29 Jan, 2010 14 commits

Remove useless 'elif' statement. · b37d9755

Grégory Wisniewski authored Jan 29, 2010

This condition is always true as the primary_node was found by UUID.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1556 71dcc9de-d417-0410-9af5-da40c76e7ee4

b37d9755

Handle askPrimary packet as unexpected in ClientElectionHandler. · 5572c34e
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1555 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5572c34e

Attribute access simplification. · ca9dd7b4

Grégory Wisniewski authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1554 71dcc9de-d417-0410-9af5-da40c76e7ee4

ca9dd7b4

Fix EpollEvent structure declaration. · c9bca6b6

Vincent Pelletier authored Jan 29, 2010

This fixes strange epoll results (yielding unknown file descriptors).
There is no explanation as of why it worked in 64bits until now.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1553 71dcc9de-d417-0410-9af5-da40c76e7ee4

c9bca6b6

Factorise calls to electPrimary. · bfd97ea5

Vincent Pelletier authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1552 71dcc9de-d417-0410-9af5-da40c76e7ee4

bfd97ea5

Renumber ClusterStates enum entries. · 02311d51

Vincent Pelletier authored Jan 29, 2010

Consequence of previous commit, to preserve code clarity.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1551 71dcc9de-d417-0410-9af5-da40c76e7ee4

02311d51

Remove BOOTING cluster state. · dbd027a9

Vincent Pelletier authored Jan 29, 2010

This state was only internal to master node, and was not even
consistently handled in master (only the first election was done in that
state).
changeClusterState was never called with that state as parameter.
Finally, remove this state from protocol as it's not used any longer.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1550 71dcc9de-d417-0410-9af5-da40c76e7ee4

dbd027a9

During election, node timeout applies or all non-running nodes. · 7147f291

Grégory Wisniewski authored Jan 29, 2010

So that unknown nodes, to which no connection succeed for the current election, are dropped from election process.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1549 71dcc9de-d417-0410-9af5-da40c76e7ee4

7147f291

When an election restart, assume all masters are unknown and candidates for election. · 78dab7fd
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1548 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
78dab7fd

Reduce indentation. · 5e98e011

Grégory Wisniewski authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1547 71dcc9de-d417-0410-9af5-da40c76e7ee4

5e98e011

Add missing setUnknown() on node class. · fced5fdd
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1546 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fced5fdd
Add assertions to avoid bad node state transitions. · 09c05b4d
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1545 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
09c05b4d
Factorise connectionClosed and timeoutExpired logic. · 6b10848f
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1544 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6b10848f
Call super methods and remove wrong call to 'connectionFailed' · e92d528c
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1543 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e92d528c

28 Jan, 2010 22 commits

Typo, call append() instead of add() on the list. · 3973e15a
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1542 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3973e15a

Some changes in election: · dab39147

Grégory Wisniewski authored Jan 28, 2010

- Nodes start in UNKNOWN state.
- Running and Unknown nodes are candidates during election.
- Set temporarily down if an established connection is lost.
- Keep in unknown state if a connection fails.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1541 71dcc9de-d417-0410-9af5-da40c76e7ee4

dab39147

Bug fix: Avoid open two connections to the same node. · 8fc436a8

Grégory Wisniewski authored Jan 28, 2010

After the AnswerPrimary was received, the unconnected_master_node_set was filled with the primary address, causing a new connection at the next iteration in the _doElection method.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1540 71dcc9de-d417-0410-9af5-da40c76e7ee4

8fc436a8

Add a test to ensure election success with many master nodes. · 761860a2
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1539 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
761860a2
Rename packet NO_ERROR error packet type to ACK as it's confusing. · c5f970c9
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1538 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c5f970c9

Add missing helper method. · 0e4276ac

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1537 71dcc9de-d417-0410-9af5-da40c76e7ee4

0e4276ac

Fix broken tests since getAssignedPartitionList() · 6535cb41
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1536 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6535cb41

Simplify code pattern. · bbc7069f

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1535 71dcc9de-d417-0410-9af5-da40c76e7ee4

bbc7069f

Remove useless if: no need to check the list before iterate over. · 171c6592
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1534 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
171c6592
Factorize gathering of assigned partitions. · 8f1fa695
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1533 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8f1fa695
Redirect logs of applications running in test process to their own logfile. · 2dc227f8
Vincent Pelletier authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1532 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2dc227f8

Avoid handling events for a file descriptor more than once per _poll call. · 46a40237

Vincent Pelletier authored Jan 28, 2010

A single fd might be reported more than once per epoll call. This causes
the associated connection to be registered multiple times, which in turn
causes problems when the first connection registration gets emptied:
handling events of the second registration will raise an error when trying
to fetch a packet from an empty list.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1531 71dcc9de-d417-0410-9af5-da40c76e7ee4

46a40237

Remove trailing whitespaces. · 66cd62e9

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1530 71dcc9de-d417-0410-9af5-da40c76e7ee4

66cd62e9

Set TCP_NODELAY on socket connections. · face448b
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1529 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
face448b
Increase a bit the size allowed for a node name. · 1b831534
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1528 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1b831534
Add a TODO to implement restore() ZODB API method. · dd597f65
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1527 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dd597f65
Add a TODO for caching previous object revisions. · 5daeb4de
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1526 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5daeb4de
Add test for transaction isolation. · 08987a17
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1525 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08987a17
Returns the connection instead of root object in makeTransaction. · 240922ef
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1524 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
240922ef
Handle 'broken pipe' errors as a connection closed. · b18bc173
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1523 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b18bc173
Fix test: ProtocolError is raised instead of UnexpectedPackeError. · 0d67025e
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1522 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0d67025e

Remove 'address' argument from AcceptIdentification packet. · c8dabbff

Grégory Wisniewski authored Jan 28, 2010

This argument is useless as the peer who receive this packet is the one who starts the connection, so it already knows the peer remote address.
Remove related (useless) checks and update unit tests.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1521 71dcc9de-d417-0410-9af5-da40c76e7ee4

c8dabbff

27 Jan, 2010 4 commits

Remove a logging message and the related try/finally block. · 6445101c
Grégory Wisniewski authored Jan 27, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1520 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6445101c

Don't catch UnexpectedPacketError. · 3ac8eab4

Grégory Wisniewski authored Jan 27, 2010

Packet logger returns None is not implemented.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1519 71dcc9de-d417-0410-9af5-da40c76e7ee4

3ac8eab4

Update conflict resolution test. · 65d90cfd

Grégory Wisniewski authored Jan 27, 2010

Ensure that ConflictError is raised if _p_resolveConflict is not implemented.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1518 71dcc9de-d417-0410-9af5-da40c76e7ee4

65d90cfd

Fix test that were broken since r1498. · 80948fb7
Grégory Wisniewski authored Jan 27, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1517 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
80948fb7