1. 16 May, 2019 7 commits
    • pygolang v0.0.2 · d3bfb1bf
      Kirill Smelkov committed
    • context: Add support for deadlines · b2450310
      Implement deadlines / timeouts using timers added recently in 9c260fde
      (time: New package that mirrors Go's time).
      Kirill Smelkov committed
    • context: tests: Factor out common bits from test_context · 27f91b78
      In the next patch we'll be adding deadlines support with another test.
      Move common infrastructure that will be used in all context tests to be
      test-module global.
      Kirill Smelkov committed
    • context: Don't hardcode that contexts are always done with canceled error · e5687f2f
      We'll need to mark contexts that miss their deadline with
      deadlineExceeded error in a follow-up patch.
      In this patch: transform _BaseCtx._cancel to accept an error with which
      a context has to be canceled, but for now always use canceled in places
      where _cancel is called.
      Kirill Smelkov committed
    • context: Note that a context has to be explicitly canceled to release resources · 58ba1765
      Same story as in Go, but we were lacking documentation notice about this.
      Kirill Smelkov committed
    • time: New package that mirrors Go's time · 9c260fde
      Add time.Timer, time.Ticker and convenience functions time.tick,
      time.after and time.after_func. These will be used in context to support
      deadlines and timeouts.
      While at time topic, also provide sleep and now from golang.time, so
      that there is no need to import both golang.time and stdlib's time in a
      Provide time constants in the module as they are useful to have and
      mirror constants provided by Go's time.
      Note: timers implementation is very suboptimal for now.
      Kirill Smelkov committed
    • golang: Don't keep test programs inside golang/ dir · 6e3b3ff4
      Python adds dirname of run program to sys.path . This way when
      golang_test_goleaked.py runs it can import modules located under golang/
      just by their name. Until now this was not noticed, but in the next
      patch we are going to add golang.time module and if test program is run
      with golang/ in sys.path just plain `import time` won't import time from
      stdlib and instead import time from golang/ .
      Such behaviour can be mitigated by doing `from __future__ import
      absolute_import` and we do that, including in golang_test_goleaked.py
      (see 81dfefa0 "*: __future__ += absolute_imports; Use unified __future__
      everywhere"). However that does not prevent modules - even modules from
      stdlib - who are doing `import time` and not doing future
      absolute_import to import golang's time instead of stdlib. For example
      on PyPy2 threading imports time and then the test breaks:
        Traceback (most recent call last):
          File "/home/kirr/src/tools/go/pygolang/.tox/pypy-thread/site-packages/golang/golang_test_goleaked.py", line 24, in <module>
            from golang import go, chan
          File "/home/kirr/src/tools/go/pygolang/.tox/pypy-thread/site-packages/golang/__init__.py", line 38, in <module>
            import inspect, threading, collections, random, sys
          File "/usr/lib/pypy/lib-python/2.7/threading.py", line 15, in <module>
            from time import time as _time, sleep as _sleep
          File "/home/kirr/src/tools/go/pygolang/.tox/pypy-thread/site-packages/golang/time.py", line 30, in <module>
            from golang import go, chan, select, default, nilchan, panic
        ImportError: cannot import name 'go'
      -> Move the test program into a directory different from golang/ to
      avoid this trap.
      Kirill Smelkov committed
  2. 14 May, 2019 1 commit
  3. 10 May, 2019 1 commit
    • fixup! pygolang v0.0.1 · 1172e39f
      - correct CHANGELOG title levels: since readme uses "----" for the
        first level and "~~~~" for the second level, "====" was interpreted as
        the third title level and "Pygolang change history" became
        sub-sub-section of "Additional packages and utilities" with section
        for each version conversely becoming first level. It was not very
        noticeable until 0c5f9d06 (readme: Push "Additional packages and
        utilities" into its own section) started to use "~~~~".
        -> Rework CHANGELOG titling to align with the one in README.
      - fix minor markup bits in README.
      Kirill Smelkov committed
  4. 09 May, 2019 1 commit
  5. 03 May, 2019 3 commits
  6. 02 May, 2019 2 commits
  7. 24 Mar, 2019 3 commits
    • golang: Kill @method · 262f8986
      It was deprecated and scheduled to be removed in 942ee900 (golang:
      Deprecate @method(cls) in favour of @func(cls)).
      Kirill Smelkov committed
    • pygolang v0.0.0.dev8 · 0f60aa77
      Kirill Smelkov committed
    • gpython: Workaround PyPy2 vs Gevent patch_thread crash · 704d99f0
      	pypy-gevent runtests: commands[0] | gpython -m pytest gpython/ golang/
      	Traceback (most recent call last):
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/bin/gpython", line 10, in <module>
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/site-packages/gpython/__init__.py", line 153, in main
      	    _ = monkey.patch_all()      # XXX sys=True ?
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/site-packages/gevent/monkey.py", line 976, in patch_all
      	    patch_thread(Event=Event, _warnings=_warnings)
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/site-packages/gevent/monkey.py", line 178, in ignores
      	    return func(*args, **kwargs)
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/site-packages/gevent/monkey.py", line 588, in patch_thread
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy-gevent/site-packages/gevent/monkey.py", line 492, in _patch_existing_locks
      	    if o._RLock__owner is not None:
      	AttributeError: 'thread.RLock' object has no attribute '_RLock__owner'
      It will be fixed on next Gevent release, however until then the crash is there
      and we have to workaround: we can skip patching existing locks as it will be
      the same behaviour of next Gevent release, since its just not possible to patch
      locks created via instantiated C-level classes:
      We are doing monkey-patching very early, so it should be safe.
      Kirill Smelkov committed
  8. 20 Mar, 2019 1 commit
    • golang: Deflake channel tests · 731f39e3
      Channel tests are passing on an idle machine. However if there is
      another load - e.g. in the presence of simultaneous Firefox start,
      channel tests break, for example:
      	    def test_select():
      	        # non-blocking try recv: ok
      	        ch = chan()
      	        done = chan()
      	        def _():
      	            for i in range(N):
      	        for i in range(N):
      	            if i % 2:
      	                _, _rx = select(
      	                assert (_, _rx) == (0, i)
      	                _, _rx = select(
      	>               assert (_, _rx) == (0, (i, True))
      	E               assert (1, None) == (0, (320, True))
      	E                 At index 0 diff: 1 != 0
      	E                 Use -v to get the full diff
      	golang_test.py:209: AssertionError
      The failure here is that it was default case selected, not ch.recv_. The
      default was selected because the sending goroutine was not fast to
      enqueue next send before we tried to receive. We were trying to make
      sure that the sender will be enqueued first via adding 1ms time delay
      before trying to receive, but in the presence of concurrent load spikes
      that turns out to be not enough.
      We could try to fix the test by increasing the time to sleep in tdelay,
      make the tests more slow and still not 100% reliable. However we can
      change the tests to instead actually wait for the condition that is
      semantically required: a sender enqueued on the channel.
      Do that everywhere where tdelay was used.
      Now tests are faster (it was ~3s total, now it is ~ 0.5s total) and pass
      irregardless of whether the machine is idle or otherwise loaded.
      Kirill Smelkov committed
  9. 19 Mar, 2019 3 commits
    • tox -= Python3.6 · 469f21a9
      Debian dropped Python3.6 from python3-distutils. Without it I'm no
      longer being able to run tests on that python version:
      	(neo) (z-dev) (g.env) kirr@deco:~/src/tools/go/pygolang$ tox -e py36-thread
      	execution failed:  -- Traceback (most recent call last):
      	  File "<string>", line 1, in <module>
      	ModuleNotFoundError: No module named 'distutils.sysconfig'
      	GLOB sdist-make: /home/kirr/src/tools/go/pygolang/setup.py
      	py36-thread create: /home/kirr/src/tools/go/pygolang/.tox/py36-thread
      	ERROR: invocation failed (exit code 1), logfile: /home/kirr/src/tools/go/pygolang/.tox/py36-thread/log/py36-thread-0.log
      	ERROR: actionid: py36-thread
      	msg: getenv
      	cmdargs: '/usr/bin/python3 -m virtualenv --python /usr/bin/python3.6 py36-thread'
      	Traceback (most recent call last):
      	  File "/usr/lib/python3/dist-packages/virtualenv.py", line 25, in <module>
      	    import distutils.sysconfig
      	ModuleNotFoundError: No module named 'distutils.sysconfig'
      	Running virtualenv with interpreter /usr/bin/python3.6
      	ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('/usr/bin/python3 -m virtualenv --python /usr/bin/python3.6 py36-thread (see /home/kirr/src/tools/go/pygolang/.tox/py36-thread/log/py36-thread-0.log)', 1)
      Kirill Smelkov committed
    • gpython: Don't check for time not being pre-imported on PyPy · e847c550
      PyPy7 always pre-imports the time module. Without the change tests were
      	Traceback (most recent call last):
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy3-gevent/bin/gpython", line 10, in <module>
      	  File "/home/kirr/src/tools/go/pygolang/.tox/pypy3-gevent/site-packages/gpython/__init__.py", line 145, in main
      	    '\n\n\t%s\n\nsys.modules:\n\n\t%s' % (bad, sysmodv))
      	RuntimeError: gpython: internal error: the following modules are pre-imported, but must be not:
      	        ['__future__', '__main__', '__pypy__', '__pypy__._pypydatetime', '__pypy__.builders', '__pypy__.intop', '__pypy__.os', '__pypy__.thread', '__pypy__.time', '_ast', '_bootlocale', '_codecs', '_collections', '_collections_abc', '_continuation', '_csv', '_frozen_importlib', '_frozen_importlib_external', '_imp', '_io', '_locale', '_multibytecodec', '_operator', '_rawffi', '_rawffi.alt', '_signal', '_sre', '_structseq', '_thread', '_warnings', '_weakref', '_weakrefset', 'abc', 'array', 'builtins', 'codecs', 'copyreg', 'encodings', 'encodings.aliases', 'encodings.ascii', 'encodings.latin_1', 'encodings.utf_8', 'errno', 'gc', 'genericpath', 'gpython', 'marshal', 'os', 'os.path', 'posix', 'posixpath', 'pwd', 're', 'site', 'sre_compile', 'sre_constants', 'sre_parse', 'stat', 'sys', 'time', 'unicodedata']
      Kirill Smelkov committed
    • tox += PyPy3 · da68a8ae
      Debian started to ship PyPy3:
      Kirill Smelkov committed
  10. 15 Mar, 2019 1 commit
    • golang: Deprecate @method(cls) in favour of @func(cls) · 942ee900
      Since we already have func (see 5146eb0b "Add support for defer &
      recover") we can use @func for both plain functions and for methods.
      For example instead of
      	def my_function(...):
      	@method(MyClass)			<-- NOTE
      	def my_method(self, ...):
      have it as
      	def my_function(...):
      	@func(MyClass)				<-- NOTE
      	def my_method(self, ...):
      which looks more similar to Go and exposes less golang keywords to a user.
      Kirill Smelkov committed
  11. 13 Mar, 2019 1 commit
    • gpython: Fix pymain to properly setup sys.path[0] · 6b4990f6
      Pymain was not adding e.g. directory of executed file to sys.path, and
      as the result if there were e.g. 2 files
      	dir/hello.py	# imports world
      running `gpython dir/hello.py` would fail to import world.
      The case for interactive console was also failing to setup sys.argv as
      empty, so it was containing ['/path/to/gpython']. It was also, contrary
      to standard python, unconditionally showing '>>>' prompt even when stdin
      was not a tty.
      Fix all that and add a test to cover pymain functionality.
      Kirill Smelkov committed
  12. 16 Jan, 2019 6 commits
  13. 30 Dec, 2018 1 commit
  14. 13 Dec, 2018 4 commits
  15. 31 Oct, 2018 1 commit
  16. 30 Oct, 2018 4 commits
    • pygolang v0.0.0.dev5 · 8424abe0
      Kirill Smelkov committed
    • Add support for defer & recover · 5146eb0b
      `defer` allows to schedule a cleanup to be executed when current function
      returns. It is similar to `try`/`finally` but does not force the cleanup part
      to be far away in the end. For example::
         wc = wcfs.join(zurl)    │     wc = wcfs.join(zurl)
         defer(wc.close)         │     try:
                                 │        ...
         ...                     │        ...
         ...                     │        ...
         ...                     │     finally:
                                 │        wc.close()
      For completeness there is `recover` and `panic` that allow to program with
      Go-style error handling, for example::
         def _():
            r = recover()
            if r is not None:
               print("recovered. error was: %s" % (r,))
      But `recover` and `panic` are probably of less utility since they can be
      practically natively modelled with `try`/`except`.
      If `defer` is used, the function that uses it must be wrapped with `@func` or
      `@method` decorators.
      The implementation is partly inspired by work of Denis Kolodin:
      - https://habr.com/post/191786
      - https://stackoverflow.com/a/43028386/9456786
      Kirill Smelkov committed
    • select: Don't let both a queued and a tried cases win at the same time · f0b592b4
      While the second phase of select is running we queue send/recv cases to
      corresponding channels. At some point - when some of the cases are
      already queued - a peer goroutine might try to send/recv on that
      channel. And it will succeed because a waiter was queued to the channel.
      At the same time select is continuing its enqueue loop and before enqueuing
      to a channel it tries to send/recv there. If that channel became just ready
      (i.e. just after select poll phase) the try to send/recv will succeed. This
      means that actually 2 select cases could be executed at the same time.
      Fix it by carefully checking whether some case already won before trying
      to send/recv on a channel.
      This fixes the test failures that were demonstrated by previous 2 patches.
      Kirill Smelkov committed
    • select: Another select-select test which reuses channels during iterations · 2fc6797c
      Previous select-select test uses 2 channels and recreats them every
      iteration. However the bug we just saw in b51b8d5d (select: Run tests
      more thoroughly) is of parasitic nature - where misbehaviour depends on
      what state has been left there from previous select and whether the race
      to get to that state fast enough succeeded.
      So add a more secialized test which tries to trigger the parasitic
      effects that depend on previous state left by select on the channels.
      The test, similarly to b51b8d5d, currently fails.
      Kirill Smelkov committed