2.6

README.md

@@ -2,10 +2,10 @@
 
 Building non-python shared libraries (eg. `libY.so`, `libY.dylib`, or `Y.dll`) for inclusion in a Python Wheel.
 
-This extension provides at alternative to bundling externally built
-libraries in Python Wheel packages.  This replaces an external
-build system (eg. Makefile), allowing non-python libraries to be
-built from source within the python ecosystem.
+This extension is an alternative to bundling externally built
+libraries in Python Wheel packages by providing the means to
+replace an external build system (eg. Makefile) so that non-python
+libraries to be built from source within the python ecosystem.
 
 - Documentation at https://mdavidsaver.github.io/setuptools_dso
 - Github project https://github.com/mdavidsaver/setuptools_dso

documentation/releasenotes.rst

@@ -5,9 +5,15 @@ Release Notes
 
 .. currentmodule:: setuptools_dso
 
-2.6 (UNRELEASED)
+2.7 (UNRELEASED)
 ----------------
 
+2.6 (Sept 2022)
+---------------
+
+* Avoid mutable default arguments
+* Workaround probable `bug <https://github.com/mdavidsaver/setuptools_dso/issues/23>`_ in `setuptools >= 63.4.3 <https://github.com/pypa/setuptools/issues/3591>`_
+
 2.5 (Jan 2022)
 --------------
 

setup.py

@@ -10,7 +10,7 @@ with open('README.md', 'r') as F:
 
 setup(
     name='setuptools_dso',
-    version="2.6a1",
+    version="2.6",
     description="setuptools extension to build non-python shared libraries",
     long_description=long_description,
     long_description_content_type='text/markdown',

src/setuptools_dso/compiler.py

@@ -24,6 +24,7 @@ __all__ = (
 # With MSVC this eventually fails.
 def _patch_fix_compile_args(realfn, output_dir, macros, include_dirs, *args, **kws):
     log.warn('_patch_fix_compile_args include_dirs=%r', include_dirs)
+    # turn include_dirs=None into include_dirs=[]
     return realfn(output_dir, macros, include_dirs or [], *args, **kws)
 
 def _default_preprocess(self, *args, **kws):
@@ -68,7 +69,8 @@ def new_compiler(**kws):
     compiler = _new_compiler(**kws)
     customize_compiler(compiler)
 
-    if hasattr(compiler.__class__, 'include_dirs'):
+    # setuptools 63.4.3 adds compiler.__class__.include_dirs
+    if hasattr(compiler.__class__, 'include_dirs') and hasattr(compiler, '_fix_compile_args'):
         log.warn('Patch _fix_compile_args() to avoid modification to compiler.include_dirs')
         compiler._fix_compile_args = partial(_patch_fix_compile_args, compiler._fix_compile_args)