Commit 08bf269a authored by Kirill Smelkov's avatar Kirill Smelkov

.

parent 1e7e5180
...@@ -305,6 +305,7 @@ error _Conn::_pinner(context::Context ctx) { ...@@ -305,6 +305,7 @@ error _Conn::_pinner(context::Context ctx) {
// mark the connection non-operational if the pinner fails // mark the connection non-operational if the pinner fails
// XXX deadlock wrt resync? (who read-locks wconn.mu) // XXX deadlock wrt resync? (who read-locks wconn.mu)
// XXX -> mu -> downMu ?
wconn._mu.Lock(); // XXX locking ok? -> merge into below where lock is held? wconn._mu.Lock(); // XXX locking ok? -> merge into below where lock is held?
if (wconn._downErr == nil) { if (wconn._downErr == nil) {
wconn._downErr = fmt::errorf("no longer operational due to: %w", wconn._downErr = fmt::errorf("no longer operational due to: %w",
...@@ -368,7 +369,7 @@ error _Conn::__pin1(PinReq *req) { ...@@ -368,7 +369,7 @@ error _Conn::__pin1(PinReq *req) {
FileH f; FileH f;
bool ok; bool ok;
wconn._atMu.RLock(); // XXX deadlock wrt Conn.resync ? wconn._atMu.RLock();
defer([&]() { defer([&]() {
wconn._atMu.RUnlock(); wconn._atMu.RUnlock();
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment