Commit 0ed6b8b6 authored by Kirill Smelkov's avatar Kirill Smelkov

fixup! X wcfs: client: Handle fork

Starting from 3f83469c Conn and WatchLink started to inherit from
interface, which made them to use virtual functions, which, without
destructor being also virtual emits the following warnings:

    wcfs/client/wcfs.cpp: In member function ‘virtual void wcfs::_Conn::decref()’:
    wcfs/client/wcfs.cpp:1531:16: warning: deleting object of polymorphic class type ‘wcfs::_Conn’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
             delete this;
                    ^~~~

    wcfs/client/wcfs_watchlink.cpp: In member function ‘virtual void wcfs::_WatchLink::decref()’:
    wcfs/client/wcfs_watchlink.cpp:514:16: warning: deleting object of polymorphic class type ‘wcfs::_WatchLink’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
             delete this;
                    ^~~~
parent 78f36993
...@@ -190,7 +190,7 @@ struct _Conn : os::_IAfterFork, object { ...@@ -190,7 +190,7 @@ struct _Conn : os::_IAfterFork, object {
// don't new - create via WCFS.connect // don't new - create via WCFS.connect
private: private:
_Conn(); _Conn();
~_Conn(); virtual ~_Conn();
friend pair<Conn, error> WCFS::connect(zodb::Tid at); friend pair<Conn, error> WCFS::connect(zodb::Tid at);
public: public:
void incref(); void incref();
......
...@@ -99,7 +99,7 @@ public: ...@@ -99,7 +99,7 @@ public:
// don't new - create only via WCFS._openwatch() // don't new - create only via WCFS._openwatch()
private: private:
_WatchLink(); _WatchLink();
~_WatchLink(); virtual ~_WatchLink();
friend pair<WatchLink, error> WCFS::_openwatch(); friend pair<WatchLink, error> WCFS::_openwatch();
public: public:
void incref(); void incref();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment