. (some staticcheck)

wcfs/internal/xbtree/blib/pptreesubset.go

@@ -362,7 +362,7 @@ func (S PPTreeSubSet) verify() {
 	}
 	defer func() {
 		if badv != nil {
-			emsg := fmt.Sprintf("S.verify: fail:\n\n")
+			emsg := "S.verify: fail:\n\n"
 			for _, bad := range badv {
 				emsg += fmt.Sprintf("- %s\n", bad)
 			}

wcfs/internal/xbtree/blib/rangeset.go

@@ -305,7 +305,7 @@ func (S *RangedKeySet) verify() {
 	}
 	defer func() {
 		if badv != nil {
-			emsg := fmt.Sprintf("S.verify: fail:\n\n")
+			emsg := "S.verify: fail:\n\n"
 			for _, bad := range badv {
 				emsg += fmt.Sprintf("- %s\n", bad)
 			}

wcfs/internal/xbtree/xbtreetest/treeenv.go

@@ -116,7 +116,7 @@ func NewT(t *testing.T) *T {
 // control does not say we need the object to stay in the cache.
 // XXX place
 type tZODBCacheEverything struct{}
-func (_ *tZODBCacheEverything) PCacheClassify(_ zodb.IPersistent) zodb.PCachePolicy {
+func (*tZODBCacheEverything) PCacheClassify(_ zodb.IPersistent) zodb.PCachePolicy {
 	return zodb.PCachePinObject | zodb.PCacheKeepState
 }
 

wcfs/internal/xbtree/δbtail_test.go

@@ -1574,7 +1574,6 @@ func assertΔTtail(t *testing.T, subj string, δbtail *ΔBtail, tj *xbtreetest.C
 		vδToid = δTtail.vδT
 	}
 
-	l = len(vδToid)
 	var vat []zodb.Tid
 	var vδT []map[Key]Δstring
 	atPrev := t0.At

wcfs/wcfs.go

@@ -729,7 +729,7 @@ type blkPinState struct {
 // from ZODB right after that.
 type zodbCacheControl struct {}
 
-func (_ *zodbCacheControl) PCacheClassify(obj zodb.IPersistent) zodb.PCachePolicy {
+func (*zodbCacheControl) PCacheClassify(obj zodb.IPersistent) zodb.PCachePolicy {
 	switch obj.(type) {
 	// don't let ZBlk*/ZData to pollute the cache
 	case *ZBlk0: