Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
W
wendelin.core
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
Kirill Smelkov
wendelin.core
Commits
48eb692f
Commit
48eb692f
authored
Oct 16, 2018
by
Kirill Smelkov
2
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
X found another bug in wc 1 invalidation
parent
5a4562fc
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
0 deletions
+10
-0
bigfile/file_zodb.py
bigfile/file_zodb.py
+10
-0
No files found.
bigfile/file_zodb.py
View file @
48eb692f
...
@@ -148,6 +148,16 @@ class ZBlkBase(Persistent):
...
@@ -148,6 +148,16 @@ class ZBlkBase(Persistent):
# and never e.g. deleted from bigfile. However it is NOT correct: e.g
# and never e.g. deleted from bigfile. However it is NOT correct: e.g
# ZBigFile.storeblk() can change type of stored zblk - i.e. it rewrites
# ZBigFile.storeblk() can change type of stored zblk - i.e. it rewrites
# ZBigFile.blktab[blk] with another ZBlk created anew.
# ZBigFile.blktab[blk] with another ZBlk created anew.
#
# FIXME this assumes that ghostified ZBlk will never be removed from live
# objects cache (cPicleCache). However, since ZBlk is not doing
# anything special, and it actually becomes a ghost all the time (e.g.
# ZBlk0.loadblkdata() ghostifies itself not to waste memory), this
# assumption is NOT correct. Thus, if a ghost ZBlk will be removed from
# live cache, corresponding block will MISS to invalidate its data.
# This practically can happen if LOBucket, that is part of
# ZBigFile.blktab and that was holding reference to this ZBlk, gets
# ghostified under live cache pressure.
def
_p_invalidate
(
self
):
def
_p_invalidate
(
self
):
# do real invalidation only once - else we already lost ._v_zfile last time
# do real invalidation only once - else we already lost ._v_zfile last time
if
self
.
_p_state
is
GHOST
:
if
self
.
_p_state
is
GHOST
:
...
...
Kirill Smelkov
@kirr
mentioned in commit
197c35ea
·
Jul 12, 2019
mentioned in commit
197c35ea
mentioned in commit 197c35ea8d8bf0b7d4e0863038a081b020443933
Toggle commit list
Kirill Smelkov
@kirr
mentioned in commit
8c32c9f6
·
Dec 18, 2019
mentioned in commit
8c32c9f6
mentioned in commit 8c32c9f677fa5188c310d02c235f84751486678a
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment