.

wcfs/client/wcfs_watchlink.cpp

@@ -168,8 +168,8 @@ error _WatchLink::_serveRX(context::Context ctx) {
 
         if (pkt.stream == 0) { // control/fatal message from wcfs
             log::Errorf("C: watch  : rx fatal: %s\n", v(l));
-            wlink.fatalv.push_back(pkt.to_string());
-            return E(ErrLinkDown); // XXX correct error
+            wlink.fatalv.push_back(pkt.to_string()); // XXX stub -> errorq?
+            continue; // wcfs should close link after error
         }
 
         bool reply = (pkt.stream % 2 != 0);
@@ -184,9 +184,8 @@ error _WatchLink::_serveRX(context::Context ctx) {
             wlink._rxmu.unlock();
             if (!ok) {
                 // wcfs sent reply on unexpected stream -> shutdown wlink.
-                // XXX down.
                 log::Errorf("%s: .%lu: wcfs sent reply on unexpected stream", v(wlink), pkt.stream);
-                return ErrLinkDown; // XXX correct error
+                return E(ErrLinkDown);
             }
             int _ = select({
                 ctx->done().recvs(),    // 0
@@ -203,7 +202,7 @@ error _WatchLink::_serveRX(context::Context ctx) {
                     wlink._rxmu.unlock();
                     // wcfs request on already used stream
                     log::Errorf("%s: .%lu: wcfs sent request on already used stream", v(wlink), pkt.stream);
-                    return ErrLinkDown; // XXX correct error
+                    return E(ErrLinkDown);
                 }
                 wlink._accepted.insert(pkt.stream);
             wlink._rxmu.unlock();