.

bigfile/_bigfile.c

@@ -920,8 +920,6 @@ out:
 /* PyBigFile: mmap methods.
  * They redirect op X to type.blkmmapper.X without going to Python level */
 
-// XXX make sure not to hold the GIL ?
-
 static void*
 pybigfile_mmap_setup_read(VMA *vma, BigFile *file0, blk_t blk, size_t blklen)
 {

bigfile/_bigfile.h

@@ -110,7 +110,7 @@ typedef struct PyBigFileH PyBigFileH;
  * mmapping data. To avoid deadlocks all mmap-related functionality must be
  * nogil and so cannot be implemented in Python.
  *
- * One example user of .blkmmapper functionality is _ZBigFile which uses WCFS
+ * The primary user of .blkmmapper functionality is _ZBigFile which uses WCFS
  * and mmaps files from it to provide memory mappings for ZBigFile data.
  */
 struct PyBigFile {

include/wendelin/compat_py2.h

@@ -2,7 +2,7 @@
 #define _WENDELIN_COMPAT_PY2_H
 
 /* Wendelin. Python2 compatibility
- * Copyright (C) 2014-2020  Nexedi SA and Contributors.
+ * Copyright (C) 2014-2019  Nexedi SA and Contributors.
  *                          Kirill Smelkov <kirr@nexedi.com>
  *
  * This program is free software: you can Use, Study, Modify and Redistribute
@@ -102,16 +102,6 @@ static inline PyThreadState * _PyThreadState_UncheckedGet(void)
 # error "You are using CPython 3.5.X series. Upgrade your CPython to >= 3.5.2 to get _PyThreadState_UncheckedGet() support."
 #endif
 
-/* determine if current thread holds the GIL
- * https://stackoverflow.com/a/25666624/9456786 */
-#if PY_MAJOR_VERSION < 3
-static inline int PyGILState_Check(void)
-{
-    // XXX do we really need it?
-    abort();
-}
-#endif
-
 #ifdef __cplusplus
 }
 #endif