Commit c18aac68 authored by Kirill Smelkov's avatar Kirill Smelkov

amari.{drb,kpi}: Cosmetics

Add explanatory comments and fix typos noticed while working on
drb/multicell topic.
parent 54b4ac47
...@@ -111,6 +111,8 @@ class _ERAB_Flow: ...@@ -111,6 +111,8 @@ class _ERAB_Flow:
# _QCI_Flow represents in-progress collection to make up a Sample. # _QCI_Flow represents in-progress collection to make up a Sample.
# #
# It tracks data transmission on particular QCI of particular UE.
#
# .update(δt, tx_bytes, #tx, ...) updates flow with information about next # .update(δt, tx_bytes, #tx, ...) updates flow with information about next
# transmission period and potentially yields some finalized Samples. # transmission period and potentially yields some finalized Samples.
# .finish() completes Sample collection. # .finish() completes Sample collection.
...@@ -246,7 +248,7 @@ def add(s, ue_stats, stats): # -> dl/ul samples ; dl/ul = {} qci -> []Sample ...@@ -246,7 +248,7 @@ def add(s, ue_stats, stats): # -> dl/ul samples ; dl/ul = {} qci -> []Sample
class _Utx: # UE transmission state class _Utx: # UE transmission state
__slots__ = ( __slots__ = (
'qtx_bytes', 'qtx_bytes', # {} qci -> Σδerab_qci=qci
'cutx', # {} cell -> _UCtx 'cutx', # {} cell -> _UCtx
) )
...@@ -971,7 +973,7 @@ def _x_stats_srv(ctx, reqch: chan, conn: amari.Conn): ...@@ -971,7 +973,7 @@ def _x_stats_srv(ctx, reqch: chan, conn: amari.Conn):
# we can retrieve both ue_get and stats each at 100Hz simultaneously. # we can retrieve both ue_get and stats each at 100Hz simultaneously.
conn_stats = amari.connect(ctx, conn.wsuri) conn_stats = amari.connect(ctx, conn.wsuri)
defer(conn_stats.close) defer(conn_stats.close)
rtt_stats = _IncStats() # like rtt_ue_stats but for stat instead of ue_get rtt_stats = _IncStats() # like rtt_ue_stats but for stats instead of ue_get
δt_stats = _IncStats() # δ(stats.timestamp) δt_stats = _IncStats() # δ(stats.timestamp)
t_stats = None # last stats.timestamp t_stats = None # last stats.timestamp
def rx_stats(ctx): # -> stats def rx_stats(ctx): # -> stats
...@@ -1154,7 +1156,7 @@ def _x_stats_srv(ctx, reqch: chan, conn: amari.Conn): ...@@ -1154,7 +1156,7 @@ def _x_stats_srv(ctx, reqch: chan, conn: amari.Conn):
'ul_tx_time_err': Σul.tx_time_err, 'ul_tx_time_err': Σul.tx_time_err,
'ul_tx_time_notailtti': Σul.tx_time_notailtti, 'ul_tx_time_notailtti': Σul.tx_time_notailtti,
'ul_tx_time_notailtti_err': Σul.tx_time_notailtti_err, 'ul_tx_time_notailtti_err': Σul.tx_time_notailtti_err,
'u;_tx_nsamples': Σul.tx_nsamples, 'ul_tx_nsamples': Σul.tx_nsamples,
} }
r = {'time': ue_stats['time'], r = {'time': ue_stats['time'],
......
...@@ -645,7 +645,7 @@ def jdrb_stats(τ, qci_dlul): # -> str ...@@ -645,7 +645,7 @@ def jdrb_stats(τ, qci_dlul): # -> str
assert set(dlul.keys()) == {"dl_tx_bytes", "dl_tx_time", "dl_tx_time_notailtti", assert set(dlul.keys()) == {"dl_tx_bytes", "dl_tx_time", "dl_tx_time_notailtti",
"ul_tx_bytes", "ul_tx_time", "ul_tx_time_notailtti"} "ul_tx_bytes", "ul_tx_time", "ul_tx_time_notailtti"}
dlul["dl_tx_time_err"] = 0 # original time is simulated to be dlul["dl_tx_time_err"] = 0 # original time is simulated to be
dlul["ul_tx_time_err"] = 0 # measured precisely in tess. dlul["ul_tx_time_err"] = 0 # measured precisely in tests.
dlul["dl_tx_time_notailtti_err"] = 0 # ----//---- dlul["dl_tx_time_notailtti_err"] = 0 # ----//----
dlul["ul_tx_time_notailtti_err"] = 0 # dlul["ul_tx_time_notailtti_err"] = 0 #
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment