Don't use type() to test the type of a variable, see...

Don't use type() to test the type of a variable, see http://www.erp5.org/GuidelinesForPerformanceCrimes
use isinstance instead


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@27057 20353a03-c40f-0410-a6d1-a30d3c3de9de

product/ERP5/Document/BusinessProcess.py

@@ -72,7 +72,9 @@ class BusinessProcess(Path, XMLObject):
       **kw -- same parameters as for searchValues / contentValues
     """
     # Naive implementation to redo XXX using contentValues
-    if type(trade_phase) is type(''): # XXX - bad, use isinstance
+    if trade_phase is None:
+      trade_phase=[]
+    if not isinstance(trade_phase, (list, tuple)):
       trade_phase = (trade_phase,)
     result = []
     for document in self.contentValues(portal_type="Business Path"):
@@ -174,4 +176,4 @@ class BusinessProcess(Path, XMLObject):
       Build whatever is buildable
     """
     for path in self.getBuildablePathValueList(explanation):
-      path.build(explanation)
\ No newline at end of file
+      path.build(explanation)