Commit f52a93f2 authored by Han-Wen Nienhuys's avatar Han-Wen Nienhuys

Run gofmt.

parent ae23e54c
...@@ -34,7 +34,7 @@ type FileSystemConnector struct { ...@@ -34,7 +34,7 @@ type FileSystemConnector struct {
Debug bool Debug bool
// Callbacks for talking back to the kernel. // Callbacks for talking back to the kernel.
fsInit RawFsInit fsInit RawFsInit
// Translate between uint64 handles and *Inode. // Translate between uint64 handles and *Inode.
inodeMap HandleMap inodeMap HandleMap
...@@ -77,7 +77,6 @@ func (me *FileSystemConnector) verify() { ...@@ -77,7 +77,6 @@ func (me *FileSystemConnector) verify() {
root.verify(me.rootNode.mountPoint) root.verify(me.rootNode.mountPoint)
} }
// createChild() creates a child for given as FsNode as child of 'parent'. The // createChild() creates a child for given as FsNode as child of 'parent'. The
// resulting inode will have its lookupCount incremented. // resulting inode will have its lookupCount incremented.
func (me *FileSystemConnector) createChild(parent *Inode, name string, fi *os.FileInfo, fsi FsNode) (out *EntryOut) { func (me *FileSystemConnector) createChild(parent *Inode, name string, fi *os.FileInfo, fsi FsNode) (out *EntryOut) {
...@@ -124,7 +123,6 @@ func (me *FileSystemConnector) lookupUpdate(node *Inode) { ...@@ -124,7 +123,6 @@ func (me *FileSystemConnector) lookupUpdate(node *Inode) {
node.lookupCount += 1 node.lookupCount += 1
} }
// Must run outside treeLock. // Must run outside treeLock.
// //
// TODO - reconcile api for lookupUpdate() and forgetUpdate(). // TODO - reconcile api for lookupUpdate() and forgetUpdate().
......
...@@ -18,7 +18,6 @@ type openedFile struct { ...@@ -18,7 +18,6 @@ type openedFile struct {
dir rawDir dir rawDir
} }
type fileSystemMount struct { type fileSystemMount struct {
// The file system we mounted here. // The file system we mounted here.
fs NodeFileSystem fs NodeFileSystem
...@@ -39,7 +38,7 @@ type fileSystemMount struct { ...@@ -39,7 +38,7 @@ type fileSystemMount struct {
// Manage filehandles of open files. // Manage filehandles of open files.
openFiles HandleMap openFiles HandleMap
Debug bool Debug bool
} }
// Must called with lock for parent held. // Must called with lock for parent held.
......
...@@ -59,7 +59,6 @@ func (me *FileSystemConnector) internalLookup(parent *Inode, name string, contex ...@@ -59,7 +59,6 @@ func (me *FileSystemConnector) internalLookup(parent *Inode, name string, contex
return me.postLookup(fi, fsNode, code, getattrNode, lookupNode, name) return me.postLookup(fi, fsNode, code, getattrNode, lookupNode, name)
} }
// Prepare for lookup: we are either looking for getattr of an // Prepare for lookup: we are either looking for getattr of an
// existing node, or lookup a new one. Here we decide which of those // existing node, or lookup a new one. Here we decide which of those
func (me *FileSystemConnector) preLookup(parent *Inode, name string) (lookupNode *Inode, attrNode *Inode) { func (me *FileSystemConnector) preLookup(parent *Inode, name string) (lookupNode *Inode, attrNode *Inode) {
......
...@@ -39,7 +39,7 @@ const _ALREADY_MSG = "Object already has a handle" ...@@ -39,7 +39,7 @@ const _ALREADY_MSG = "Object already has a handle"
type portableHandleMap struct { type portableHandleMap struct {
sync.RWMutex sync.RWMutex
nextFree uint32 nextFree uint32
handles map[uint64]*Handled handles map[uint64]*Handled
} }
func (me *portableHandleMap) Register(obj *Handled, asInt interface{}) uint64 { func (me *portableHandleMap) Register(obj *Handled, asInt interface{}) uint64 {
...@@ -79,7 +79,6 @@ func (me *portableHandleMap) Decode(h uint64) *Handled { ...@@ -79,7 +79,6 @@ func (me *portableHandleMap) Decode(h uint64) *Handled {
return me.handles[h] return me.handles[h]
} }
func (me *portableHandleMap) Forget(h uint64) *Handled { func (me *portableHandleMap) Forget(h uint64) *Handled {
me.Lock() me.Lock()
defer me.Unlock() defer me.Unlock()
...@@ -95,7 +94,6 @@ func (me *portableHandleMap) Has(h uint64) bool { ...@@ -95,7 +94,6 @@ func (me *portableHandleMap) Has(h uint64) bool {
return me.handles[h] != nil return me.handles[h] != nil
} }
// 32 bits version of HandleMap // 32 bits version of HandleMap
type int32HandleMap struct { type int32HandleMap struct {
mutex sync.Mutex mutex sync.Mutex
...@@ -132,7 +130,6 @@ func (me *int32HandleMap) Forget(handle uint64) *Handled { ...@@ -132,7 +130,6 @@ func (me *int32HandleMap) Forget(handle uint64) *Handled {
return val return val
} }
func (me *int32HandleMap) Decode(handle uint64) *Handled { func (me *int32HandleMap) Decode(handle uint64) *Handled {
val := (*Handled)(unsafe.Pointer(uintptr(handle & ((1 << 32) - 1)))) val := (*Handled)(unsafe.Pointer(uintptr(handle & ((1 << 32) - 1))))
return val return val
......
...@@ -87,9 +87,9 @@ func TestHandleMapBasic(t *testing.T) { ...@@ -87,9 +87,9 @@ func TestHandleMapBasic(t *testing.T) {
t.Fatal("Still has handle") t.Fatal("Still has handle")
} }
if v.check != 0 { if v.check != 0 {
t.Errorf("forgotten object still has a check.") t.Errorf("forgotten object still has a check.")
} }
} }
} }
func TestHandleMapMultiple(t *testing.T) { func TestHandleMapMultiple(t *testing.T) {
...@@ -119,4 +119,3 @@ func TestHandleMapCheckFail(t *testing.T) { ...@@ -119,4 +119,3 @@ func TestHandleMapCheckFail(t *testing.T) {
hm.Decode(h | (uint64(1) << 63)) hm.Decode(h | (uint64(1) << 63))
t.Error("Borked decode did not panic") t.Error("Borked decode did not panic")
} }
...@@ -24,7 +24,7 @@ type Inode struct { ...@@ -24,7 +24,7 @@ type Inode struct {
// pointer is constant during the lifetime, except upon // pointer is constant during the lifetime, except upon
// Unmount() when it is set to nil. // Unmount() when it is set to nil.
mount *fileSystemMount mount *fileSystemMount
// treeLock is a pointer to me.mount.treeLock. We store it // treeLock is a pointer to me.mount.treeLock. We store it
// here for convenience. Constant during lifetime of the // here for convenience. Constant during lifetime of the
// inode. // inode.
...@@ -44,7 +44,7 @@ type Inode struct { ...@@ -44,7 +44,7 @@ type Inode struct {
// it is zero, it means the kernel does not know about this // it is zero, it means the kernel does not know about this
// Inode. nodeIds are chosen by FileSystemConnector.inodeMap. // Inode. nodeIds are chosen by FileSystemConnector.inodeMap.
nodeId uint64 nodeId uint64
// lookupCount registers how often the kernel got this inode // lookupCount registers how often the kernel got this inode
// back for a Lookup operation. This number is a reference // back for a Lookup operation. This number is a reference
// count, and the Forget operation lists how many references to drop. // count, and the Forget operation lists how many references to drop.
...@@ -56,7 +56,7 @@ type Inode struct { ...@@ -56,7 +56,7 @@ type Inode struct {
// This is to prevent lookupCount==0 node from being dropped. // This is to prevent lookupCount==0 node from being dropped.
synthetic bool synthetic bool
// Non-nil if this inode is a mountpoint, ie. the Root of a // Non-nil if this inode is a mountpoint, ie. the Root of a
// NodeFileSystem. // NodeFileSystem.
mountPoint *fileSystemMount mountPoint *fileSystemMount
...@@ -128,13 +128,12 @@ func (me *Inode) IsDir() bool { ...@@ -128,13 +128,12 @@ func (me *Inode) IsDir() bool {
return me.children != nil return me.children != nil
} }
// CreateChild() creates node for synthetic use // CreateChild() creates node for synthetic use
func (me *Inode) CreateChild(name string, isDir bool, fsi FsNode) *Inode { func (me *Inode) CreateChild(name string, isDir bool, fsi FsNode) *Inode {
me.treeLock.Lock() me.treeLock.Lock()
defer me.treeLock.Unlock() defer me.treeLock.Unlock()
ch := me.createChild(name, isDir, fsi) ch := me.createChild(name, isDir, fsi)
ch.synthetic = true ch.synthetic = true
return ch return ch
} }
......
...@@ -736,12 +736,12 @@ func TestUmask(t *testing.T) { ...@@ -736,12 +736,12 @@ func TestUmask(t *testing.T) {
defer ts.Cleanup() defer ts.Cleanup()
// Make sure system setting does not affect test. // Make sure system setting does not affect test.
fn := ts.mnt+"/file" fn := ts.mnt + "/file"
mask := 020 mask := 020
cmd := exec.Command("/bin/sh", "-c", cmd := exec.Command("/bin/sh", "-c",
fmt.Sprintf("umask %o && mkdir %s", mask, fn)) fmt.Sprintf("umask %o && mkdir %s", mask, fn))
cmd.Run() cmd.Run()
fi, err := os.Lstat(fn) fi, err := os.Lstat(fn)
CheckSuccess(err) CheckSuccess(err)
......
...@@ -35,7 +35,7 @@ type PathNodeFs struct { ...@@ -35,7 +35,7 @@ type PathNodeFs struct {
// This map lists all the parent links known for a given // This map lists all the parent links known for a given
// nodeId. // nodeId.
clientInodeMap map[uint64][]*clientInodePath clientInodeMap map[uint64][]*clientInodePath
} }
func (me *PathNodeFs) Mount(path string, nodeFs NodeFileSystem, opts *FileSystemOptions) Status { func (me *PathNodeFs) Mount(path string, nodeFs NodeFileSystem, opts *FileSystemOptions) Status {
...@@ -154,9 +154,9 @@ func (me *PathNodeFs) Root() FsNode { ...@@ -154,9 +154,9 @@ func (me *PathNodeFs) Root() FsNode {
// the inode). This structure is used to implement glue for FSes where // the inode). This structure is used to implement glue for FSes where
// there is a one-to-one mapping of paths and inodes. // there is a one-to-one mapping of paths and inodes.
type pathInode struct { type pathInode struct {
pathFs *PathNodeFs pathFs *PathNodeFs
fs FileSystem fs FileSystem
Name string Name string
// This is nil at the root of the mount. // This is nil at the root of the mount.
Parent *pathInode Parent *pathInode
......
...@@ -952,4 +952,3 @@ func (me *UnionFsFile) GetAttr() (*os.FileInfo, fuse.Status) { ...@@ -952,4 +952,3 @@ func (me *UnionFsFile) GetAttr() (*os.FileInfo, fuse.Status) {
} }
return fi, code return fi, code
} }
...@@ -993,7 +993,7 @@ func TestStatFs(t *testing.T) { ...@@ -993,7 +993,7 @@ func TestStatFs(t *testing.T) {
defer clean() defer clean()
s1 := syscall.Statfs_t{} s1 := syscall.Statfs_t{}
err := syscall.Statfs(wd + "/mount", &s1) err := syscall.Statfs(wd+"/mount", &s1)
if err != 0 { if err != 0 {
t.Fatal("statfs mnt", err) t.Fatal("statfs mnt", err)
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment