- 26 Mar, 2021 2 commits
-
-
Kirill Smelkov authored
If we don't require drivers to stop sending to watchq after Close, there could be many deadlock scenarios, for example: - client called drv.Close(); no longer listens to watchq; driver is stuck sending to watchq, or - client called drv.Close(), which itself waits for tasks spawned inside driver to complete, which are stuck sending to watchq because client no longer does <-watchq. The change is similar in spirit to safety guaranty provided by high-level Watcher where after DelWatch call it is guaranteed that there will be no more sends to subscribed watchq (see c41c2907 "go/zodb: High-level watching - initial draft") for details. All drivers don't provide requested guarantee yet. We'll be fixing them one-by-one in followup commits.
-
Kirill Smelkov authored
Else, on an error, it is the lineno of `t.Fatal(err)` inside FatalIf that is printed, not the line number inside user test.
-
- 17 Mar, 2021 4 commits
-
-
Kirill Smelkov authored
A data record with len(data)=0 and backpointer=0 is considered by FileStorage/py as "no data": https://github.com/zopefoundation/ZODB/blob/5.6.0-15-g22d1405d4/src/ZODB/FileStorage/FileStorage.py#L576-L582 Even though currently it is not possible to create such data record via FileStorage(py).deleteObject (becase it raises POSKeyError if there is no previous object revision), being able to use such data records is semantically useful in overlayed DemoStorage settings, where δ part marks an object that exists only in base with delete record whiteout. It is also generally meaningfull to be able to create "delete" record even if object was not previously existing: "deleteObject" is actually similar to "store" (and so should be better named as "storeDelete"). If one wants to store deletion, there should not be a reason to reject it, because deleteObject already has seatbelt in the form of oldserial, and if the user calls deleteObject(oid, oldserial=z64), he/she is already telling that "I know that this object does not exist in this storage (oldserial=z64), but still please create a deletion record for it". Once again this is useful in overlayed DemoStorage settings described above. For the reference, such whiteout deletion records pass ZODB/scripts/fstest just fine. Even though FileStorage/py loads such data records just fine, on FileStorage/go side it was not the case - DataHeader.LoadBackRef, even with backpointer=0, was verifying that backpointer to be valid and failing seeing it might overlap with current transaction: === RUN TestLoadWhiteout 2021/03/17 06:40:58 index load: open testdata/whiteout.fs.index: no such file or directory 2021/03/17 06:40:58 testdata/whiteout.fs: index rebuild... filestorage_test.go:398: load 0000000000000017:0000000000000001: bad err: have: testdata/whiteout.fs: load 0000000000000017:0000000000000001: testdata/whiteout.fs: data record @27: check: backpointer (0) overlaps with txn (4) want: testdata/whiteout.fs: load 0000000000000017:0000000000000001: 0000000000000001: object was not yet created It was a thinko: backPos==0 was already kind of handled in LoadBackRef, but only in one verification case. -> Fix all checks not to trigger when seeing backPos=0. DataHeader.LoadBack - the caller of LoadBackRef - already handles returned backPos=0 as "no data".
-
Kirill Smelkov authored
We were reusing Dumper instance in between testDump subtests. This was not noticed, as it was only "1" and then "empty" case, because "emtpy" has no transactions. However in the next patch we'll add another subcase, and if the dumper instance is not reset, it will think that it starts from transaction number non-zero, which would differ from fresh dumper output. -> Fix it.
-
Kirill Smelkov authored
As Zodbtools dropped ZODB3 support its run_with_zodb3py2_compat was renamed to run_with_zodb4py2_compat: nexedi/zodbtools@c59a54ca
-
Kirill Smelkov authored
Encode/decode was deprecated and removed in recent github.com/shamaton/msgpack.
-
- 19 Feb, 2021 1 commit
-
-
Kirill Smelkov authored
NEO/py switched from UUID to 4-byte NodeID long time ago in nexedi/neoppod@23fad3af and has a TODO to rename uuid to nid. NEO protocol also talks about renaming uuid to nid: note: the uuid variable should be renamed into nid https://neo.nexedi.com/P-NEO-Protocol.Specification.2019?portal_skin=CI_slideshow#/9/5 NEO/go can do the rename now.
-
- 18 Jan, 2021 5 commits
-
-
Kirill Smelkov authored
It is the same as regular SHA1 but returns all-zeros for empty input. Besides there is runtime knob to skip checksum computation to benchmark how much time and latency SHA1 computation introduces. See the following links for some preliminary history: - kirr/neo@bc2cddfc - https://navytux.spb.ru/~kirr/neo.html#results-and-discussion
-
Kirill Smelkov authored
See previous commits.
-
Kirill Smelkov authored
To use something like defer task.Running(&ctx, "my task")(&err) that will create the task, trace its begin/end and integrate with return error. Probably this package should be integrated one way or another with go/internal/xcontext/task.
-
Kirill Smelkov authored
Package log provides logging with severity levels and integration with tasks.
-
Kirill Smelkov authored
Package task provides primitives to track tasks via contexts.
-
- 15 Jan, 2021 20 commits
-
-
Kirill Smelkov authored
NEO/go server accepts preferred encoding of client from start, but NEO/py server implements either N or M encoding and disconnects client silently if handshake is not exactly what is expected. However we can teach Dial to retry with different preferred options and this way when connection to a NEO/py server, it will essentially autodetect which encoding is used and accepted by remote peer.
-
Kirill Smelkov authored
This patch adds support for serializing packet frames with M encoding on the wire. To do so it follows rules defined in nexedi/neoppod@9d0bf97a ( nexedi/neoppod!11 ) Server handshake is reworked to autodetect client's preferred encoding. Client always prefers 'N' for now.
-
Kirill Smelkov authored
-
Kirill Smelkov authored
This patch adds proto.Encoding('M') and teaches it to encode/decode messages via MessagePack by the rules defined in nexedi/neoppod@9d0bf97a ( nexedi/neoppod!11 ) It only adds support for messages serialization, without changing proto.go to match changes in e.g. enums reordering, and without adding support for MessagePack at link layer in neonet. M-encoding was only tested for NEO/go-NEO/go, and was not yet tested for NEO/go-NEO/py interoperation. There will be likely small mistakes discovered on my side that should be hopefully easy to fix step by step once we get to that phase.
-
Kirill Smelkov authored
It complements github.com/tinylib/msgp with things that neo/proto needs to encode/decode messages.
-
Kirill Smelkov authored
It is noop for 'N' encoding, but will be non-empty for MessagePack.
-
Kirill Smelkov authored
genSliceHead and genMapHead will be reused for MsgPack encoding. Changes in generated code are mostly due to move of where things are typecasted to e.g. uint32 without any change in semantic.
-
Kirill Smelkov authored
For decode-family of functions protogen.go sticks to convention to name target variable to where to assign the result as "assignto", not "path". No change in generated code.
-
Kirill Smelkov authored
Encoding specifies a way to encode/decode NEO messages and packets. Current way of how messages were encoded is called to be 'N' encoding. This patch: - adds proto.Encoding type - changes MsgEncode and MsgDecode to be methods of Encoding - renames thigs that are specific to 'N' encoding to have 'N' suffix - changes tests to run a testcase agains vector of provided encodings. That vector is currently only ['N'].
-
Kirill Smelkov authored
And provide only single top-level entry-points to encode/decode messages. As of now the entry points are just plain forwarding, but with introducing of msgpack and encodings, they will take into account through which encoding a message has to be encoded/decoded.
-
Kirill Smelkov authored
- Regrouping messages would change their message codes, thus introducing backward compatibility breakage. - The protocol itself is currently kind-of documented in separate document here: https://neo.nexedi.com/P-NEO-Protocol.Specification.2019?portal_skin=CI_slideshow
-
Kirill Smelkov authored
It is internal detail that ideally should not get outside of proto package. Don't clutter documentation of all messages with it. -> For now access message code via proto.MsgCode(msg) from outside.
-
Kirill Smelkov authored
Generating code through sizer can already give answer if a type is fixed size or not. And in practice we don't care at all if it will be a bit slower compared to previous explicit type switch. For current code it is just a small cleanup, and it will be handy to support messagepack encoding as well. No change in generated code.
-
Kirill Smelkov authored
Not used yet, but they will be needed for msgpack codec.
-
Kirill Smelkov authored
Besides proto.customCodec we will need to lookup more objects.
-
Kirill Smelkov authored
We previously used criteria that sizeof(typ.Elem()) == 1, but it would also trigger on e.g. `struct { x byte }` which we would not want to consider as byte array. -> Clarify the test to explicitly test for typ.Elem() == byte. No change in generated code.
-
Kirill Smelkov authored
Without the fix any pointer field of a struct would be silently skipped without any serialization code generated for it. With the patch default case triggers in and reports detail where such type is and in which struct/field it is used. Besides *mem.Buf - that is handled specially - we don't have pointers in proto.go, so this currently does not affect generated code at all. Noticed accidentally.
-
Kirill Smelkov authored
Without that, when lonet will be used in tests, port won't be correctly extracted from an address.
-
Kirill Smelkov authored
With upcoming msgpack encoding packets might be with data < PktHeaderSize. Adjust pktAlloc to unconditionally provide the invariant.
-
Kirill Smelkov authored
Preparatory step before we introduce support for msgpack encoding.
-
- 14 Jan, 2021 4 commits
-
-
Kirill Smelkov authored
It is not used anywhere and would have to be reworked with upcoming introduction of msgpack encoding. -> Simply remove that.
-
Kirill Smelkov authored
Just renaming.
-
Kirill Smelkov authored
This represents a neonet testing environment and in the future will be used to run tests under different protocol versions, protocol encodings, etc. For now it is noop wrapper around testing.T + t.bin that wraps []byte and will be amended to return something different depending on t's encoding.
-
Kirill Smelkov authored
Previously we were doing handshake symmetrically: both client and server were transmitting hello and receiving peer's hello simultaneously. However this does not allow server to adjust its behaviour depending on which client (protocol version, protocol encoding, ...) is connecting to it. -> Rework handshake so that client always sends its hello first, and only then the server side replies. This matches actual NEO/py behaviour: https://lab.nexedi.com/nexedi/neoppod/blob/v1.12-67-g261dd4b4/neo/lib/connector.py#L293-294 even though the "NEO protocol" states that Handshake transmissions are not ordered with respect to each other and can go in parallel. ( https://neo.nexedi.com/P-NEO-Protocol.Specification.2019?portal_skin=CI_slideshow#/9/2 ) If I recall correctly that sentence was authored by me in 2018 based on previous understanding of should-be full symmetry in-between client and server. However soon we are going to teach server sides to autodetect client encoding and adjust server to talk to client via its preferred way. This needs handshake for client and server to be differentiated. The protocol needs to be adjusted as well. However I'm not sure it is going to happen...
-
- 13 Jan, 2021 1 commit
-
-
Kirill Smelkov authored
This will be handy to test underlying error for e.g. EOF with errors.Cause or errors.Is in case that underlying error is also error wrapper.
-
- 12 Jan, 2021 1 commit
-
-
Kirill Smelkov authored
We were returning packet with tail read for next packet data. Previously decoding was forgiving, but upcoming rework for msgpack support will add check to catch packets with overlong payload, e.g. === RUN TestEmptyDB/py/!ssl I: runneo.py: /tmp/neo214694750/1 !ssl: started master(s): 127.0.0.1:30621 127.0.0.1:42266 > 127.0.0.1:30621: .1 RequestIdentification &{CLIENT ?(0)0 1 ø [] []} 127.0.0.1:42266 < 127.0.0.1:30621: (N: decode header: len(payload) != msgLen) 00 00 00 01 80 01 00 00 00 09 00 f0 00 00 01 e0 00 00 01 00 00 00 00 00 06 00 00 00 58 41 d7 ff 69 82 0a 91 25 00 00 00 03 02 00 00 00 00 e0 00 00 01 02 41 d7 ff 69 82 0a 78 ff 01 00 00 00 09 31 32 37 2e 30 2e 30 2e 31 96 f7 00 00 00 01 02 41 d7 ff 69 81 c6 65 f5 00 00 00 00 09 31 32 37 2e 30 2e 30 2e 31 77 9d f0 00 00 01 02 ff ff ff ff ff ff ff ff 00 00 00 02 00 0a 00 00 00 19 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 01 00 00 00 01 01 -> Fix is: pkt.data should be data[:pktLen], not data[:n] since n is how much we have read at all.
-
- 29 Dec, 2020 2 commits
-
-
Kirill Smelkov authored
The utility to create Networker suitable for interoperating with nodes in a NEO cluster, be it TCP, TLS/TCP, TLS/lonet, etc. See added comments for details.
-
Kirill Smelkov authored
See ConfigForP2P comment for details.
-