Commits · bdf12b248917982a9e245e72f95acdb822584c49 · Levin Zimmermann / neoppod

01 Feb, 2010 19 commits

Make UUID readable in assertion error message. · bdf12b24
Vincent Pelletier authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1580 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bdf12b24

Add a class-level reference to logging module. · f9a9442b

Vincent Pelletier authored Feb 01, 2010

This makes garbage collector delay logging module deletion upon interpreter
shutdown, preventing occasional tracebacks from epoll thread.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1579 71dcc9de-d417-0410-9af5-da40c76e7ee4

f9a9442b

Move handler instanciation into master app instead of identification handler. · 137e2908
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1578 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
137e2908

Fix indentation. · 80cda351

Grégory Wisniewski authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1577 71dcc9de-d417-0410-9af5-da40c76e7ee4

80cda351

Update copyright. · a88d3eb2

Grégory Wisniewski authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1576 71dcc9de-d417-0410-9af5-da40c76e7ee4

a88d3eb2

Remove a BUG entry fixed in r1553 (epoll/packet queue). · 874c9483
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1575 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
874c9483

Remove a TODO done in r1467. · 26e1b810

Grégory Wisniewski authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1574 71dcc9de-d417-0410-9af5-da40c76e7ee4

26e1b810

Remove this TODO, all packets are now well-named. · 8824fae2
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1573 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8824fae2

Rename NotifyInformationLocked packet to AnswerInformationLocked. · 11ff7360

Grégory Wisniewski authored Feb 01, 2010

This packet was misnamed as it's an answer.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1572 71dcc9de-d417-0410-9af5-da40c76e7ee4

11ff7360

Update tests according to remove of 'packet' parameter from handler methods. · 64213d90
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1571 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
64213d90
Update client application tests: A packet ID is now always required. · 8030b635
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1570 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8030b635

Remove 'packet' parameter of handler's methods. · 37c75a72

Grégory Wisniewski authored Feb 01, 2010

Almost any use of packet was to retreive the msg_id of the request and pass it to answer().
In storage's replicator, critical TIDs are indexed with UUID instead of remote connection ID (full replicator review required).
In admin node, expected answers are still queued with the msg_id but it seems useless as no concurrent queries should happen.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1569 71dcc9de-d417-0410-9af5-da40c76e7ee4

37c75a72

Make msg_id optional in Connection.answer(). · 91ff3fef

Grégory Wisniewski authored Feb 01, 2010

The connection now store the last generated remote ID. If no msg_id is supplied to answer(), the last received ID will be used.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1568 71dcc9de-d417-0410-9af5-da40c76e7ee4

91ff3fef

Add a TODO to rename a confusing packet. · dfef415e
Grégory Wisniewski authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1567 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dfef415e

Add missing import · c36f2d51

Grégory Wisniewski authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1566 71dcc9de-d417-0410-9af5-da40c76e7ee4

c36f2d51

Fix log message. · 935d7082

Grégory Wisniewski authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1565 71dcc9de-d417-0410-9af5-da40c76e7ee4

935d7082

Use attribute tracking ability to help locate assertion failures. · 5ae7dc58
Vincent Pelletier authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1564 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5ae7dc58

Use attributeTracker on node._state. · f6140d82

Vincent Pelletier authored Feb 01, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1563 71dcc9de-d417-0410-9af5-da40c76e7ee4

f6140d82

Add attributeTracker debugging-helper module. · c981c3bb
Vincent Pelletier authored Feb 01, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1562 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c981c3bb

29 Jan, 2010 19 commits

Remove unexplained try..except blocks. · 9213da4c

Vincent Pelletier authored Jan 29, 2010

Hiding exceptions is *bad* .

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1561 71dcc9de-d417-0410-9af5-da40c76e7ee4

9213da4c

Explode tuple before give it's content to logging method. · 366205da
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1560 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
366205da

Add TODOs. · 44a4697b

Grégory Wisniewski authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1559 71dcc9de-d417-0410-9af5-da40c76e7ee4

44a4697b

Almost full rewrite of master election handlers tests. · 6151abf1
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1558 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6151abf1
Add missing parameter requestIdentification definition. · d74aa528
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1557 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d74aa528

Remove useless 'elif' statement. · b37d9755

Grégory Wisniewski authored Jan 29, 2010

This condition is always true as the primary_node was found by UUID.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1556 71dcc9de-d417-0410-9af5-da40c76e7ee4

b37d9755

Handle askPrimary packet as unexpected in ClientElectionHandler. · 5572c34e
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1555 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5572c34e

Attribute access simplification. · ca9dd7b4

Grégory Wisniewski authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1554 71dcc9de-d417-0410-9af5-da40c76e7ee4

ca9dd7b4

Fix EpollEvent structure declaration. · c9bca6b6

Vincent Pelletier authored Jan 29, 2010

This fixes strange epoll results (yielding unknown file descriptors).
There is no explanation as of why it worked in 64bits until now.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1553 71dcc9de-d417-0410-9af5-da40c76e7ee4

c9bca6b6

Factorise calls to electPrimary. · bfd97ea5

Vincent Pelletier authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1552 71dcc9de-d417-0410-9af5-da40c76e7ee4

bfd97ea5

Renumber ClusterStates enum entries. · 02311d51

Vincent Pelletier authored Jan 29, 2010

Consequence of previous commit, to preserve code clarity.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1551 71dcc9de-d417-0410-9af5-da40c76e7ee4

02311d51

Remove BOOTING cluster state. · dbd027a9

Vincent Pelletier authored Jan 29, 2010

This state was only internal to master node, and was not even
consistently handled in master (only the first election was done in that
state).
changeClusterState was never called with that state as parameter.
Finally, remove this state from protocol as it's not used any longer.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1550 71dcc9de-d417-0410-9af5-da40c76e7ee4

dbd027a9

During election, node timeout applies or all non-running nodes. · 7147f291

Grégory Wisniewski authored Jan 29, 2010

So that unknown nodes, to which no connection succeed for the current election, are dropped from election process.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1549 71dcc9de-d417-0410-9af5-da40c76e7ee4

7147f291

When an election restart, assume all masters are unknown and candidates for election. · 78dab7fd
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1548 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
78dab7fd

Reduce indentation. · 5e98e011

Grégory Wisniewski authored Jan 29, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1547 71dcc9de-d417-0410-9af5-da40c76e7ee4

5e98e011

Add missing setUnknown() on node class. · fced5fdd
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1546 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fced5fdd
Add assertions to avoid bad node state transitions. · 09c05b4d
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1545 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
09c05b4d
Factorise connectionClosed and timeoutExpired logic. · 6b10848f
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1544 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6b10848f
Call super methods and remove wrong call to 'connectionFailed' · e92d528c
Grégory Wisniewski authored Jan 29, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1543 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e92d528c

28 Jan, 2010 2 commits

Typo, call append() instead of add() on the list. · 3973e15a
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1542 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3973e15a

Some changes in election: · dab39147

Grégory Wisniewski authored Jan 28, 2010

- Nodes start in UNKNOWN state.
- Running and Unknown nodes are candidates during election.
- Set temporarily down if an established connection is lost.
- Keep in unknown state if a connection fails.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1541 71dcc9de-d417-0410-9af5-da40c76e7ee4

dab39147