gitlab_ci_yaml_processor_spec.rb 27.7 KB
Newer Older
1 2
require 'spec_helper'

Valery Sizov's avatar
Valery Sizov committed
3
module Ci
Douwe Maan's avatar
Douwe Maan committed
4
  describe GitlabCiYamlProcessor, lib: true do
5
    let(:path) { 'path' }
6

Valery Sizov's avatar
Valery Sizov committed
7 8 9 10 11 12 13 14 15
    describe "#builds_for_ref" do
      let(:type) { 'test' }

      it "returns builds if no branch specified" do
        config = YAML.dump({
          before_script: ["pwd"],
          rspec: { script: "rspec" }
        })

16
        config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
17 18 19 20

        expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref(type, "master").first).to eq({
          stage: "test",
21
          stage_idx: 1,
Valery Sizov's avatar
Valery Sizov committed
22 23 24
          except: nil,
          name: :rspec,
          only: nil,
Kamil Trzcinski's avatar
Kamil Trzcinski committed
25 26
          commands: "pwd\nrspec",
          tag_list: [],
Valery Sizov's avatar
Valery Sizov committed
27
          options: {},
Kamil Trzcinski's avatar
Kamil Trzcinski committed
28 29
          allow_failure: false,
          when: "on_success"
Valery Sizov's avatar
Valery Sizov committed
30 31
        })
      end
32

33 34 35 36 37 38
      describe :only do
        it "does not return builds if only has another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["deploy"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
39

40
          config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
41

42 43
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end
Valery Sizov's avatar
Valery Sizov committed
44

45 46 47 48 49
        it "does not return builds if only has regexp with another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["/^deploy$/"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
50

51
          config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
52

53 54
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end
Valery Sizov's avatar
Valery Sizov committed
55

56 57 58 59 60
        it "returns builds if only has specified this branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", only: ["master"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
61

62
          config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
63

64 65
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end
Valery Sizov's avatar
Valery Sizov committed
66

67 68 69 70 71
        it "returns builds if only has a list of branches including specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["master", "deploy"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
72

73
          config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
74

75 76
          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end
Valery Sizov's avatar
Valery Sizov committed
77

78 79 80 81 82
        it "returns builds if only has a branches keyword specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
83

84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if only has a tags keyword" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["tags"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if only has current repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches@path"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if only has different repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, only: ["branches@fork"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns build only for specified type" do

          config = YAML.dump({
                               before_script: ["pwd"],
Kamil Trzcinski's avatar
Kamil Trzcinski committed
126
                               rspec: { script: "rspec", type: "test", only: ["master", "deploy"] },
127 128 129
                               staging: { script: "deploy", type: "deploy", only: ["master", "deploy"] },
                               production: { script: "deploy", type: "deploy", only: ["master@path", "deploy"] },
                             })
Valery Sizov's avatar
Valery Sizov committed
130

Kamil Trzcinski's avatar
Kamil Trzcinski committed
131
          config_processor = GitlabCiYamlProcessor.new(config, 'fork')
Valery Sizov's avatar
Valery Sizov committed
132

133
          expect(config_processor.builds_for_stage_and_ref("deploy", "deploy").size).to eq(2)
Kamil Trzcinski's avatar
Kamil Trzcinski committed
134 135
          expect(config_processor.builds_for_stage_and_ref("test", "deploy").size).to eq(1)
          expect(config_processor.builds_for_stage_and_ref("deploy", "master").size).to eq(1)
136
        end
Valery Sizov's avatar
Valery Sizov committed
137 138
      end

139 140 141 142 143 144
      describe :except do
        it "returns builds if except has another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["deploy"] }
                             })
Valery Sizov's avatar
Valery Sizov committed
145

146
          config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
147

148 149 150 151 152 153 154 155 156 157 158 159 160
          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end

        it "returns builds if except has regexp with another branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["/^deploy$/"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(1)
        end
Valery Sizov's avatar
Valery Sizov committed
161

162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230
        it "does not return builds if except has specified this branch" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", except: ["master"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "master").size).to eq(0)
        end

        it "does not return builds if except has a list of branches including specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["master", "deploy"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "does not return builds if except has a branches keyword specified" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if except has a tags keyword" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["tags"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "does not return builds if except has current repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches@path"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(0)
        end

        it "returns builds if except has different repository path" do
          config = YAML.dump({
                               before_script: ["pwd"],
                               rspec: { script: "rspec", type: type, except: ["branches@fork"] }
                             })

          config_processor = GitlabCiYamlProcessor.new(config, path)

          expect(config_processor.builds_for_stage_and_ref(type, "deploy").size).to eq(1)
        end

        it "returns build except specified type" do
          config = YAML.dump({
                               before_script: ["pwd"],
Kamil Trzcinski's avatar
Kamil Trzcinski committed
231 232 233
                               rspec: { script: "rspec", type: "test", except: ["master", "deploy", "test@fork"] },
                               staging: { script: "deploy", type: "deploy", except: ["master"] },
                               production: { script: "deploy", type: "deploy", except: ["master@fork"] },
234 235
                             })

Kamil Trzcinski's avatar
Kamil Trzcinski committed
236
          config_processor = GitlabCiYamlProcessor.new(config, 'fork')
237

Kamil Trzcinski's avatar
Kamil Trzcinski committed
238 239 240
          expect(config_processor.builds_for_stage_and_ref("deploy", "deploy").size).to eq(2)
          expect(config_processor.builds_for_stage_and_ref("test", "test").size).to eq(0)
          expect(config_processor.builds_for_stage_and_ref("deploy", "master").size).to eq(0)
241
        end
Valery Sizov's avatar
Valery Sizov committed
242
      end
243

244 245
    end

Valery Sizov's avatar
Valery Sizov committed
246 247 248 249 250 251 252 253 254
    describe "Image and service handling" do
      it "returns image and service when defined" do
        config = YAML.dump({
                             image: "ruby:2.1",
                             services: ["mysql"],
                             before_script: ["pwd"],
                             rspec: { script: "rspec" }
                           })

255
        config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
256 257 258 259 260

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
261
          stage_idx: 1,
Valery Sizov's avatar
Valery Sizov committed
262 263
          name: :rspec,
          only: nil,
Kamil Trzcinski's avatar
Kamil Trzcinski committed
264 265
          commands: "pwd\nrspec",
          tag_list: [],
Valery Sizov's avatar
Valery Sizov committed
266 267 268 269
          options: {
            image: "ruby:2.1",
            services: ["mysql"]
          },
270 271
          allow_failure: false,
          when: "on_success"
Valery Sizov's avatar
Valery Sizov committed
272 273 274 275 276 277 278 279 280 281 282
        })
      end

      it "returns image and service when overridden for job" do
        config = YAML.dump({
                             image:         "ruby:2.1",
                             services:      ["mysql"],
                             before_script: ["pwd"],
                             rspec:         { image: "ruby:2.5", services: ["postgresql"], script: "rspec" }
                           })

283
        config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
284 285 286 287 288

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
289
          stage_idx: 1,
Valery Sizov's avatar
Valery Sizov committed
290 291
          name: :rspec,
          only: nil,
Kamil Trzcinski's avatar
Kamil Trzcinski committed
292 293
          commands: "pwd\nrspec",
          tag_list: [],
Valery Sizov's avatar
Valery Sizov committed
294 295 296 297
          options: {
            image: "ruby:2.5",
            services: ["postgresql"]
          },
298 299
          allow_failure: false,
          when: "on_success"
Valery Sizov's avatar
Valery Sizov committed
300 301
        })
      end
302 303
    end

Valery Sizov's avatar
Valery Sizov committed
304 305 306 307 308 309 310 311 312 313 314 315
    describe "Variables" do
      it "returns variables when defined" do
        variables = {
          var1: "value1",
          var2: "value2",
        }
        config = YAML.dump({
                             variables: variables,
                             before_script: ["pwd"],
                             rspec: { script: "rspec" }
                           })

316
        config_processor = GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
317 318
        expect(config_processor.variables).to eq(variables)
      end
319 320
    end

321 322 323 324 325 326 327
    describe "When" do
      %w(on_success on_failure always).each do |when_state|
        it "returns #{when_state} when defined" do
          config = YAML.dump({
                               rspec: { script: "rspec", when: when_state }
                             })

328
          config_processor = GitlabCiYamlProcessor.new(config, path)
329 330 331 332 333 334 335
          builds = config_processor.builds_for_stage_and_ref("test", "master")
          expect(builds.size).to eq(1)
          expect(builds.first[:when]).to eq(when_state)
        end
      end
    end

336 337 338
    describe "Caches" do
      it "returns cache when defined globally" do
        config = YAML.dump({
339
                             cache: { paths: ["logs/", "binaries/"], untracked: true, key: 'key' },
340 341 342 343 344 345 346 347 348 349 350
                             rspec: {
                               script: "rspec"
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["logs/", "binaries/"],
          untracked: true,
351
          key: 'key',
352 353 354 355 356 357
        )
      end

      it "returns cache when defined in a job" do
        config = YAML.dump({
                             rspec: {
358
                               cache: { paths: ["logs/", "binaries/"], untracked: true, key: 'key' },
359 360 361 362 363 364 365 366 367 368
                               script: "rspec"
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["logs/", "binaries/"],
          untracked: true,
369
          key: 'key',
370 371 372 373 374
        )
      end

      it "overwrite cache when defined for a job and globally" do
        config = YAML.dump({
375
                             cache: { paths: ["logs/", "binaries/"], untracked: true, key: 'global' },
376 377
                             rspec: {
                               script: "rspec",
378
                               cache: { paths: ["test/"], untracked: false, key: 'local' },
379 380 381 382 383 384 385 386 387
                             }
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first[:options][:cache]).to eq(
          paths: ["test/"],
          untracked: false,
388
          key: 'local',
389 390 391 392
        )
      end
    end

393 394 395 396 397 398
    describe "Artifacts" do
      it "returns artifacts when defined" do
        config = YAML.dump({
                             image:         "ruby:2.1",
                             services:      ["mysql"],
                             before_script: ["pwd"],
399
                             rspec:         {
400
                               artifacts: { paths: ["logs/", "binaries/"], untracked: true, name: "custom_name" },
401 402
                               script: "rspec"
                             }
403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418
                           })

        config_processor = GitlabCiYamlProcessor.new(config)

        expect(config_processor.builds_for_stage_and_ref("test", "master").size).to eq(1)
        expect(config_processor.builds_for_stage_and_ref("test", "master").first).to eq({
          except: nil,
          stage: "test",
          stage_idx: 1,
          name: :rspec,
          only: nil,
          commands: "pwd\nrspec",
          tag_list: [],
          options: {
            image: "ruby:2.1",
            services: ["mysql"],
419
            artifacts: {
420
              name: "custom_name",
421 422 423
              paths: ["logs/", "binaries/"],
              untracked: true
            }
424 425 426 427 428 429 430
          },
          when: "on_success",
          allow_failure: false
        })
      end
    end

431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459
    describe "Hidden jobs" do
      let(:config) do
        YAML.dump({
                    '.hidden_job' => { script: 'test' },
                    'normal_job' => { script: 'test' }
                  })
      end

      let(:config_processor) { GitlabCiYamlProcessor.new(config) }

      subject { config_processor.builds_for_stage_and_ref("test", "master") }

      it "doesn't create jobs that starts with dot" do
        expect(subject.size).to eq(1)
        expect(subject.first).to eq({
          except: nil,
          stage: "test",
          stage_idx: 1,
          name: :normal_job,
          only: nil,
          commands: "\ntest",
          tag_list: [],
          options: {},
          when: "on_success",
          allow_failure: false
        })
      end
    end

Valery Sizov's avatar
Valery Sizov committed
460
    describe "Error handling" do
461 462 463 464
      it "fails to parse YAML" do
        expect{GitlabCiYamlProcessor.new("invalid: yaml: test")}.to raise_error(Psych::SyntaxError)
      end

Valery Sizov's avatar
Valery Sizov committed
465
      it "indicates that object is invalid" do
466
        expect{GitlabCiYamlProcessor.new("invalid_yaml")}.to raise_error(GitlabCiYamlProcessor::ValidationError)
Valery Sizov's avatar
Valery Sizov committed
467 468 469 470 471
      end

      it "returns errors if tags parameter is invalid" do
        config = YAML.dump({ rspec: { script: "test", tags: "mysql" } })
        expect do
472
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
473 474 475 476 477 478
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: tags parameter should be an array of strings")
      end

      it "returns errors if before_script parameter is invalid" do
        config = YAML.dump({ before_script: "bundle update", rspec: { script: "test" } })
        expect do
479
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
480 481 482 483 484 485
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "before_script should be an array of strings")
      end

      it "returns errors if image parameter is invalid" do
        config = YAML.dump({ image: ["test"], rspec: { script: "test" } })
        expect do
486
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
487 488 489
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "image should be a string")
      end

Kamil Trzcinski's avatar
Kamil Trzcinski committed
490 491 492
      it "returns errors if job name is blank" do
        config = YAML.dump({ '' => { script: "test" } })
        expect do
493
          GitlabCiYamlProcessor.new(config, path)
Kamil Trzcinski's avatar
Kamil Trzcinski committed
494 495 496 497 498 499
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "job name should be non-empty string")
      end

      it "returns errors if job name is non-string" do
        config = YAML.dump({ 10 => { script: "test" } })
        expect do
500
          GitlabCiYamlProcessor.new(config, path)
Kamil Trzcinski's avatar
Kamil Trzcinski committed
501 502 503
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "job name should be non-empty string")
      end

Valery Sizov's avatar
Valery Sizov committed
504 505 506
      it "returns errors if job image parameter is invalid" do
        config = YAML.dump({ rspec: { script: "test", image: ["test"] } })
        expect do
507
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
508 509 510 511 512 513
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: image should be a string")
      end

      it "returns errors if services parameter is not an array" do
        config = YAML.dump({ services: "test", rspec: { script: "test" } })
        expect do
514
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
515 516 517 518 519 520
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "services should be an array of strings")
      end

      it "returns errors if services parameter is not an array of strings" do
        config = YAML.dump({ services: [10, "test"], rspec: { script: "test" } })
        expect do
521
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
522 523 524 525 526 527
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "services should be an array of strings")
      end

      it "returns errors if job services parameter is not an array" do
        config = YAML.dump({ rspec: { script: "test", services: "test" } })
        expect do
528
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
529 530 531 532 533 534
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: services should be an array of strings")
      end

      it "returns errors if job services parameter is not an array of strings" do
        config = YAML.dump({ rspec: { script: "test", services: [10, "test"] } })
        expect do
535
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
536 537 538 539 540 541
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: services should be an array of strings")
      end

      it "returns errors if there are unknown parameters" do
        config = YAML.dump({ extra: "bundle update" })
        expect do
542
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
543 544 545 546 547 548
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Unknown parameter: extra")
      end

      it "returns errors if there are unknown parameters that are hashes, but doesn't have a script" do
        config = YAML.dump({ extra: { services: "test" } })
        expect do
549
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
550 551 552
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Unknown parameter: extra")
      end

553
      it "returns errors if there are no jobs defined" do
Valery Sizov's avatar
Valery Sizov committed
554 555
        config = YAML.dump({ before_script: ["bundle update"] })
        expect do
556
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
557 558 559 560 561 562
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "Please define at least one job")
      end

      it "returns errors if job allow_failure parameter is not an boolean" do
        config = YAML.dump({ rspec: { script: "test", allow_failure: "string" } })
        expect do
563
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
564 565 566 567
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: allow_failure parameter should be an boolean")
      end

      it "returns errors if job stage is not a string" do
568
        config = YAML.dump({ rspec: { script: "test", type: 1 } })
Valery Sizov's avatar
Valery Sizov committed
569
        expect do
570
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
571 572 573 574
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test, deploy")
      end

      it "returns errors if job stage is not a pre-defined stage" do
575
        config = YAML.dump({ rspec: { script: "test", type: "acceptance" } })
Valery Sizov's avatar
Valery Sizov committed
576
        expect do
577
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
578 579 580 581
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test, deploy")
      end

      it "returns errors if job stage is not a defined stage" do
582
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", type: "acceptance" } })
Valery Sizov's avatar
Valery Sizov committed
583
        expect do
584
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
585 586 587 588 589 590
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: stage parameter should be build, test")
      end

      it "returns errors if stages is not an array" do
        config = YAML.dump({ types: "test", rspec: { script: "test" } })
        expect do
591
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
592 593 594 595 596 597
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "stages should be an array of strings")
      end

      it "returns errors if stages is not an array of strings" do
        config = YAML.dump({ types: [true, "test"], rspec: { script: "test" } })
        expect do
598
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
599 600 601 602 603 604
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "stages should be an array of strings")
      end

      it "returns errors if variables is not a map" do
        config = YAML.dump({ variables: "test", rspec: { script: "test" } })
        expect do
605
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
606 607 608 609 610 611
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "variables should be a map of key-valued strings")
      end

      it "returns errors if variables is not a map of key-valued strings" do
        config = YAML.dump({ variables: { test: false }, rspec: { script: "test" } })
        expect do
612
          GitlabCiYamlProcessor.new(config, path)
Valery Sizov's avatar
Valery Sizov committed
613 614
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "variables should be a map of key-valued strings")
      end
615 616

      it "returns errors if job when is not on_success, on_failure or always" do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
617
        config = YAML.dump({ rspec: { script: "test", when: 1 } })
618
        expect do
619
          GitlabCiYamlProcessor.new(config, path)
620 621
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: when parameter should be on_success, on_failure or always")
      end
622

623 624 625 626 627 628 629
      it "returns errors if job artifacts:name is not an a string" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", artifacts: { name: 1 } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: artifacts:name parameter should be a string")
      end

630 631
      it "returns errors if job artifacts:untracked is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", artifacts: { untracked: "string" } } })
632 633
        expect do
          GitlabCiYamlProcessor.new(config)
634 635 636 637 638 639 640 641
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: artifacts:untracked parameter should be an boolean")
      end

      it "returns errors if job artifacts:paths is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", artifacts: { paths: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: artifacts:paths parameter should be an array of strings")
642
      end
643 644 645 646 647 648 649 650 651 652 653 654 655 656 657

      it "returns errors if cache:untracked is not an array of strings" do
        config = YAML.dump({ cache: { untracked: "string" }, rspec: { script: "test" } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "cache:untracked parameter should be an boolean")
      end

      it "returns errors if cache:paths is not an array of strings" do
        config = YAML.dump({ cache: { paths: "string" }, rspec: { script: "test" } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "cache:paths parameter should be an array of strings")
      end

658 659 660 661 662 663 664 665 666 667 668 669 670 671
      it "returns errors if cache:key is not a string" do
        config = YAML.dump({ cache: { key: 1 }, rspec: { script: "test" } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "cache:key parameter should be a string")
      end

      it "returns errors if job cache:key is not an a string" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", cache: { key: 1 } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: cache:key parameter should be a string")
      end

672 673 674 675 676 677 678 679 680 681 682 683 684
      it "returns errors if job cache:untracked is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", cache: { untracked: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: cache:untracked parameter should be an boolean")
      end

      it "returns errors if job cache:paths is not an array of strings" do
        config = YAML.dump({ types: ["build", "test"], rspec: { script: "test", cache: { paths: "string" } } })
        expect do
          GitlabCiYamlProcessor.new(config)
        end.to raise_error(GitlabCiYamlProcessor::ValidationError, "rspec job: cache:paths parameter should be an array of strings")
      end
685 686 687
    end
  end
end