Commit 2184c753 authored by Shinya Maeda's avatar Shinya Maeda

Revise comments in ArchiveLegacyTraces

parent 623accf9
...@@ -6,10 +6,10 @@ module Gitlab ...@@ -6,10 +6,10 @@ module Gitlab
module BackgroundMigration module BackgroundMigration
class ArchiveLegacyTraces class ArchiveLegacyTraces
def perform(start_id, stop_id) def perform(start_id, stop_id)
# This background migrations directly refer ::Ci::Build model which is defined in application code. # This background migration directly refers to ::Ci::Build model which is defined in application code.
# In general, migration code should be isolated as much as possible in order to be idempotent. # In general, migration code should be isolated as much as possible in order to be idempotent.
# However, `archive!` logic is too complicated to be replicated. So we chose a way to refer ::Ci::Build directly # However, `archive!` method is too complicated to be replicated by coping its subsequent code.
# and we don't change the `archive!` logic until 11.1 # So we chose a way to use ::Ci::Build directly and we don't change the `archive!` method until 11.1
::Ci::Build.finished.without_archived_trace ::Ci::Build.finished.without_archived_trace
.where(id: start_id..stop_id).find_each do |build| .where(id: start_id..stop_id).find_each do |build|
begin begin
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment