Commit 3d134c50 authored by Kushal Pandya's avatar Kushal Pandya

Improve isInViewport impl, autoscroll behavior

- Improve isInViewport impementation to be robust.
- Autoscroll is now a status indicator instead of toggle button
- Scrolling build log enables autoscroll itself when scrolled to bottom.
parent 769a9bcc
...@@ -179,6 +179,7 @@ ...@@ -179,6 +179,7 @@
if ($autoScrollContainer.length) { // Show and Reposition Autoscroll Status Message if ($autoScrollContainer.length) { // Show and Reposition Autoscroll Status Message
$autoScrollContainer.show().css({ top: $body.outerHeight() - 75 }); $autoScrollContainer.show().css({ top: $body.outerHeight() - 75 });
<<<<<<< fbd5f4507b310d6dc1305696851e9860b48fa0ba
} }
} }
...@@ -195,6 +196,31 @@ ...@@ -195,6 +196,31 @@
// Check if Refresh Animation is in Viewport and enable Autoscroll, disable otherwise. // Check if Refresh Animation is in Viewport and enable Autoscroll, disable otherwise.
$autoScrollStatus.data("state", isInViewport($('.js-build-refresh')) ? 'enabled' : 'disabled'); $autoScrollStatus.data("state", isInViewport($('.js-build-refresh')) ? 'enabled' : 'disabled');
} }
=======
}
}
if (!isInViewport($upBuildTrace) && !isInViewport($downBuildTrace)) { // User is somewhere in middle of Build Log
$scrollTopBtn.show().addClass('sticky');
$scrollBottomBtn.show().addClass('sticky');
if ($autoScrollContainer.length) {
$autoScrollContainer.hide();
}
}
if (this.buildStatus === "running" || this.buildStatus === "pending") {
if (isInViewport($('.js-build-refresh'))) { // Check if Refresh Animation is in Viewport
if ($autoScrollStatus.data("state") === 'disabled') {
$autoScrollStatus.data("state", 'enabled'); // Enable Autoscroll
}
} else {
if ($autoScrollStatus.data("state") === 'enabled') {
$autoScrollStatus.data("state", 'disabled'); // Disable Autoscroll
}
}
}
>>>>>>> Improve isInViewport impl, autoscroll behavior
}; };
Build.prototype.shouldHideSidebarForViewport = function() { Build.prototype.shouldHideSidebarForViewport = function() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment