Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
4fae2574
Commit
4fae2574
authored
Nov 23, 2017
by
Christiaan Van den Poel
Committed by
Christiaan Van den Poel
Nov 27, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
initializes the branches dropdown upon invalid entry
Added Changelog added feature spec
parent
a7f6ab95
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
0 deletions
+18
-0
app/assets/javascripts/dispatcher.js
app/assets/javascripts/dispatcher.js
+1
-0
changelogs/unreleased/15588-fix-empty-dropdown-on-create-new-pipeline-in-case-of-validation-errors.yml
...n-on-create-new-pipeline-in-case-of-validation-errors.yml
+5
-0
spec/features/projects/pipelines/pipelines_spec.rb
spec/features/projects/pipelines/pipelines_spec.rb
+12
-0
No files found.
app/assets/javascripts/dispatcher.js
View file @
4fae2574
...
@@ -383,6 +383,7 @@ import ProjectVariables from './project_variables';
...
@@ -383,6 +383,7 @@ import ProjectVariables from './project_variables';
projectImport
();
projectImport
();
break
;
break
;
case
'
projects:pipelines:new
'
:
case
'
projects:pipelines:new
'
:
case
'
projects:pipelines:create
'
:
new
NewBranchForm
(
$
(
'
.js-new-pipeline-form
'
));
new
NewBranchForm
(
$
(
'
.js-new-pipeline-form
'
));
break
;
break
;
case
'
projects:pipelines:builds
'
:
case
'
projects:pipelines:builds
'
:
...
...
changelogs/unreleased/15588-fix-empty-dropdown-on-create-new-pipeline-in-case-of-validation-errors.yml
0 → 100644
View file @
4fae2574
---
title
:
Initializes the branches dropdown when the 'Start new pipeline' failed due to validation errors
merge_request
:
15588
author
:
Christiaan Van den Poel
type
:
fixed
spec/features/projects/pipelines/pipelines_spec.rb
View file @
4fae2574
...
@@ -500,6 +500,18 @@ describe 'Pipelines', :js do
...
@@ -500,6 +500,18 @@ describe 'Pipelines', :js do
end
end
it
{
expect
(
page
).
to
have_content
(
'Missing .gitlab-ci.yml file'
)
}
it
{
expect
(
page
).
to
have_content
(
'Missing .gitlab-ci.yml file'
)
}
it
'creates a pipeline after first request failed and a valid gitlab-ci.yml file is available when trying again'
do
click_button
project
.
default_branch
stub_ci_pipeline_to_return_yaml_file
page
.
within
'.dropdown-menu'
do
click_link
'master'
end
expect
{
click_on
'Create pipeline'
}
.
to
change
{
Ci
::
Pipeline
.
count
}.
by
(
1
)
end
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment