Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
52ca9bf6
Commit
52ca9bf6
authored
Oct 07, 2016
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
2f7e28d1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
doc/development/code_review.md
doc/development/code_review.md
+4
-4
No files found.
doc/development/code_review.md
View file @
52ca9bf6
...
@@ -35,7 +35,7 @@ request is up to one of our merge request "endbosses", denoted on the
...
@@ -35,7 +35,7 @@ request is up to one of our merge request "endbosses", denoted on the
## Having your code reviewed
## Having your code reviewed
Please keep in mind that code review is a process that can take multiple
Please keep in mind that code review is a process that can take multiple
iterations, and reviewer may spot things later that they may not have seen the
iterations, and reviewer
s
may spot things later that they may not have seen the
first time.
first time.
-
The first reviewer of your code is _you_. Before you perform that first push
-
The first reviewer of your code is _you_. Before you perform that first push
...
@@ -69,9 +69,9 @@ experience, refactors the existing code). Then:
...
@@ -69,9 +69,9 @@ experience, refactors the existing code). Then:
someone else would be confused by it as well.
someone else would be confused by it as well.
-
After a round of line notes, it can be helpful to post a summary note such as
-
After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address."
"LGTM :thumbsup:", or "Just a couple things to address."
-
Avoid accepting a merge request before the build succeeds
("Merge when build
-
Avoid accepting a merge request before the build succeeds
. Of course, "Merge
succeeds" is fine)
.
When Build Succeeds" (MWBS) is fine
.
-
If you set the MR to "Merge
when build s
ucceeds", you should take over
-
If you set the MR to "Merge
When Build S
ucceeds", you should take over
subsequent revisions for anything that would be spotted after that.
subsequent revisions for anything that would be spotted after that.
## Credits
## Credits
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment